Skip to contentSkip to conversation

VFS: make file->f_pos access atomic on 32bit arch

PATCH Michael Trimarchi 2 participants 2 messages Sep 16, 2008 VFS

lore
Share & tools
lore
#0 lore raw

Hi,

Review

Quoted 4 lines
(quoted diff) +2 -0
+        if (offset != file_pos_read(file))
+            file_pos_write(file, offset);
        retval = offset;
    }

Is not more efficient here a compare xchg operation?

Regards Michael

__________________________________________________
Do You Yahoo!?
Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi
http://mail.yahoo.it

#1 lore raw
Quoted 8 lines · Michael Trimarchi

Hi,

Review

Quoted 4 lines
(quoted diff) +2 -0
+        if (offset != file_pos_read(file))
+            file_pos_write(file, offset);
        retval = offset;
    }

Is not more efficient here a compare xchg operation?

The compiler should do it if it was.