Skip to contentSkip to conversation

: Gradual conversion to sk_buff list-head..

PATCH In review David Miller 1 participant 1 message Sep 23, 2008

Subsystems (2)
lore
Share & tools
lore

David Miller

author maintainer
#0 lore raw

cover : Gradual conversion to sk_buff list-head..

As I mentioned in my INFO patch the other day I'm trying to convert sk_buff to use list_head's.

To make the transition smoother I've started to hit places one by one that directly reference the sk_buff_head list handling implementation details and make them use only the provided interfaces. I've added new interfaces where necessary to add more parity with what linux/list.h provides.

Of note is that there are now list splice interfaces, as well as a "light weight" sk_buff_head initializer for on-stack local list cases.

There is more to do, but once it's all handled it should be a matter of only editing linux/skbuff.h and net/core/skbuff.c to perform the final conversion.

The trickiest part so far is the PPP MP fragmentation reassembly code. I converted ISDN's copy, and am working on ppp_generic.c's at the moment in my local tree.

Really we shouldn't have two copies (their implementations are even slightly different wrt. handling unfinished frames and sequence gaps).

But such consolidation is a task for later.

All of this is pushed to net-next-2.6, so if you encounter some errors let me know and I'll get them fixed up as fast as possible.