Skip to content

: Gradual conversion to sk_buff list-head..

David Miller netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7: net: Remove __skb_insert() calls outside of skbuff internals.drivers/net/cassini.c drivers/net/ppp_generic.c drivers/net/pppol2tp.c +3 more+9 -100 replies
2/7: atm: idt77252: Use generic SKB queue management instead of home-grown scheme.drivers/atm/idt77252.c drivers/atm/idt77252.h+10 -260 replies
3/7: net: Add new interfaces for SKB list light-weight init and splicing.include/linux/skbuff.h+94 -20 replies
4/7: aoe: Use SKB interfaces for list management instead of home-grown stuff.drivers/block/aoe/aoe.h drivers/block/aoe/aoeblk.c drivers/block/aoe/aoechr.c +4 more+56 -760 replies
5/7: bluetooth: hci_bcsp: Use SKB list interfaces instead of home-grown stuff.drivers/bluetooth/hci_bcsp.c+9 -91 reply
6/7: isdn: isdn_ppp: Use SKB list facilities instead of home-grown implementation.drivers/isdn/i4l/isdn_ppp.c include/linux/isdn_ppp.h+190 -1640 replies
7/7: cxgb3: Use SKB list interfaces instead of home-grown implementation.drivers/net/cxgb3/adapter.h drivers/net/cxgb3/l2t.c drivers/net/cxgb3/l2t.h +1 more+42 -480 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7]: Gradual conversion to sk_buff list-head..

As I mentioned in my INFO patch the other day I'm trying to convert sk_buff to use list_head's.

To make the transition smoother I've started to hit places one by one that directly reference the sk_buff_head list handling implementation details and make them use only the provided interfaces. I've added new interfaces where necessary to add more parity with what linux/list.h provides.

Of note is that there are now list splice interfaces, as well as a "light weight" sk_buff_head initializer for on-stack local list cases.

There is more to do, but once it's all handled it should be a matter of only editing linux/skbuff.h and net/core/skbuff.c to perform the final conversion.

The trickiest part so far is the PPP MP fragmentation reassembly code. I converted ISDN's copy, and am working on ppp_generic.c's at the moment in my local tree.

Really we shouldn't have two copies (their implementations are even slightly different wrt. handling unfinished frames and sequence gaps).

But such consolidation is a task for later.

All of this is pushed to net-next-2.6, so if you encounter some errors let me know and I'll get them fixed up as fast as possible.