Skip to contentSkip to conversation

Olimex SAM9-L9260 board support

PATCH New Cristian Birsan 3 participants 18 messages Oct 6, 2008 – Nov 1, 2008

Subsystems (3)
Kbuild Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Cristian Birsan

author
#0 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Added support for the Olimex SAM9-L9260 development board. This patch is based on u-boot v1.3.4.

Tested with data flash only (not with NAND).

Signed-off-by Cristian Birsan <[email protected]>
---
  MAKEALL                            |    1 +
  Makefile                           |   21 ++--
  board/olimex/sam9l9260/Makefile    |   59 ++++++++
  board/olimex/sam9l9260/config.mk   |    1 +
  board/olimex/sam9l9260/led.c       |   64 +++++++++
  board/olimex/sam9l9260/nand.c      |   78 +++++++++++
  board/olimex/sam9l9260/partition.c |   39 ++++++
  board/olimex/sam9l9260/sam9l9260.c |  264 ++++++++++++++++++++++++++++++++++++
  drivers/mtd/nand/nand_ids.c        |    2 +
  include/configs/sam9l9260.h        |  212 +++++++++++++++++++++++++++++
  10 files changed, 732 insertions(+), 9 deletions(-)

create mode 100644 board/olimex/sam9l9260/Makefile create mode 100644 board/olimex/sam9l9260/config.mk create mode 100644 board/olimex/sam9l9260/led.c create mode 100644 board/olimex/sam9l9260/nand.c create mode 100644 board/olimex/sam9l9260/partition.c create mode 100644 board/olimex/sam9l9260/sam9l9260.c create mode 100644 include/configs/sam9l9260.h

MAKEALL +1 -0
index 9ccb9ac..0e2cb36 100755
@@ -542,6 +542,7 @@ LIST_at91="		\
  	kb9202		\
  	mp2usb		\
  	m501sk		\
+	sam9l9260	\
  "
 
  #########################################################################
Makefile +12 -9
index 7c13ce8..5b0acae 100644
@@ -2487,15 +2487,6 @@ shannon_config	:	unconfig
  at91rm9200dk_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm920t at91rm9200dk atmel at91rm9200
 
-at91sam9261ek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9261ek atmel at91
-
-at91sam9263ek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
-
-at91sam9rlek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91
-
  cmc_pu2_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
 

@@ -2521,6 +2512,18 @@ at91cap9adk_config	:	unconfig
  at91sam9260ek_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9260ek atmel at91
 
+at91sam9261ek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9261ek atmel at91
+
+at91sam9263ek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
+
+at91sam9rlek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91
+
+sam9l9260_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs sam9l9260 olimex at91
+
  ########################################################################
  ## ARM Integrator boards - see doc/README-integrator for more info.
  integratorap_config	\
board/olimex/sam9l9260/Makefile new file +59 -0

59 lines not on this page · raw message

board/olimex/sam9l9260/config.mk new file +1 -0
new file mode 100644
index 0000000..ff2cfd1
@@ -0,0 +1 @@
+TEXT_BASE = 0x23f00000
board/olimex/sam9l9260/led.c new file +64 -0

64 lines not on this page · raw message

board/olimex/sam9l9260/nand.c new file +78 -0

78 lines not on this page · raw message

board/olimex/sam9l9260/partition.c new file +39 -0
new file mode 100644
index 0000000..b29c29a
@@ -0,0 +1,39 @@
+/*
+ * (C) Copyright 2008
+ * Ulf Samuelsson <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+#include <common.h>
+#include <config.h>
+#include <asm/hardware.h>
+#include <dataflash.h>
+
+AT91S_DATAFLASH_INFO dataflash_info[CFG_MAX_DATAFLASH_BANKS];
+
+struct dataflash_addr cs[CFG_MAX_DATAFLASH_BANKS] = {
+	{CFG_DATAFLASH_LOGIC_ADDR_CS0, 0},	/* Logical adress, CS */
+	{CFG_DATAFLASH_LOGIC_ADDR_CS1, 1}
+};
+
+/*define the area offsets*/
+dataflash_protect_t area_list[NB_DATAFLASH_AREA] = {
+	{0x00000000, 0x000041FF, FLAG_PROTECT_SET,   0, "Bootstrap"},
+	{0x00004200, 0x000083FF, FLAG_PROTECT_CLEAR, 0, "Environment"},
+	{0x00008400, 0x00041FFF, FLAG_PROTECT_SET,   0, "U-Boot"},
+	{0x00042000, 0x0020FFFF, FLAG_PROTECT_CLEAR, 0,	"Kernel"},
+};
board/olimex/sam9l9260/sam9l9260.c new file +264 -0

264 lines not on this page · raw message

drivers/mtd/nand/nand_ids.c +2 -0
index 2ff75c9..ec2ac55 100644
@@ -69,6 +69,8 @@ struct nand_flash_dev nand_flash_ids[] = {
 
  	{"NAND 256MiB 3,3V 8-bit",	0x71, 512, 256, 0x4000, 0},
 
+	{"NAND 512MiB 3,3V 8-bit",      0xDC, 512, 512, 0x4000, 0},
+
  	/*
  	 * These are the new chips with large page size. The pagesize and the
  	 * erasesize is determined from the extended id bytes
include/configs/sam9l9260.h new file +212 -0

212 lines not on this page · raw message

Signature · 1 line
1.5.5.1
#1 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Dear Cristian Birsan,

board/olimex/sam9l9260/sam9l9260.c line 252

Quoted 10 lines
board/olimex/sam9l9260/sam9l9260.c new file +10 -0
+#ifdef CONFIG_RESET_PHY_R
+void reset_phy(void)
+{
+#ifdef CONFIG_MACB
+	/*
+	 * Initialize ethernet HW addr prior to starting Linux,
+	 * needed for nfsroot
+	 */
+	eth_init(gd->bd);
+#endif

Please do NOT do this. It's a violation of the U-Boot design principles, which clearly say that only such periphereals that are actually being used by U-Boot shall be initialized, and even if they are being used, these shall be deactivated after use.

Carelessly leaving ports or devices in an initialized stated has been the source for problems too many times before.

Don't do that.

Quoted 1 line

+#define ROUND(A, B) (((A) + (B)) & ~((B) - 1))

First I think that this is wrong (maybe you need "B-1" instead of "B" in the first part?), second we already have DIV_ROUND_UP defined in common.h so please use this.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A well-written program is its own heaven; a poorly-written program is
its own hell.             -- Geoffrey James, "The Tao of Programming"
author
#2 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Dear Wolfgang Denk,

Thank you for your quick response.

Quoted 16 lines

board/olimex/sam9l9260/sam9l9260.c line 252

Quoted 10 lines
board/olimex/sam9l9260/sam9l9260.c new file +10 -0
+#ifdef CONFIG_RESET_PHY_R
+void reset_phy(void)
+{
+#ifdef CONFIG_MACB
+    /*
+     * Initialize ethernet HW addr prior to starting Linux,
+     * needed for nfsroot
+     */
+    eth_init(gd->bd);
+#endif

Please do NOT do this. It's a violation of the U-Boot design principles, which clearly say that only such periphereals that are actually being used by U-Boot shall be initialized, and even if they are being used, these shall be deactivated after use.

Quoted 5 lines

Carelessly leaving ports or devices in an initialized stated has been the source for problems too many times before.

Don't do that.

The above code section is used also in other ATMEL boards like at91sam9260ek ( /board/atmel/at91sam9260ek/at91sam9260ek.c ), at91sam9261ek, at91sam9263ek, at91sam9rlek. This is my first patch sent to U-Boot and I used that code as reference.

The board that i have (SAM9-L9260 from Olimex ) is close to AT91SAM9260EK from ATMEL.

How do you think i can do this the right way?

Quoted 5 lines
Quoted 1 line

+#define ROUND(A, B) (((A) + (B)) & ~((B) - 1))

First I think that this is wrong (maybe you need "B-1" instead of "B" in the first part?), second we already have DIV_ROUND_UP defined in common.h so please use this.

Thanks, good catch. I will fix this and submit a new patch.

Best regards,
Cristian Birsan

#3 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Dear Cristian Birsan,

Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 5 lines

Carelessly leaving ports or devices in an initialized stated has been the source for problems too many times before.

Don't do that.

The above code section is used also in other ATMEL boards like at91sam9260ek ( /board/atmel/at91sam9260ek/at91sam9260ek.c ), at91sam9261ek, at91sam9263ek, at91sam9rlek. This is my first patch sent to U-Boot and I used that code as reference.

So this problem escaped the review when that old code was added.

So we can only ask the baord maintainer and the AT91 custodian to take care of the existing code and clean ipt up ASAP.

But we should not add more copies of that bad example.

Quoted 4 lines

The board that i have (SAM9-L9260 from Olimex ) is close to AT91SAM9260EK from ATMEL.

How do you think i can do this the right way?

Well, the Right Thing (TM) would be to use a device tree to pass such information to Linux, but that's a long way to go still.

In the mean time, other methods should be used to pass the MAC address information to the Linux network driver (I understand this is all what needs to be done, right?). In the simplest case, use an "ethaddr=..." boot argument. [Make sure to read the ML archive before you try to bring up this topic on the linux-arm ML; this has been discussed in *length* before.]

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Due to lack of disk space, this fortune database has been discontinued.
author
#4 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Dear Wolfgang Denk,

Regarding the following:

+#define ROUND(A, B) (((A) + (B)) & ~((B) - 1))
+/*
+ * Size of malloc() pool
+ */
+#define CFG_MALLOC_LEN ROUND(3 * CONFIG_ENV_SIZE + 128*1024, 0x1000)

I tried to include the common.h file in my configuration file but this breaks u-boot compilation (it's
not safe to include common.h standalone) .I noticed that none of other board configuration files
include common.h

If I replace the ROUND(A,B) macro with #define DIV_ROUND_UP(n,d) (((n)
+ (d) - 1) / (d))
macro when i try to make u-boot I obtain the following errors:

start.S: Assembler messages:
start.S:339: Error: invalid constant (802d) after fixup

It appears to me that the solution for the moment is to use the following fixed macro:

	define ROUND(A, B)		(((A) + (B) -1) & ~((B) - 1))

Regarding the following:

Quoted 7 lines
Quoted 7 lines
board/olimex/sam9l9260/sam9l9260.c new file +7 -0
+#ifdef CONFIG_RESET_PHY_R
+void reset_phy(void)
+{
+#ifdef CONFIG_MACB
+    /*
+     * Initialize ethernet HW addr prior to starting Linux,
+     * needed for nfsroot
Quoted 8 lines

board/olimex/sam9l9260/sam9l9260.c line 252

Quoted 3 lines
board/olimex/sam9l9260/sam9l9260.c new file +3 -0
+     */
+    eth_init(gd->bd);
+#endif

Please do NOT do this. It's a violation of the U-Boot design principles, which clearly say that only such periphereals that are actually being used by U-Boot shall be initialized, and even if they are being used, these shall be deactivated after use.

I removed the reset_phy() function and I do not use anymore CONFIG_RESET_PHY_R. I use setenv ethaddr to configure the MAC address of the Ethernet controller.

Is it ok to resend the patch with the above changes ?

Best regards,
Cristian Birsan

#5 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Dear Cristian,

Quoted 4 lines · In message <[email protected]> you…

I tried to include the common.h file in my configuration file but this breaks u-boot compilation (it's
not safe to include common.h standalone) .I noticed that none of other

What do you mean by "include common.h standalone" ?

Quoted 2 lines

board configuration files
include common.h

Normally it's not needed, because all files where the board config file will be used also include common.h.

Quoted 6 lines

If I replace the ROUND(A,B) macro with #define DIV_ROUND_UP(n,d) (((n)
+ (d) - 1) / (d))
macro when i try to make u-boot I obtain the following errors:

start.S: Assembler messages:
start.S:339: Error: invalid constant (802d) after fixup

So what does this source line look like in you version of the code?

802d = 0x802d = 32813 looks wrong to me. PLease check wht the code is doing there. There might be a (hidden) bug somewhere.

Quoted 3 lines

It appears to me that the solution for the moment is to use the following fixed macro:

	define ROUND(A, B)		(((A) + (B) -1) & ~((B) - 1))

Nevertheless check what your code in start.S is doing.

Quoted 4 lines

I removed the reset_phy() function and I do not use anymore CONFIG_RESET_PHY_R. I use setenv ethaddr to configure the MAC address of the Ethernet controller.

Is it ok to resend the patch with the above changes ?

I think yes.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be wiser than other people if you can, but do not tell them so.
                                       -- Philip Earl of Chesterfield
author
#6 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Dear Wolfgang Denk,

Quoted 6 lines
Quoted 3 lines · In message <[email protected]> you…

I tried to include the common.h file in my configuration file but this breaks u-boot compilation (it's
not safe to include common.h standalone) .I noticed that none of other

What do you mean by "include common.h standalone" ?

Through include common.h standalone I mean:

#ifndef __CONFIG_H
#define __CONFIG_H

#include <common.h>
...rest of the file...

When I try to compile with the above include I obtain the following errors:

make[1]: Entering directory `/home/cristi/work/u-boot/u-boot-1.3.4/tools'
gcc -g -Wall -idirafter /home/cristi/work/u-boot/u-boot-1.3.4/include -idirafter /home/cristi/work/u-boot/u-boot-1.3.4/include2 -idirafter /home/cristi/work/u-boot/u-boot-1.3.4/include -DTEXT_BASE=0x23f00000 -DUSE_HOSTCC -O -c -o mkimage.o mkimage.c In file included from /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:111,

                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/configs/sam9l9260.h:32,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/config.h:2,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/command.h:30,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/image.h:37,
                  from mkimage.c:26:
/home/cristi/work/u-boot/u-boot-1.3.4/include/flash.h:36: error: ?CFG_MAX_FLASH_SECT? undeclared here (not in a function)
In file included from /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:132,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/configs/sam9l9260.h:32,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/config.h:2,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/command.h:30,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/image.h:37,
                  from mkimage.c:26:
/home/cristi/work/u-boot/u-boot-1.3.4/include/asm/u-boot.h:50: error: ?CONFIG_NR_DRAM_BANKS? undeclared here (not in a function)
In file included from /home/cristi/work/u-boot/u-boot-1.3.4/include/configs/sam9l9260.h:32,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/config.h:2,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/command.h:30,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/image.h:37,
                  from mkimage.c:26:

/home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:207: error: expected ?=?, ?,?, ?;?, ?asm? or ?__attribute__? before ?initdram? /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:209: error: expected ?)? before ?const? /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:246: error: conflicting types for ?getenv? /usr/include/stdlib.h:545: error: previous declaration of ?getenv? was here /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:252: error: conflicting types for ?setenv? /usr/include/stdlib.h:563: error: previous declaration of ?setenv? was here /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:647: error: conflicting types for ?_IO_getc? /usr/include/libio.h:458: error: previous declaration of ?_IO_getc? was here
In file included from /home/cristi/work/u-boot/u-boot-1.3.4/include/configs/sam9l9260.h:32,

                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/config.h:2,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/command.h:30,
                  from /home/cristi/work/u-boot/u-boot-1.3.4/include/image.h:37,
                  from mkimage.c:26:

/home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:651:23: error: macro "putc" requires 2 arguments, but only 1 given /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:651: error: ?putc? redeclared as different kind of symbol /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:652: error: conflicting types for ?puts? /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:653: error: conflicting types for ?printf? /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:655: error: conflicting types for ?vprintf? /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:671: error: conflicting types for ?fprintf? /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:673: error: conflicting types for ?fputs? /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:674: error: conflicting types for ?fputc? /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:676: error: conflicting types for ?fgetc? /usr/include/stdio.h:511: error: previous declaration of ?fgetc? was here
mkimage.c:34: error: conflicting types for ?crc32? /home/cristi/work/u-boot/u-boot-1.3.4/include/common.h:625: error: previous declaration of ?crc32? was here make[1]: *** [mkimage.o] Error 1
make[1]: Leaving directory `/home/cristi/work/u-boot/u-boot-1.3.4/tools'
make: *** [tools] Error 2

Quoted 6 lines
Quoted 6 lines

If I replace the ROUND(A,B) macro with #define DIV_ROUND_UP(n,d) (((n)
+ (d) - 1) / (d))
macro when i try to make u-boot I obtain the following errors:

start.S: Assembler messages:
start.S:339: Error: invalid constant (802d) after fixup

The code that generate the above error is

#define ROUND(A, B) (((A) + (B) -1) / (B))
/*
* Size of malloc() pool
*/
#define CFG_MALLOC_LEN ROUND(3 * CONFIG_ENV_SIZE + 128*1024, 0x1000)
#define CFG_GBL_DATA_SIZE 128 /* 128 bytes for initial data */

#define CONFIG_STACKSIZE (32*1024) /* regular stack */

The error message is as follows:

make -C cpu/arm926ejs start.o
make[1]: Entering directory `/home/cristi/work/u-boot/u-boot-1.3.4/cpu/arm926ejs'
/opt/arm-2008q1/bin/arm-none-linux-gnueabi-gcc -D__ASSEMBLY__ -g -Os -fno-strict-aliasing -fno-common -ffixed-r8 -msoft-float -D__KERNEL__ -DTEXT_BASE=0x23f00000 -I/home/cristi/work/u-boot/u-boot-1.3.4/include -fno-builtin -ffreestanding -nostdinc -isystem /opt/arm-2008q1/bin/../lib/gcc/arm-none-linux-gnueabi/4.2.3/include -pipe -DCONFIG_ARM -D__ARM__ -march=armv4 -mabi=apcs-gnu -march=armv5te -c -o start.o start.S
start.S: Assembler messages:
start.S:339: Error: invalid constant (802d) after fixup
start.S:340: Error: invalid constant (802d) after fixup
start.S:345: Error: invalid constant (802d) after fixup
start.S:346: Error: invalid constant (802d) after fixup
start.S:351: Error: invalid constant (802d) after fixup
start.S:352: Error: invalid constant (802d) after fixup
start.S:357: Error: invalid constant (802d) after fixup
start.S:358: Error: invalid constant (802d) after fixup
start.S:363: Error: invalid constant (802d) after fixup
start.S:364: Error: invalid constant (802d) after fixup
start.S:388: Error: invalid constant (802d) after fixup
start.S:389: Error: invalid constant (802d) after fixup
start.S:394: Error: invalid constant (802d) after fixup
start.S:395: Error: invalid constant (802d) after fixup
make[1]: *** [start.o] Error 1
make[1]: Leaving directory `/home/cristi/work/u-boot/u-boot-1.3.4/cpu/arm926ejs'
make: *** [cpu/arm926ejs/start.o] Error 2

The last line in which CFG_MALLOC_LEN is used in start.S is 313. All the errors are after that line and i can't find a reason. The lines with asm instructions errors doesen't seem to be related to the CFG_MALLOC_LEN. I supose it is something related to preprocessor

	sub	r13, r13, #(CONFIG_STACKSIZE+CFG_MALLOC_LEN)
Quoted 4 lines
Quoted 2 lines

Is it ok to resend the patch with the above changes ?

I think yes.

Here is my new patch. I changed also bootargs and bootcommand for DataFlash in the board configuration file.

[PATCH] Olimex SAM9-L9260 board support

Added support for the Olimex SAM9-L9260 development board. This patch is based on u-boot v1.3.4.

Tested with DataFlash only (not with NAND).

Signed-off-by Cristian Birsan <[email protected]>
---
  MAKEALL                            |    1 +
  Makefile                           |   21 ++--
  board/olimex/sam9l9260/Makefile    |   59 +++++++++
  board/olimex/sam9l9260/config.mk   |    1 +
  board/olimex/sam9l9260/led.c       |   64 +++++++++
  board/olimex/sam9l9260/nand.c      |   78 +++++++++++
  board/olimex/sam9l9260/partition.c |   39 ++++++
  board/olimex/sam9l9260/sam9l9260.c |  251 ++++++++++++++++++++++++++++++++++++
  drivers/mtd/nand/nand_ids.c        |    2 +
  include/configs/sam9l9260.h        |  213 ++++++++++++++++++++++++++++++
  10 files changed, 720 insertions(+), 9 deletions(-)

create mode 100644 board/olimex/sam9l9260/Makefile create mode 100644 board/olimex/sam9l9260/config.mk create mode 100644 board/olimex/sam9l9260/led.c create mode 100644 board/olimex/sam9l9260/nand.c create mode 100644 board/olimex/sam9l9260/partition.c create mode 100644 board/olimex/sam9l9260/sam9l9260.c create mode 100644 include/configs/sam9l9260.h

MAKEALL +1 -0
index 9ccb9ac..0e2cb36 100755
@@ -542,6 +542,7 @@ LIST_at91="		\
  	kb9202		\
  	mp2usb		\
  	m501sk		\
+	sam9l9260	\
  "
 
  #########################################################################
Makefile +12 -9
index 7c13ce8..5b0acae 100644
@@ -2487,15 +2487,6 @@ shannon_config	:	unconfig
  at91rm9200dk_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm920t at91rm9200dk atmel at91rm9200
 
-at91sam9261ek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9261ek atmel at91
-
-at91sam9263ek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
-
-at91sam9rlek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91
-
  cmc_pu2_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
 

@@ -2521,6 +2512,18 @@ at91cap9adk_config	:	unconfig
  at91sam9260ek_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9260ek atmel at91
 
+at91sam9261ek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9261ek atmel at91
+
+at91sam9263ek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
+
+at91sam9rlek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91
+
+sam9l9260_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs sam9l9260 olimex at91
+
  ########################################################################
  ## ARM Integrator boards - see doc/README-integrator for more info.
  integratorap_config	\
board/olimex/sam9l9260/Makefile new file +59 -0

59 lines not on this page · raw message

board/olimex/sam9l9260/config.mk new file +1 -0
new file mode 100644
index 0000000..ff2cfd1
@@ -0,0 +1 @@
+TEXT_BASE = 0x23f00000
board/olimex/sam9l9260/led.c new file +64 -0

64 lines not on this page · raw message

board/olimex/sam9l9260/nand.c new file +78 -0

78 lines not on this page · raw message

board/olimex/sam9l9260/partition.c new file +39 -0
new file mode 100644
index 0000000..b29c29a
@@ -0,0 +1,39 @@
+/*
+ * (C) Copyright 2008
+ * Ulf Samuelsson <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+#include <common.h>
+#include <config.h>
+#include <asm/hardware.h>
+#include <dataflash.h>
+
+AT91S_DATAFLASH_INFO dataflash_info[CFG_MAX_DATAFLASH_BANKS];
+
+struct dataflash_addr cs[CFG_MAX_DATAFLASH_BANKS] = {
+	{CFG_DATAFLASH_LOGIC_ADDR_CS0, 0},	/* Logical adress, CS */
+	{CFG_DATAFLASH_LOGIC_ADDR_CS1, 1}
+};
+
+/*define the area offsets*/
+dataflash_protect_t area_list[NB_DATAFLASH_AREA] = {
+	{0x00000000, 0x000041FF, FLAG_PROTECT_SET,   0, "Bootstrap"},
+	{0x00004200, 0x000083FF, FLAG_PROTECT_CLEAR, 0, "Environment"},
+	{0x00008400, 0x00041FFF, FLAG_PROTECT_SET,   0, "U-Boot"},
+	{0x00042000, 0x0020FFFF, FLAG_PROTECT_CLEAR, 0,	"Kernel"},
+};
board/olimex/sam9l9260/sam9l9260.c new file +251 -0

251 lines not on this page · raw message

drivers/mtd/nand/nand_ids.c +2 -0
index 2ff75c9..ec2ac55 100644
@@ -69,6 +69,8 @@ struct nand_flash_dev nand_flash_ids[] = {
 
  	{"NAND 256MiB 3,3V 8-bit",	0x71, 512, 256, 0x4000, 0},
 
+	{"NAND 512MiB 3,3V 8-bit",      0xDC, 512, 512, 0x4000, 0},
+
  	/*
  	 * These are the new chips with large page size. The pagesize and the
  	 * erasesize is determined from the extended id bytes
include/configs/sam9l9260.h new file +213 -0

213 lines not on this page · raw message

Signature · 4 lines
1.5.5.1

Best regards,
Cristian Birsan
author
#7 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

In reply to Wolfgang Denk

Dear all,

In the previous patch i removed the code from the section below.

Quoted 16 lines

board/olimex/sam9l9260/sam9l9260.c line 252

Quoted 10 lines
board/olimex/sam9l9260/sam9l9260.c new file +10 -0
+#ifdef CONFIG_RESET_PHY_R
+void reset_phy(void)
+{
+#ifdef CONFIG_MACB
+    /*
+     * Initialize ethernet HW addr prior to starting Linux,
+     * needed for nfsroot
+     */
+    eth_init(gd->bd);
+#endif

Please do NOT do this. It's a violation of the U-Boot design principles, which clearly say that only such periphereals that are actually being used by U-Boot shall be initialized, and even if they are being used, these shall be deactivated after use.

Quoted 4 lines

Carelessly leaving ports or devices in an initialized stated has been the source for problems too many times before.

Don't do that.

The u-boot works but when I try to use nfs as root filesystem i encounter the following issue:

.............
MACB_mii_bus: probed
eth0: Atmel MACB at 0xfffc4000 irq 21 (00:00:00:00:00:00)
eth0: attached PHY driver [KS8721BL] (mii_bus:phy_addr=ffffffff:01, irq=-1)
.............

From previous messages i understand that the MAC is set to 00:00:00:00:00:00 which is bad.

IP-Config: Failed to open eth0

I used again setenv ethaddr 00:04:25:12:34:56 in u-boot. After saveenv and reboot i used md command to display the EMAC 0xFFFC4000 (named MACB in the driver ) registers

U-Boot> md 0xfff4c000
fff4c000: 00000000 00000000 00000000 00000000 ................
fff4c010: 00000000 00000000 00000000 00000000 ................
fff4c020: 00000000 00000000 00000000 00000000 ................
fff4c030: 00000000 00000000 00000000 00000000 ................
fff4c040: 00000000 00000000 00000000 00000000 ................
fff4c050: 00000000 00000000 00000000 00000000 ................
fff4c060: 00000000 00000000 00000000 00000000 ................
fff4c070: 00000000 00000000 00000000 00000000 ................
fff4c080: 00000000 00000000 00000000 00000000 ................
fff4c090: 00000000 00000000 00000000 00000000 ................
fff4c0a0: 00000000 00000000 00000000 00000000 ................
fff4c0b0: 00000000 00000000 00000000 00000000 ................
fff4c0c0: 00000000 00000000 00000000 00000000 ................
fff4c0d0: 00000000 00000000 00000000 00000000 ................
fff4c0e0: 00000000 00000000 00000000 00004000 ............. at ..
fff4c0f0: 53504932 20202020 00010154 00000190 2IPS T.......

Offset 0x98 Specific Address 1 Bottom Register EMAC_SA1B Read-write
Offset 0x9C Specific Address 1 Top Register EMAC_SA1T Read-write

The register EMAC_SA1T and EMAC_SA1B coresponding to top and bottom of the MAC address are 0

Nfs works only with the ugly code that was removed.

I'm spinning in a circle :(

Please send me any suggestion.

Best regards,
Cristian Birsan

#8 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Dear Cristian Birsan,

Quoted 3 lines · In message <[email protected]> you wrote:

I used again setenv ethaddr 00:04:25:12:34:56 in u-boot. After saveenv and reboot i used md command to display the EMAC 0xFFFC4000 (named MACB in the driver ) registers

setenv affects only the U-Boot environment variables. It doe snot program any device registers for you.

And PLEASE: restrict your line length to 70 characters or less.

Quoted 3 lines

Nfs works only with the ugly code that was removed.

I'm spinning in a circle :(

Please read the previous postings, and the FAQ.

Quoted 1 line

Please send me any suggestion.

Fix your Linux driver to pick up the MAC address from some convenient place; using a kernel boot argument is one option, using the device tree is another one. The former is less effort, the latter is more, but would earn you a lot of credits :-)

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It may be that your whole purpose in life is simply  to  serve  as  a
warning to others.
author
#9 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Dear Wolfgang Denk,

Quoted 10 lines · Wolfgang Denk

setenv affects only the U-Boot environment variables. It doe snot program any device registers for you.

And PLEASE: restrict your line length to 70 characters or less.

Quoted 3 lines

Nfs works only with the ugly code that was removed.

I'm spinning in a circle :(

Please read the previous postings, and the FAQ.

I read the arm-linux mailing lists and I saw similar discussions there. Now it's clear to me that u-boot shouldn't initialize the EMAC (MACB) registers with the MAC address. In the newer kernel releases ( 2.6.26 or newer ) there is a fix for the MACB driver and it can be used for boards that do not store their MAC address in a nonvolatile memory like an EEPROM.

Thank you for your time and quick response to questions.

Please consider the u-boot patch from the previous post for the next merge window.

Best regards,

Cristian Birsan

author
#10 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Dear Wolfgang Denk,

I have submitted a few weeks ago a patch for Olimex SAM9-L9260 (similar to AT91SAM9260-EK board from Atmel).

Is is possible to include that patch in the new version of u-boot ?

If it's needed I can resend a new patch for the u-boot v2008.10

Please let me know what should I do next.

Best regards,

Cristian

#11 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Quoted 9 lines · Cristian Birsan

Dear Wolfgang Denk,

I have submitted a few weeks ago a patch for Olimex SAM9-L9260 (similar to AT91SAM9260-EK board from Atmel).

Is is possible to include that patch in the new version of u-boot ?

If it's needed I can resend a new patch for the u-boot v2008.10

Please let me know what should I do next.

please do

Best Regards,
J.

#12 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

In reply to Cristian Birsan
Quoted 64 lines · Cristian Birsan

Added support for the Olimex SAM9-L9260 development board. This patch is based on u-boot v1.3.4.

Tested with data flash only (not with NAND).

Signed-off-by Cristian Birsan <[email protected]>
---
  MAKEALL                            |    1 +
  Makefile                           |   21 ++--
  board/olimex/sam9l9260/Makefile    |   59 ++++++++
  board/olimex/sam9l9260/config.mk   |    1 +
  board/olimex/sam9l9260/led.c       |   64 +++++++++
  board/olimex/sam9l9260/nand.c      |   78 +++++++++++
  board/olimex/sam9l9260/partition.c |   39 ++++++
  board/olimex/sam9l9260/sam9l9260.c |  264 ++++++++++++++++++++++++++++++++++++
  drivers/mtd/nand/nand_ids.c        |    2 +
  include/configs/sam9l9260.h        |  212 +++++++++++++++++++++++++++++
  10 files changed, 732 insertions(+), 9 deletions(-)

create mode 100644 board/olimex/sam9l9260/Makefile create mode 100644 board/olimex/sam9l9260/config.mk create mode 100644 board/olimex/sam9l9260/led.c create mode 100644 board/olimex/sam9l9260/nand.c create mode 100644 board/olimex/sam9l9260/partition.c create mode 100644 board/olimex/sam9l9260/sam9l9260.c create mode 100644 include/configs/sam9l9260.h

MAKEALL +1 -0
index 9ccb9ac..0e2cb36 100755
@@ -542,6 +542,7 @@ LIST_at91="		\
  	kb9202		\
  	mp2usb		\
  	m501sk		\
+	sam9l9260	\
  "
 
  #########################################################################
Makefile +2 -9
index 7c13ce8..5b0acae 100644
@@ -2487,15 +2487,6 @@ shannon_config	:	unconfig
  at91rm9200dk_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm920t at91rm9200dk atmel at91rm9200
 
-at91sam9261ek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9261ek atmel at91
-
-at91sam9263ek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
-
-at91sam9rlek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91
-
  cmc_pu2_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
 

@@ -2521,6 +2512,18 @@ at91cap9adk_config	:	unconfig
  at91sam9260ek_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9260ek atmel at91
 
+at91sam9261ek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9261ek atmel at91

Makefile at91cap9adk_config : unconfig · line 2526

Quoted 10 lines
Makefile +10 -0
+
+at91sam9263ek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
+
+at91sam9rlek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91
+
+sam9l9260_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs sam9l9260 olimex at91
+

why do you touch other at91 config?

Quoted 104 lines
Makefile +0 -0
  ########################################################################
  ## ARM Integrator boards - see doc/README-integrator for more info.
  integratorap_config	\
board/olimex/sam9l9260/Makefile new file +59 -0
new file mode 100644
index 0000000..8853b7c
@@ -0,0 +1,59 @@
+#
+# (C) Copyright 2003-2008
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# (C) Copyright 2008
+#
+# Cristian Birsan <[email protected]> based on the work of
+# Stelian Pop <[email protected]>
+# Lead Tech Design <www.leadtechdesign.com>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).a
+
+COBJS-y	+= sam9l9260.o
+COBJS-y	+= led.o
+COBJS-y	+= partition.o
+COBJS-$(CONFIG_CMD_NAND) += nand.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS-y))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
+	$(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
+
+clean:
+	rm -f $(SOBJS) $(OBJS)
+
+distclean:	clean
+	rm -f $(LIB) core *.bak $(obj).depend
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/olimex/sam9l9260/config.mk new file +3 -0
new file mode 100644
+
+	return 0;
+}
board/olimex/sam9l9260/partition.c new file +25 -0
new file mode 100644
index 0000000..b29c29a
@@ -0,0 +1,39 @@
+/*
+ * (C) Copyright 2008
+ * Ulf Samuelsson <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+#include <common.h>
+#include <config.h>
+#include <asm/hardware.h>
+#include <dataflash.h>
+

board/olimex/sam9l9260/partition.c line 35

Quoted 10 lines
board/olimex/sam9l9260/partition.c new file +10 -0
+AT91S_DATAFLASH_INFO dataflash_info[CFG_MAX_DATAFLASH_BANKS];
+
+struct dataflash_addr cs[CFG_MAX_DATAFLASH_BANKS] = {
+	{CFG_DATAFLASH_LOGIC_ADDR_CS0, 0},	/* Logical adress, CS */
+	{CFG_DATAFLASH_LOGIC_ADDR_CS1, 1}
+};
+
+/*define the area offsets*/
+dataflash_protect_t area_list[NB_DATAFLASH_AREA] = {
+	{0x00000000, 0x000041FF, FLAG_PROTECT_SET,   0, "Bootstrap"},

                                                  ^^^

whitespace please fix

board/olimex/sam9l9260/partition.c line 37

Quoted 2 lines
board/olimex/sam9l9260/partition.c new file +2 -0
+	{0x00004200, 0x000083FF, FLAG_PROTECT_CLEAR, 0, "Environment"},
+	{0x00008400, 0x00041FFF, FLAG_PROTECT_SET,   0, "U-Boot"},

                                                  ^^^

whitespace please fix

Quoted 82 lines
board/olimex/sam9l9260/partition.c new file +2 -0
+	{0x00042000, 0x0020FFFF, FLAG_PROTECT_CLEAR, 0,	"Kernel"},
+};
board/olimex/sam9l9260/sam9l9260.c new file +69 -0
new file mode 100644
index 0000000..15578d1
@@ -0,0 +1,264 @@
+/*
+ * (C) Copyright 2007-2008
+ *
+ * Cristian Birsan <[email protected]> based on the work of
+ * Stelian Pop <[email protected]>
+ * Lead Tech Design <www.leadtechdesign.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <asm/arch/at91sam9260.h>
+#include <asm/arch/at91sam9260_matrix.h>
+#include <asm/arch/at91sam9_smc.h>
+#include <asm/arch/at91_pmc.h>
+#include <asm/arch/at91_rstc.h>
+#include <asm/arch/gpio.h>
+#include <asm/arch/io.h>
+#include <asm/arch/hardware.h>
+#if defined(CONFIG_RESET_PHY_R) && defined(CONFIG_MACB)
+
+	return 0;
+}
+
+int dram_init(void)
+{
+	gd->bd->bi_dram[0].start = PHYS_SDRAM;
+	gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
+	return 0;
+}
+
+#ifdef CONFIG_RESET_PHY_R
+void reset_phy(void)
+{
+#ifdef CONFIG_MACB
+	/*
+	 * Initialize ethernet HW addr prior to starting Linux,
+	 * needed for nfsroot
+	 */
+	eth_init(gd->bd);
+#endif
+}
+#endif
+
+int board_eth_init(bd_t *bis)
+{
+	int rc = 0;
+#ifdef CONFIG_MACB
+	/* The default address for the KS8721BL PHY is 0x01 */
+	rc = macb_eth_initialize(0, (void *)AT91_BASE_EMAC, 0x01);
+#endif
+	return rc;
+}
drivers/mtd/nand/nand_ids.c +0 -0
index 2ff75c9..ec2ac55 100644

drivers/mtd/nand/nand_ids.c struct nand_flash_dev nand_flash_ids[] = { · line 72

Quoted 4 lines
drivers/mtd/nand/nand_ids.c +1 -0
@@ -69,6 +69,8 @@ struct nand_flash_dev nand_flash_ids[] = {
 
  	{"NAND 256MiB 3,3V 8-bit",	0x71, 512, 256, 0x4000, 0},
 
+	{"NAND 512MiB 3,3V 8-bit",      0xDC, 512, 512, 0x4000, 0},

                                  ^^^

whitespace please fix

Quoted 38 lines
drivers/mtd/nand/nand_ids.c +1 -0
+
  	/*
  	 * These are the new chips with large page size. The pagesize and the
  	 * erasesize is determined from the extended id bytes
include/configs/sam9l9260.h new file +28 -0
new file mode 100644
index 0000000..90089b0
@@ -0,0 +1,212 @@
+/*
+ * (C) Copyright 2007-2008
+ *
+ * Cristian Birsan <[email protected]> based on the work of
+ * Stelian Pop <[email protected]>
+ * Lead Tech Design <www.leadtechdesign.com>
+ *
+ * Configuration settings for the SAM9-L9260 board.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+

include/configs/sam9l9260.h line 38

Quoted 10 lines
include/configs/sam9l9260.h new file +10 -0
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+/* Hostname */
+#define	CONFIG_HOSTNAME			sam9l9260
+
+/* ARM asynchronous clock */
+#define AT91_MAIN_CLOCK		198656000	/* from 18.432 MHz crystal */
+#define AT91_MASTER_CLOCK	99328000	/* peripheral = main / 2 */
+#define CFG_HZ			1000000		/* 1us resolution */

please update to CONFIG_SYS_

Note that I've plan and announce that I'll generate a common code for at91sam9260 and other to reduce duplicate code.

Best Regards,
J.

#13 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Quoted 19 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 18 lines · Cristian Birsan

Added support for the Olimex SAM9-L9260 development board. This patch is based on u-boot v1.3.4.

Tested with data flash only (not with NAND).

Signed-off-by Cristian Birsan <[email protected]>
---
  MAKEALL                            |    1 +
  Makefile                           |   21 ++--
  board/olimex/sam9l9260/Makefile    |   59 ++++++++
  board/olimex/sam9l9260/config.mk   |    1 +
  board/olimex/sam9l9260/led.c       |   64 +++++++++
  board/olimex/sam9l9260/nand.c      |   78 +++++++++++
  board/olimex/sam9l9260/partition.c |   39 ++++++
  board/olimex/sam9l9260/sam9l9260.c |  264 ++++++++++++++++++++++++++++++++++++
  drivers/mtd/nand/nand_ids.c        |    2 +
  include/configs/sam9l9260.h        |  212 +++++++++++++++++++++++++++++
  10 files changed, 732 insertions(+), 9 deletions(-)
Quoted 8 lines
Quoted 8 lines

create mode 100644 board/olimex/sam9l9260/Makefile create mode 100644 board/olimex/sam9l9260/config.mk create mode 100644 board/olimex/sam9l9260/led.c create mode 100644 board/olimex/sam9l9260/nand.c create mode 100644 board/olimex/sam9l9260/partition.c create mode 100644 board/olimex/sam9l9260/sam9l9260.c create mode 100644 include/configs/sam9l9260.h

I've forget one think please add an entry to the MAINTAINER file

Best Regards,
J.

#14 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Dear Cristian

Quoted 2 lines · In message <[email protected]> Jean-Christophe wrote:

I've forget one think please add an entry to the MAINTAINER file

This can be done by sending an additional patch - no need to resubmit all the stuff.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A committee is a life form with six or more legs and no brain.
                              -- Lazarus Long, "Time Enough For Love"
#15 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Quoted 8 lines · Wolfgang Denk

Dear Cristian

Quoted 2 lines · In message <[email protected]> Jean-Christophe wrote:

I've forget one think please add an entry to the MAINTAINER file

This can be done by sending an additional patch - no need to resubmit all the stuff.

Yes but the patch need to be rebased so If the author can do it a the time it will nice

Best Regards,
J.

author
#16 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

In reply to Jean-Christophe PLAGNIOL-VILLARD

Dear Jean-Christophe PLAGNIOL-VILLARD,

I will remove all unnecessary white spaces from the previous patch. I have now a patch version for u-boot u-boot v2008.10

Quoted 27 lines
Quoted 27 lines

"

#########################################################################

Makefile +0 -9
index 7c13ce8..5b0acae 100644
@@ -2487,15 +2487,6 @@ shannon_config	:	unconfig
  at91rm9200dk_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm920t at91rm9200dk atmel at91rm9200
 
-at91sam9261ek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9261ek atmel at91
-
-at91sam9263ek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
-
-at91sam9rlek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91
-
  cmc_pu2_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
 

@@ -2521,6 +2512,18 @@ at91cap9adk_config	:	unconfig
  at91sam9260ek_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9260ek atmel at91
Quoted 13 lines

Makefile at91cap9adk_config : unconfig · line 2526

Quoted 12 lines
Makefile +12 -0
+at91sam9261ek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9261ek atmel at91
+
+at91sam9263ek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
+
+at91sam9rlek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91
+
+sam9l9260_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs sam9l9260 olimex at91
+

why do you touch other at91 config?

I touched other configs because i tried to put correctly boards with arm920t and arm926ejs in their sections. I belive that at91sam9261ek at91sam9263ek should be placed in the arm926ejs core section. Please correct me if i'm wrong.

Quoted 12 lines

Makefile at91cap9adk_config : unconfig

Quoted 10 lines
Makefile +10 -0
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+/* Hostname */
+#define	CONFIG_HOSTNAME			sam9l9260
+
+/* ARM asynchronous clock */
+#define AT91_MAIN_CLOCK		198656000	/* from 18.432 MHz crystal */
+#define AT91_MASTER_CLOCK	99328000	/* peripheral = main / 2 */
+#define CFG_HZ			1000000		/* 1us resolution */

please update to CONFIG_SYS_

Quoted 2 lines

Note that I've plan and announce that I'll generate a common code for at91sam9260 and other to reduce duplicate code.

I can change CFG_HZ to CONFIG_SYS_HZ but that macro is used in /cpu/arm926ejs/at91/timer.c. If I change the macro from timer.c I should update all at91 configurations but I can test only on Olimex (at91sam9260) board. I do not know if it's safe to modify other configurations without appropriate testing.

Regards,
Cristian

#17 lore raw

PATCH 1/1 Olimex SAM9-L9260 board support

Quoted 46 lines · Cristian Birsan

Dear Jean-Christophe PLAGNIOL-VILLARD,

I will remove all unnecessary white spaces from the previous patch. I have now a patch version for u-boot u-boot v2008.10

Quoted 27 lines
Quoted 27 lines

"

#########################################################################

Makefile +0 -9
index 7c13ce8..5b0acae 100644
@@ -2487,15 +2487,6 @@ shannon_config	:	unconfig
  at91rm9200dk_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm920t at91rm9200dk atmel at91rm9200
 
-at91sam9261ek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9261ek atmel at91
-
-at91sam9263ek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
-
-at91sam9rlek_config	:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91
-
  cmc_pu2_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
 

@@ -2521,6 +2512,18 @@ at91cap9adk_config	:	unconfig
  at91sam9260ek_config	:	unconfig
  	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9260ek atmel at91
Quoted 13 lines

Makefile at91cap9adk_config : unconfig · line 2526

Quoted 12 lines
Makefile +12 -0
+at91sam9261ek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9261ek atmel at91
+
+at91sam9263ek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
+
+at91sam9rlek_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91
+
+sam9l9260_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs sam9l9260 olimex at91
+

why do you touch other at91 config?

Quoted 5 lines

I touched other configs because i tried to put correctly boards with arm920t and arm926ejs in their sections. I belive that at91sam9261ek at91sam9263ek should be placed in the arm926ejs core section. Please correct me if i'm wrong.

It's supposed to be done in an other patch which I've post btw

Quoted 12 lines
Quoted 11 lines

Makefile at91cap9adk_config : unconfig

Quoted 10 lines
Makefile +10 -0
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+/* Hostname */
+#define	CONFIG_HOSTNAME			sam9l9260
+
+/* ARM asynchronous clock */
+#define AT91_MAIN_CLOCK		198656000	/* from 18.432 MHz crystal */
+#define AT91_MASTER_CLOCK	99328000	/* peripheral = main / 2 */
+#define CFG_HZ			1000000		/* 1us resolution */

please update to CONFIG_SYS_

Quoted 8 lines
Quoted 2 lines

Note that I've plan and announce that I'll generate a common code for at91sam9260 and other to reduce duplicate code.

I can change CFG_HZ to CONFIG_SYS_HZ but that macro is used in /cpu/arm926ejs/at91/timer.c. If I change the macro from timer.c I should update all at91 configurations but I can test only on Olimex (at91sam9260) board. I do not know if it's safe to modify other configurations without appropriate testing.

I've merge it at the same time of all CFG_

Best Regards,
J.