Skip to contentSkip to conversation

tracing: fix a build error on alpha

PATCH RESEND Applied Frederic Weisbecker 3 participants 5 messages Oct 28, 2008 – Nov 13, 2008 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 tracing: fix a build error on alpha

When tracing is enabled, some arch have included <linux/irqflags.h> on their <asm/system.h> but others like alpha or m68k don't.

Build error on alpha:

kernel/trace/trace.c: In function 'tracing_cpumask_write':
kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable' kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable'

Tested on Alpha through a cross-compiler (should correct a similar issue on m68k).

---

kernel/trace/trace.c +1 -0
index 306e433..c09493e 100644
@@ -34,6 +34,7 @@
 
 #include <linux/stacktrace.h>
 #include <linux/ring_buffer.h>
+#include <linux/irqflags.h>
 
 #include "trace.h"
 
Applied
#1 lore raw
Quoted 5 lines · Frederic Weisbecker

When tracing is enabled, some arch have included <linux/irqflags.h> on their <asm/system.h> but others like alpha or m68k don't.

Build error on alpha:

Quoted 8 lines

kernel/trace/trace.c: In function 'tracing_cpumask_write':
kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable' kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable'

Tested on Alpha through a cross-compiler (should correct a similar issue on m68k).

applied to tip/tracing/urgent, thanks Frederic!

Ingo

#3 lore raw
Quoted 5 lines · Alexey Dobriyan
Quoted 1 line · Frederic Weisbecker

+#include <linux/irqflags.h>

Already fixed.

Note that it's already fixed because the patch you are replying to (and which was sent 16 days ago) is already upstream:

21798a8: tracing: fix a build error on alpha

Ingo