tracing: fix a build error on alpha
PATCH RESEND 1/1 tracing: fix a build error on alpha
When tracing is enabled, some arch have included <linux/irqflags.h> on their <asm/system.h> but others like alpha or m68k don't.
Build error on alpha:
kernel/trace/trace.c: In function 'tracing_cpumask_write':kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable' kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable'
Tested on Alpha through a cross-compiler (should correct a similar issue on m68k).
---
kernel/trace/trace.c +1 -0
@@ -34,6 +34,7 @@#include <linux/stacktrace.h> #include <linux/ring_buffer.h> +#include <linux/irqflags.h> #include "trace.h"
Ingo Molnar
AppliedQuoted 5 lines · Frederic Weisbecker
When tracing is enabled, some arch have included <
linux/irqflags.h> on their <asm/system.h> but others like alpha or m68k don't.Build error on alpha:
Quoted 8 lines
kernel/trace/trace.c: In function 'tracing_cpumask_write':kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable'kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable'Tested on Alpha through a cross-compiler (should correct a similar issue on m68k).
Reported-by Alexey Dobriyan <[email protected]>Signed-off-by Frederic Weisbecker <[email protected]>
applied to tip/tracing/urgent, thanks Frederic!
Ingo
Quoted 1 line · Frederic Weisbecker
+#include <
linux/irqflags.h>
Already fixed.
Quoted 5 lines · Alexey Dobriyan
Quoted 1 line · Frederic Weisbecker
+#include <
linux/irqflags.h>Already fixed.
Note that it's already fixed because the patch you are replying to (and which was sent 16 days ago) is already upstream:
21798a8: tracing: fix a build error on alpha
Ingo
2008/11/13 Alexey Dobriyan <[email protected]>:
Quoted 6 lines
Quoted 1 line · Frederic Weisbecker
+#include <
linux/irqflags.h>Already fixed.
And you were even put on Reported-by tag...