Skip to contentSkip to conversation

twl4030 irq assignments

PATCH In review David Brownell 2 participants 2 messages Nov 20, 2008 – Nov 25, 2008

lore
Share & tools
lore
#0 lore raw

cover twl4030 irq assignments

The following patches remove some needless dependencies from TWL4030 support, supporting non-OMAP builds and in some cases, non-SDP (etc) builds.

- keypad driver ... use platform_get_irq(), no board dependencies
- BCI driver ... likewise
- MADC driver ... use platform_get_irq()
- power button ... still pretty hacky, there's no device here
- removes the now-dead symbols, and OMAP-dependency

Build-tested.

With this, I think the keypad driver becomes ready to go upstream, after related twl4030-core updates. At least, it's ready for review. (Including: Why pass the keypad module id to kpread/kpwrite, it's the only one ever used? Why does Kconfig mention GPIOs, since they aren't used?)

The point of these patches is that last one, which lets non-OMAP folk do test builds and easily make updates when APIs change. Yeah, it's a strange notion, but not everyone does OMAP builds. ;)

- Dave

#1 lore raw
Quoted 18 lines · David Brownell

The following patches remove some needless dependencies from TWL4030 support, supporting non-OMAP builds and in some cases, non-SDP (etc) builds.

- keypad driver ... use platform_get_irq(), no board dependencies
- BCI driver ... likewise
- MADC driver ... use platform_get_irq()
- power button ... still pretty hacky, there's no device here
- removes the now-dead symbols, and OMAP-dependency

Build-tested.

With this, I think the keypad driver becomes ready to go upstream, after related twl4030-core updates. At least, it's ready for review. (Including: Why pass the keypad module id to kpread/kpwrite, it's the only one ever used? Why does Kconfig mention GPIOs, since they aren't used?)

Quoted 3 lines

The point of these patches is that last one, which lets non-OMAP folk do test builds and easily make updates when APIs change. Yeah, it's a strange notion, but not everyone does OMAP builds. ;)

Pushing these to l-o tree today.

Tony