Skip to content

twl4030 irq assignments

David Brownell linux-omap 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5twl4030 keypad irq & dependenciesarch/arm/mach-omap2/board-2430sdp.c arch/arm/mach-omap2/board-3430sdp.c arch/arm/mach-omap2/board-ldp.c +5 more+3 -90 replies
2/5twl4030 BCI irq and dependenciesdrivers/power/Kconfig drivers/power/twl4030_bci_battery.c include/linux/i2c/twl4030.h+13 -100 replies
3/5twl4030 MADC irqdrivers/i2c/chips/twl4030-madc.c include/linux/i2c/twl4030.h+3 -30 replies
4/5twl4030 power button irqdrivers/i2c/chips/twl4030-pwrbutton.c include/linux/i2c/twl4030.h+15 -372 replies
5/5twl4030 cleanup symbols and OMAP dependencydrivers/mfd/Kconfig include/linux/i2c/twl4030.h+1 -331 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 2.6.28-rc5 0/5] twl4030 irq assignments

The following patches remove some needless dependencies from TWL4030 support, supporting non-OMAP builds and in some cases, non-SDP (etc) builds.

- keypad driver ... use platform_get_irq(), no board dependencies
- BCI driver ... likewise
- MADC driver ... use platform_get_irq()
- power button ... still pretty hacky, there's no device here
- removes the now-dead symbols, and OMAP-dependency

Build-tested.

With this, I think the keypad driver becomes ready to go upstream, after related twl4030-core updates. At least, it's ready for review. (Including: Why pass the keypad module id to kpread/kpwrite, it's the only one ever used? Why does Kconfig mention GPIOs, since they aren't used?)

The point of these patches is that last one, which lets non-OMAP folk do test builds and easily make updates when APIs change. Yeah, it's a strange notion, but not everyone does OMAP builds. ;)

- Dave