Skip to contentSkip to conversation

ath9k: Free Beacon skbs in AP mode

PATCH New Jouni Malinen 2 participants 2 messages Dec 5, 2008 – Dec 6, 2008 Networking drivers (wireless)

lore
Share & tools
lore

Jouni Malinen

author
#0 lore raw

PATCH 1/1 ath9k: Free Beacon skbs in AP mode

Fix a memory leak where AP mode did not free transmitted Beacon frame skbs.

Signed-off-by Jouni Malinen <[email protected]>
drivers/net/wireless/ath9k/beacon.c +1 -0
Index: wireless-testing/drivers/net/wireless/ath9k/beacon.c
===================================================================
@@ -167,6 +167,7 @@
 		pci_unmap_single(sc->pdev, bf->bf_dmacontext,
 				 skb->len,
 				 PCI_DMA_TODEVICE);
+		dev_kfree_skb_any(skb);
 	}
 
 	skb = ieee80211_beacon_get(sc->hw, vif);
Signature · 1 line
Jouni Malinen                                            PGP id EFC895FA
#1 lore raw

PATCH 1/1 ath9k: Free Beacon skbs in AP mode

Quoted 11 lines · Jouni Malinen

Fix a memory leak where AP mode did not free transmitted Beacon frame skbs.

Signed-off-by Jouni Malinen <[email protected]>

Index: wireless-testing/drivers/net/wireless/ath9k/beacon.c
===================================================================

drivers/net/wireless/ath9k/beacon.c line 173

Quoted 7 lines
drivers/net/wireless/ath9k/beacon.c +1 -0
@@ -167,6 +167,7 @@
 		pci_unmap_single(sc->pdev, bf->bf_dmacontext,
 				 skb->len,
 				 PCI_DMA_TODEVICE);
+		dev_kfree_skb_any(skb);
 	}
 
 	skb = ieee80211_beacon_get(sc->hw, vif);
Acked-by Pat Erley <[email protected]>

I've been using ath9k in master mode for a few weeks and
had noticed a severe memory leak (kill a gig of ram system in about a day). Figured it was just in hostapd, and haven't had time to track it down.