x86 gart: don't complain if no AMD GART found
PATCH 1/1 x86 gart: don't complain if no AMD GART found
It's perfectly normal for no AMD GART to be present, e.g., if you have Intel CPUs. None of the other iommu_init() functions makes noise when it finds nothing.
--- arch/x86/kernel/pci-gart_64.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
arch/x86/kernel/pci-gart_64.c +1 -3
@@ -745,10 +745,8 @@ void __init gart_iommu_init(void)unsigned long scratch;long i; -if (cache_k8_northbridges () <0 || num_k8_northbridges ==0 ) { -printk (KERN_INFO "PCI-GART: No AMD GART found.\n" ); +if (cache_k8_northbridges () <0 || num_k8_northbridges ==0 )return ; - }#ifndef CONFIG_AGP_AMD64 no_agp =1 ;
Quoted 3 lines · Bjorn Helgaas
It's perfectly normal for no AMD GART to be present, e.g., if you have Intel CPUs. None of the other
iommu_init()functions makes noise when it finds nothing.
True, there are even 64bit AMD processors without GART.
Ingo,
do you want to pick this patch up or should I do it?
Quoted 1 line
Signed-off-by Bjorn Helgaas <[email protected]>
Quoted 22 lines
--- arch/x86/kernel/pci-gart_64.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)arch/x86/kernel/pci-gart_64.c +1
-3@@ -745,10 +745,8 @@ void __init gart_iommu_init(void)unsigned long scratch;long i; -if (cache_k8_northbridges () <0 || num_k8_northbridges ==0 ) { -printk (KERN_INFO "PCI-GART: No AMD GART found.\n" ); +if (cache_k8_northbridges () <0 || num_k8_northbridges ==0 )return ; - }#ifndef CONFIG_AGP_AMD64 no_agp =1 ;
Signature · 6 lines
| AMD Saxony Limited Liability Company & Co. KG
Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
System | Register Court Dresden: HRA 4896
Research | General Partner authorized to represent:
Center | AMD Saxony LLC (Wilmington, Delaware, US)
| General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoyIngo Molnar
AppliedQuoted 7 lines · Joerg Roedel
Quoted 3 lines · Bjorn Helgaas
It's perfectly normal for no AMD GART to be present, e.g., if you have Intel CPUs. None of the other
iommu_init()functions makes noise when it finds nothing.True, there are even 64bit AMD processors without GART.
Quoted 7 lines
Ingo,
do you want to pick this patch up or should I do it?
Quoted 1 line
Signed-off-by Bjorn Helgaas <[email protected]>Acked-by Joerg Roedel <[email protected]>
I have applied it to tip/x86/urgent, thanks guys!
Ingo
Quoted 2 lines · Bjorn Helgaas
It's perfectly normal for no AMD GART to be present, e.g., if you have Intel CPUs.
Yes! That's annoyed me for some time too.
Quoted 2 lines
None of the other
iommu_init()functions makes noise when
it finds nothing.
The Calgary stuff is pretty noisy in the face of non-existant hardware too. Makes for noisy distro kernels..
Calgary: detecting Calgary via BIOS EBDA area
Calgary: Unable to locate Rio Grande table in EBDA - bailing!
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 6 lines · Dave Jones
Quoted 2 lines · Bjorn Helgaas
It's perfectly normal for no AMD GART to be present, e.g., if you have Intel CPUs.
Yes! That's annoyed me for some time too.
Quoted 8 lines
Quoted 2 lines
None of the other
iommu_init()functions makes noise when
it finds nothing.The Calgary stuff is pretty noisy in the face of non-existant hardware too. Makes for noisy distro kernels..
Calgary: detecting Calgary via BIOS EBDA area
Calgary: Unable to locate Rio Grande table in EBDA - bailing!
Yeah, I considered removing that, too. At least the Calgary stuff is KERN_DEBUG, so it's not quite as visible. But I'm in favor of removing it anyway.
Bjorn
Quoted 5 lines · Dave Jones
The Calgary stuff is pretty noisy in the face of non-existant hardware too. Makes for noisy distro kernels..
Calgary: detecting Calgary via BIOS EBDA area
Calgary: Unable to locate Rio Grande table in EBDA - bailing!
Feel free to nuke it.
Cheers,
Muli
Signature · 3 lines
SYSTOR 2009---The Israeli Experimental Systems Conference May 4-6, 2009, Haifa, Israel http://www.haifa.il.ibm.com/conferences/systor2009/