Skip to contentSkip to conversation

x86 gart: don't complain if no AMD GART found

PATCH Applied Bjorn Helgaas 5 participants 6 messages Dec 17, 2008 – Dec 19, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86 gart: don't complain if no AMD GART found

It's perfectly normal for no AMD GART to be present, e.g., if you have Intel CPUs. None of the other iommu_init() functions makes noise when it finds nothing.

---
 arch/x86/kernel/pci-gart_64.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
arch/x86/kernel/pci-gart_64.c +1 -3
index ba7ad83..a35eaa3 100644
@@ -745,10 +745,8 @@ void __init gart_iommu_init(void)
 	unsigned long scratch;
 	long i;
 
-	if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0) {
-		printk(KERN_INFO "PCI-GART: No AMD GART found.\n");
+	if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0)
 		return;
-	}
 
 #ifndef CONFIG_AGP_AMD64
 	no_agp = 1;
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Bjorn Helgaas

It's perfectly normal for no AMD GART to be present, e.g., if you have Intel CPUs. None of the other iommu_init() functions makes noise when it finds nothing.

True, there are even 64bit AMD processors without GART.

Ingo,

do you want to pick this patch up or should I do it?

Quoted 1 line
Quoted 22 lines
---
 arch/x86/kernel/pci-gart_64.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
arch/x86/kernel/pci-gart_64.c +1 -3
index ba7ad83..a35eaa3 100644
@@ -745,10 +745,8 @@ void __init gart_iommu_init(void)
 	unsigned long scratch;
 	long i;
 
-	if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0) {
-		printk(KERN_INFO "PCI-GART: No AMD GART found.\n");
+	if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0)
 		return;
-	}
 
 #ifndef CONFIG_AGP_AMD64
 	no_agp = 1;
Signature · 6 lines
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
Applied
#2 lore raw
Quoted 7 lines · Joerg Roedel
Quoted 3 lines · Bjorn Helgaas

It's perfectly normal for no AMD GART to be present, e.g., if you have Intel CPUs. None of the other iommu_init() functions makes noise when it finds nothing.

True, there are even 64bit AMD processors without GART.

Quoted 7 lines

Ingo,

do you want to pick this patch up or should I do it?

Quoted 1 line

I have applied it to tip/x86/urgent, thanks guys!

Ingo

#3 lore raw
In reply to Bjorn Helgaas
Quoted 2 lines · Bjorn Helgaas

It's perfectly normal for no AMD GART to be present, e.g., if you have Intel CPUs.

Yes! That's annoyed me for some time too.

Quoted 2 lines

None of the other iommu_init() functions makes noise when
it finds nothing.

The Calgary stuff is pretty noisy in the face of non-existant hardware too. Makes for noisy distro kernels..

Calgary: detecting Calgary via BIOS EBDA area
Calgary: Unable to locate Rio Grande table in EBDA - bailing!

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#4 lore raw
Quoted 6 lines · Dave Jones
Quoted 2 lines · Bjorn Helgaas

It's perfectly normal for no AMD GART to be present, e.g., if you have Intel CPUs.

Yes! That's annoyed me for some time too.

Quoted 8 lines
Quoted 2 lines

None of the other iommu_init() functions makes noise when
it finds nothing.

The Calgary stuff is pretty noisy in the face of non-existant hardware too. Makes for noisy distro kernels..

Calgary: detecting Calgary via BIOS EBDA area
Calgary: Unable to locate Rio Grande table in EBDA - bailing!

Yeah, I considered removing that, too. At least the Calgary stuff is KERN_DEBUG, so it's not quite as visible. But I'm in favor of removing it anyway.

Bjorn

#5 lore raw
In reply to Dave Jones
Quoted 5 lines · Dave Jones

The Calgary stuff is pretty noisy in the face of non-existant hardware too. Makes for noisy distro kernels..

Calgary: detecting Calgary via BIOS EBDA area
Calgary: Unable to locate Rio Grande table in EBDA - bailing!

Feel free to nuke it.

Cheers,
Muli

Signature · 3 lines
SYSTOR 2009---The Israeli Experimental Systems Conference
May 4-6, 2009, Haifa, Israel
http://www.haifa.il.ibm.com/conferences/systor2009/