2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH
Subsystems (3)
PATCH 1/1 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH
In-Reply-To: <[email protected]>
Review
Quoted 7 lines · Kamalesh Babulal
config
SCSI_IBMVSCSI
tristate "IBM Virtual SCSI support"(quoted diff) +1
-1- depends on PPC_PSERIES || PPC_ISERIES + depends on (PPC_PSERIES || PPC_ISERIES) && VIOPATH select SCSI_SRP_ATTRS help This is the IBM POWER Virtual SCSI Client
As VIOPATH is iSeries code and is only used by the iSeries code, the requirment should be
depends on PPC_PSERIES || (PPC_ISERIES && VIOPATH)
except VIOPATH isn't selectable:
arch/powerpc/platforms/iseries/Kconfig:
config VIOPATH
bool
depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
default yso instead we should be adding
select VIOPATH if PPC_ISERIES
to SCSI_IBMVSCSI and just
select VIOPATH
to HVC_ISERIES as it depends on PPC_ISERIES
otherwise you have to enable one driver to get these other drivers.
milton
Hi Milton,
Quoted 19 lines · On Sun, 4 Jan 2009 02:54:15 -0600 Milton Miller <[email protected]> wrote:
As VIOPATH is iSeries code and is only used by the iSeries code, the requirment should be
depends on
PPC_PSERIES|| (PPC_ISERIES&& VIOPATH)except VIOPATH isn't selectable:
arch/powerpc/platforms/iseries/Kconfig:config VIOPATH bool depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH default yso instead we should be adding
select VIOPATH if
PPC_ISERIES
Quoted 7 lines
to
SCSI_IBMVSCSIand justselect VIOPATH
to
HVC_ISERIESas it depends onPPC_ISERIESotherwise you have to enable one driver to get these other drivers.
You are completely correct. We didn't have "select" when those drivers
were added (at least I was not aware of it) so they should all be changed
to select VIOPATH and the dependency in VIOPATH should be dropped. This sort of thing is exactly what select is for.
Signature · 3 lines
Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Quoted 31 lines · Milton Miller
In-Reply-To: <[email protected]>
Review
Quoted 7 lines · Kamalesh Babulal
config
SCSI_IBMVSCSI
tristate "IBM Virtual SCSI support"(quoted diff) +1
-1- depends on PPC_PSERIES || PPC_ISERIES + depends on (PPC_PSERIES || PPC_ISERIES) && VIOPATH select SCSI_SRP_ATTRS help This is the IBM POWER Virtual SCSI ClientAs VIOPATH is iSeries code and is only used by the iSeries code, the requirment should be
depends on
PPC_PSERIES|| (PPC_ISERIES&& VIOPATH)except VIOPATH isn't selectable:
arch/powerpc/platforms/iseries/Kconfig:config VIOPATH
bool depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH default yso instead we should be adding
select VIOPATH if
PPC_ISERIESto
SCSI_IBMVSCSIand just
Quoted 8 lines
select VIOPATH
to
HVC_ISERIESas it depends onPPC_ISERIESotherwise you have to enable one driver to get these other drivers.
milton
Hi Milton,
Thanks for the review comments, I am resending the patch with the
changes you have recommended.
--
drivers/char/Kconfig | 1 + drivers/scsi/Kconfig | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
drivers/char/Kconfig +1 -0
@@ -616,6 +616,7 @@ config HVC_ISERIES default y select HVC_DRIVER select HVC_IRQ + select VIOPATH help iSeries machines support a hypervisor virtual console.
drivers/scsi/Kconfig +1 -0
@@ -884,6 +884,7 @@ config SCSI_IBMVSCSI tristate "IBM Virtual SCSI support" depends on PPC_PSERIES || PPC_ISERIES select SCSI_SRP_ATTRS + select VIOPATH if PPC_ISERIES help This is the IBM POWER Virtual SCSI Client
Signature · 4 lines
Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL.
Quoted 6 lines · Kamalesh Babulal
Hi Milton,
Thanks for the review comments, I am resending the patch with the
changes you have recommended.Signed-off-by Kamalesh Babulal <[email protected]>
Better, but you didn't include the change log, nor did you respond to Stephen's reply suggesting that all users be converted to select viopath (versus the proposed 2 select and 5 get it via depends and default y).
milton
Quoted 7 lines · Milton Miller
Quoted 5 lines · Kamalesh Babulal
Hi Milton,
Thanks for the review comments, I am resending the patch with the
changes you have recommended.
Quoted 8 lines
Quoted 1 line
Signed-off-by Kamalesh Babulal <[email protected]>Better, but you didn't include the change log, nor did you respond to Stephen's reply suggesting that all users be converted to select viopath (versus the proposed 2 select and 5 get it via depends and default y).
milton
Hi Milton/Stephen,
Sorry for resending the patch before taking care of the response. Resending
the patch with changes made to other three drivers also.
Impact: Fix the VIOPATH dependency in the iSeries dependent drivers.
iSeries depend drivers build fails, when CONFIG_VIOPATH is disabled. Removing the dependency of VIOPATH by selecting it, when the drivers dependent on iSeries code.
--- arch/powerpc/platforms/iseries/Kconfig | 5 ++++- drivers/char/Kconfig | 1 + drivers/scsi/Kconfig | 1 + 3 files changed, 6 insertions(+), 1 deletions(-)
arch/powerpc/platforms/iseries/Kconfig +4 -1
@@ -10,18 +10,21 @@ menu "iSeries device drivers" config VIODASD tristate "iSeries Virtual I/O disk support" depends on BLOCK + select VIOPATH help If you are running on an iSeries system and you want to use virtual disks created and managed by OS/400, say Y. config VIOCD tristate "iSeries Virtual I/O CD support" + select VIOPATH help If you are running Linux on an IBM iSeries system and you want to read a CD drive owned by OS/400, say Y here. config VIOTAPE tristate "iSeries Virtual Tape Support" + select VIOPATH help If you are running Linux on an iSeries system and you want Linux to read and/or write a tape drive owned by OS/400, say Y here.
@@ -30,5 +33,5 @@ endmenu config VIOPATH bool - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH + depends on PPC_ISERIES default y
drivers/char/Kconfig +1 -0
@@ -616,6 +616,7 @@ config HVC_ISERIES default y select HVC_DRIVER select HVC_IRQ + select VIOPATH help iSeries machines support a hypervisor virtual console.
drivers/scsi/Kconfig +1 -0
@@ -884,6 +884,7 @@ config SCSI_IBMVSCSI tristate "IBM Virtual SCSI support" depends on PPC_PSERIES || PPC_ISERIES select SCSI_SRP_ATTRS + select VIOPATH if PPC_ISERIES help This is the IBM POWER Virtual SCSI Client
Signature · 4 lines
Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL.
Quoted 45 lines
Sorry for resending the patch before taking care of the response. Resending
the patch with changes made to other three drivers also.Impact: Fix the VIOPATH dependency in the iSeries dependent drivers.
iSeries depend drivers build fails, when
CONFIG_VIOPATHis disabled. Removing the dependency of VIOPATH by selecting it, when the drivers dependent on iSeries code.Signed-off-by Kamalesh Babulal <[email protected]>--- arch/powerpc/platforms/iseries/Kconfig | 5 ++++- drivers/char/Kconfig | 1 + drivers/scsi/Kconfig | 1 + 3 files changed, 6 insertions(+), 1 deletions(-)arch/powerpc/platforms/iseries/Kconfig +3
-0@@ -10,18 +10,21 @@ menu "iSeries device drivers" config VIODASD tristate "iSeries Virtual I/O disk support" depends on BLOCK + select VIOPATH help If you are running on an iSeries system and you want to use virtual disks created and managed by OS/400, say Y. config VIOCD tristate "iSeries Virtual I/O CD support" + select VIOPATH help If you are running Linux on an IBM iSeries system and you want to read a CD drive owned by OS/400, say Y here. config VIOTAPE tristate "iSeries Virtual Tape Support" + select VIOPATH help If you are running Linux on an iSeries system and you want Linux to read and/or write a tape drive owned by OS/400, say Y here.
arch/powerpc/platforms/iseries/Kconfig endmenu · line 37
Quoted 6 lines
arch/powerpc/platforms/iseries/Kconfig +1
-1@@ -30,5 +33,5 @@ endmenu config VIOPATH bool - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH + depends on PPC_ISERIES default y
VIOPATH is set using select so the "depends on" is effectively ignored. If you think you need the "depends on" then you need to revisit the symbol that will select VIOPATH and make sure _they_ have this dependency.
Sam
Quoted 24 lines · Sam Ravnborg
Quoted 24 lines
Sorry for resending the patch before taking care of the response. Resending
the patch with changes made to other three drivers also.Impact: Fix the VIOPATH dependency in the iSeries dependent drivers.
iSeries depend drivers build fails, when
CONFIG_VIOPATHis disabled. Removing the dependency of VIOPATH by selecting it, when the drivers dependent on iSeries code.Signed-off-by Kamalesh Babulal <[email protected]>--- arch/powerpc/platforms/iseries/Kconfig | 5 ++++- drivers/char/Kconfig | 1 + drivers/scsi/Kconfig | 1 + 3 files changed, 6 insertions(+), 1 deletions(-)arch/powerpc/platforms/iseries/Kconfig +0
-0@@ -10,18 +10,21 @@ menu "iSeries device drivers" config VIODASD
<snip>
Quoted 6 lines
VIOPATH is set using select so the "depends on" is effectively ignored. If you think you need the "depends on" then you need to revisit the symbol that will select VIOPATH and make sure _they_ have this dependency.
Sam
Hi Sam,
VIOPATH is used only by the PPC_ISERIES code. The symbols selecting
the VIOPATH are also dependent on the PPC_ISERIES. Should we make the config VIOPATH as default n, because it being selected the dependent drivers.
Impact: Fix the VIOPATH dependency in the iSeries dependent drivers.
iSeries depend drivers build fails, when CONFIG_VIOPATH is disabled. Removing the dependency of VIOPATH by selecting it, when the drivers dependent on iSeries code.
--- arch/powerpc/platforms/iseries/Kconfig | 6 ++++-- drivers/char/Kconfig | 1 + drivers/scsi/Kconfig | 1 + 3 files changed, 6 insertions(+), 2 deletions(-)
arch/powerpc/platforms/iseries/Kconfig +4 -2
@@ -10,18 +10,21 @@ menu "iSeries device drivers" config VIODASD tristate "iSeries Virtual I/O disk support" depends on BLOCK + select VIOPATH help If you are running on an iSeries system and you want to use virtual disks created and managed by OS/400, say Y. config VIOCD tristate "iSeries Virtual I/O CD support" + select VIOPATH help If you are running Linux on an IBM iSeries system and you want to read a CD drive owned by OS/400, say Y here. config VIOTAPE tristate "iSeries Virtual Tape Support" + select VIOPATH help If you are running Linux on an iSeries system and you want Linux to read and/or write a tape drive owned by OS/400, say Y here.
@@ -30,5 +33,4 @@ endmenu config VIOPATH bool - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH - default y + default n
drivers/char/Kconfig +1 -0
@@ -616,6 +616,7 @@ config HVC_ISERIES default y select HVC_DRIVER select HVC_IRQ + select VIOPATH help iSeries machines support a hypervisor virtual console.
drivers/scsi/Kconfig +1 -0
@@ -884,6 +884,7 @@ config SCSI_IBMVSCSI tristate "IBM Virtual SCSI support" depends on PPC_PSERIES || PPC_ISERIES select SCSI_SRP_ATTRS + select VIOPATH if PPC_ISERIES help This is the IBM POWER Virtual SCSI Client
Signature · 4 lines
Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL.
Hi Kamalesh
Looks good, small nit below.
arch/powerpc/platforms/iseries/Kconfig endmenu · line 36
Quoted 5 lines
config VIOPATH
arch/powerpc/platforms/iseries/Kconfig +1
-2bool - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH - default y + default n
As 'n' is default anyway this line is not needed and I suggest you spin a final version of the patch with this removed.
Sam
Quoted 13 lines · Sam Ravnborg
Hi Kamalesh
Looks good, small nit below.
Review
Quoted 5 lines
config VIOPATH
(quoted diff) +1
-2bool - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH - default y + default nAs 'n' is default anyway this line is not needed and I suggest you spin a final version of the patch with this removed.
Quoted 1 line
Sam
Hi Sam,
Thanks for the review comments. I am resending the patch with the changes
you have recommended.
Impact: Fix the VIOPATH dependency in the iSeries dependent drivers.
iSeries depend drivers build fails, when CONFIG_VIOPATH is disabled. Removing the dependency of VIOPATH by selecting it, when the drivers dependent on iSeries code.
--- arch/powerpc/platforms/iseries/Kconfig | 5 +++-- drivers/char/Kconfig | 1 + drivers/scsi/Kconfig | 1 + 3 files changed, 5 insertions(+), 2 deletions(-)
arch/powerpc/platforms/iseries/Kconfig +3 -2
@@ -10,18 +10,21 @@ menu "iSeries device drivers" config VIODASD tristate "iSeries Virtual I/O disk support" depends on BLOCK + select VIOPATH help If you are running on an iSeries system and you want to use virtual disks created and managed by OS/400, say Y. config VIOCD tristate "iSeries Virtual I/O CD support" + select VIOPATH help If you are running Linux on an IBM iSeries system and you want to read a CD drive owned by OS/400, say Y here. config VIOTAPE tristate "iSeries Virtual Tape Support" + select VIOPATH help If you are running Linux on an iSeries system and you want Linux to read and/or write a tape drive owned by OS/400, say Y here.
@@ -30,5 +33,3 @@ endmenu config VIOPATH bool - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH - default y
drivers/char/Kconfig +1 -0
@@ -616,6 +616,7 @@ config HVC_ISERIES default y select HVC_DRIVER select HVC_IRQ + select VIOPATH help iSeries machines support a hypervisor virtual console.
drivers/scsi/Kconfig +1 -0
@@ -884,6 +884,7 @@ config SCSI_IBMVSCSI tristate "IBM Virtual SCSI support" depends on PPC_PSERIES || PPC_ISERIES select SCSI_SRP_ATTRS + select VIOPATH if PPC_ISERIES help This is the IBM POWER Virtual SCSI Client
Signature · 4 lines
Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL.
Sam Ravnborg
Reviewed-byQuoted 22 lines · Kamalesh Babulal
Quoted 13 lines · Sam Ravnborg
Hi Kamalesh
Looks good, small nit below.
arch/powerpc/platforms/iseries/Kconfig endmenu
Quoted 5 lines
config VIOPATH
arch/powerpc/platforms/iseries/Kconfig +1
-2bool - depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH - default y + default nAs 'n' is default anyway this line is not needed and I suggest you spin a final version of the patch with this removed.
Quoted 1 line
Sam
Hi Sam,
Thanks for the review comments. I am resending the patch with the changes
you have recommended.
Quoted 7 lines
Impact: Fix the VIOPATH dependency in the iSeries dependent drivers.
iSeries depend drivers build fails, when
CONFIG_VIOPATHis disabled. Removing the dependency of VIOPATH by selecting it, when the drivers dependent on iSeries code.Signed-off-by Kamalesh Babulal <[email protected]>