Skip to contentSkip to conversation

powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/

PATCH In review Anton Vorontsov 5 participants 10 messages Jan 11, 2009 – Jan 13, 2009 4 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/

This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/.

---

This is git patch.

 arch/powerpc/platforms/83xx/Makefile               |    1 +
 .../powerpc/platforms/83xx}/mcu_mpc8349emitx.c     |    0 
 arch/powerpc/platforms/Kconfig                     |   11 +++++++++++
 drivers/i2c/chips/Kconfig                          |   11 -----------
 drivers/i2c/chips/Makefile                         |    1 -
 5 files changed, 12 insertions(+), 12 deletions(-)
 rename {drivers/i2c/chips => arch/powerpc/platforms/83xx}/mcu_mpc8349emitx.c (100%)
arch/powerpc/platforms/83xx/Makefile +1 -0
index ba5028e..051777c 100644
@@ -3,6 +3,7 @@
 #
 obj-y				:= misc.o usb.o
 obj-$(CONFIG_SUSPEND)		+= suspend.o suspend-asm.o
+obj-$(CONFIG_MCU_MPC8349EMITX)	+= mcu_mpc8349emitx.o
 obj-$(CONFIG_MPC831x_RDB)	+= mpc831x_rdb.o
 obj-$(CONFIG_MPC832x_RDB)	+= mpc832x_rdb.o
 obj-$(CONFIG_MPC834x_MDS)	+= mpc834x_mds.o
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c renamed from drivers/i2c/chips/mcu_mpc8349emitx.c +0 -0
similarity index 100%
rename from drivers/i2c/chips/mcu_mpc8349emitx.c
rename to arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
arch/powerpc/platforms/Kconfig +11 -0
index 47fe2be..200b9cb 100644
@@ -323,4 +323,15 @@ config SIMPLE_GPIO
 	  chip-selects, Ethernet/USB PHY's power and various other small
 	  on-board peripherals.
 
+config MCU_MPC8349EMITX
+	tristate "MPC8349E-mITX MCU driver"
+	depends on I2C && PPC_83xx
+	select GENERIC_GPIO
+	select ARCH_REQUIRE_GPIOLIB
+	help
+	  Say Y here to enable soft power-off functionality on the Freescale
+	  boards with the MPC8349E-mITX-compatible MCU chips. This driver will
+	  also register MCU GPIOs with the generic GPIO API, so you'll able
+	  to use MCU pins as GPIOs.
+
 endmenu
drivers/i2c/chips/Kconfig +0 -11
index 4c35702..d383e81 100644
@@ -174,15 +174,4 @@ config MENELAUS
 	  and other features that are often used in portable devices like
 	  cell phones and PDAs.
 
-config MCU_MPC8349EMITX
-	tristate "MPC8349E-mITX MCU driver"
-	depends on I2C && PPC_83xx
-	select GENERIC_GPIO
-	select ARCH_REQUIRE_GPIOLIB
-	help
-	  Say Y here to enable soft power-off functionality on the Freescale
-	  boards with the MPC8349E-mITX-compatible MCU chips. This driver will
-	  also register MCU GPIOs with the generic GPIO API, so you'll able
-	  to use MCU pins as GPIOs.
-
 endmenu
drivers/i2c/chips/Makefile +0 -1
index 23d2a31..7e769b0 100644
@@ -22,7 +22,6 @@ obj-$(CONFIG_ISP1301_OMAP)	+= isp1301_omap.o
 obj-$(CONFIG_TPS65010)		+= tps65010.o
 obj-$(CONFIG_MENELAUS)		+= menelaus.o
 obj-$(CONFIG_SENSORS_TSL2550)	+= tsl2550.o
-obj-$(CONFIG_MCU_MPC8349EMITX)	+= mcu_mpc8349emitx.o
 
 ifeq ($(CONFIG_I2C_DEBUG_CHIP),y)
 EXTRA_CFLAGS += -DDEBUG
Signature · 1 line
1.5.6.5

A message that is not in the archive (sent off-list or not yet received): 20090111165136.GA26096-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org

#2 lore raw

PATCH 1/1 powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/

This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/.

---

The same patch but suitable for patch(1).

 arch/powerpc/platforms/83xx/Makefile           |    1 +
 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c |  209 ++++++++++++++++++++++++
 arch/powerpc/platforms/Kconfig                 |   11 ++
 drivers/i2c/chips/Kconfig                      |   11 --
 drivers/i2c/chips/Makefile                     |    1 -
 drivers/i2c/chips/mcu_mpc8349emitx.c           |  209 ------------------------
 6 files changed, 221 insertions(+), 221 deletions(-)
 create mode 100644 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
 delete mode 100644 drivers/i2c/chips/mcu_mpc8349emitx.c
arch/powerpc/platforms/83xx/Makefile +1 -0
index ba5028e..051777c 100644
@@ -3,6 +3,7 @@
 #
 obj-y				:= misc.o usb.o
 obj-$(CONFIG_SUSPEND)		+= suspend.o suspend-asm.o
+obj-$(CONFIG_MCU_MPC8349EMITX)	+= mcu_mpc8349emitx.o
 obj-$(CONFIG_MPC831x_RDB)	+= mpc831x_rdb.o
 obj-$(CONFIG_MPC832x_RDB)	+= mpc832x_rdb.o
 obj-$(CONFIG_MPC834x_MDS)	+= mpc834x_mds.o
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c new file +209 -0

209 lines not on this page · raw message

arch/powerpc/platforms/Kconfig +11 -0
index 47fe2be..200b9cb 100644
@@ -323,4 +323,15 @@ config SIMPLE_GPIO
 	  chip-selects, Ethernet/USB PHY's power and various other small
 	  on-board peripherals.
 
+config MCU_MPC8349EMITX
+	tristate "MPC8349E-mITX MCU driver"
+	depends on I2C && PPC_83xx
+	select GENERIC_GPIO
+	select ARCH_REQUIRE_GPIOLIB
+	help
+	  Say Y here to enable soft power-off functionality on the Freescale
+	  boards with the MPC8349E-mITX-compatible MCU chips. This driver will
+	  also register MCU GPIOs with the generic GPIO API, so you'll able
+	  to use MCU pins as GPIOs.
+
 endmenu
drivers/i2c/chips/Kconfig +0 -11
index 4c35702..d383e81 100644
@@ -174,15 +174,4 @@ config MENELAUS
 	  and other features that are often used in portable devices like
 	  cell phones and PDAs.
 
-config MCU_MPC8349EMITX
-	tristate "MPC8349E-mITX MCU driver"
-	depends on I2C && PPC_83xx
-	select GENERIC_GPIO
-	select ARCH_REQUIRE_GPIOLIB
-	help
-	  Say Y here to enable soft power-off functionality on the Freescale
-	  boards with the MPC8349E-mITX-compatible MCU chips. This driver will
-	  also register MCU GPIOs with the generic GPIO API, so you'll able
-	  to use MCU pins as GPIOs.
-
 endmenu
drivers/i2c/chips/Makefile +0 -1
index 23d2a31..7e769b0 100644
@@ -22,7 +22,6 @@ obj-$(CONFIG_ISP1301_OMAP)	+= isp1301_omap.o
 obj-$(CONFIG_TPS65010)		+= tps65010.o
 obj-$(CONFIG_MENELAUS)		+= menelaus.o
 obj-$(CONFIG_SENSORS_TSL2550)	+= tsl2550.o
-obj-$(CONFIG_MCU_MPC8349EMITX)	+= mcu_mpc8349emitx.o
 
 ifeq ($(CONFIG_I2C_DEBUG_CHIP),y)
 EXTRA_CFLAGS += -DDEBUG
drivers/i2c/chips/mcu_mpc8349emitx.c deleted +0 -209

209 lines not on this page · raw message

Signature · 1 line
1.5.6.5

A message that is not in the archive (sent off-list or not yet received): 20090111165539.GA27223-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org

Applied
#4 lore raw
Quoted 12 lines · Anton Vorontsov

This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/.

---

The same patch but suitable for patch(1).

arch/powerpc/platforms/83xx/Makefile | 1 +
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 209 +++++++++++++++
+++++++++

Quoted 8 lines
arch/powerpc/platforms/Kconfig                 |   11 ++
drivers/i2c/chips/Kconfig                      |   11 --
drivers/i2c/chips/Makefile                     |    1 -
drivers/i2c/chips/mcu_mpc8349emitx.c           |  209  
------------------------
6 files changed, 221 insertions(+), 221 deletions(-)

create mode 100644 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c delete mode 100644 drivers/i2c/chips/mcu_mpc8349emitx.c

applied

- k

#5 lore raw
Quoted 25 lines · Kumar Gala
Quoted 13 lines · Anton Vorontsov

This patch is used to help Jean Delvare to get rid of drivers/i2c/ chips/
directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/.

---

The same patch but suitable for patch(1).

arch/powerpc/platforms/83xx/Makefile | 1 +
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 209 +++++++++++++++
+++++++++

Quoted 8 lines
arch/powerpc/platforms/Kconfig                 |   11 ++
drivers/i2c/chips/Kconfig                      |   11 --
drivers/i2c/chips/Makefile                     |    1 -
drivers/i2c/chips/mcu_mpc8349emitx.c           |  209  
------------------------
6 files changed, 221 insertions(+), 221 deletions(-)

create mode 100644 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c delete mode 100644 drivers/i2c/chips/mcu_mpc8349emitx.c

Quoted 1 line

applied

Great, thanks Anton and Kumar!

Signature · 1 line
Jean Delvare
#6 lore raw
In reply to a message not in the archive

Hi Anton,

Quoted 5 lines · Anton Vorontsov

This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/.

Thanks for doing this. Do you expect me to take this patch in my i2c tree, or will it go in some powerpc tree?

Signature · 1 line
Jean Delvare

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw
Quoted 11 lines · Jean Delvare

Hi Anton,

Quoted 5 lines · Anton Vorontsov

This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/.

Thanks for doing this. Do you expect me to take this patch in my i2c tree, or will it go in some powerpc tree?

As the patch adds some code to arch/powerpc/, I believe Kumar would want to merge it into his powerpc tree. In that case I think we'll need your Acked-by line for formality.

But let's wait for Kumar's decision.

Thanks,

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2

A message that is not in the archive (sent off-list or not yet received): 20090111172410.GA7106-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org

Acked-by
#10 lore raw
Quoted 8 lines · Anton Vorontsov
Quoted 7 lines · Jean Delvare

Hi Anton,

Quoted 4 lines · Anton Vorontsov

This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Thanks for doing this. Do you expect me to take this patch in my i2c tree, or will it go in some powerpc tree?

As the patch adds some code to arch/powerpc/, I believe Kumar would want to merge it into his powerpc tree. In that case I think we'll need your Acked-by line for formality.

Sure:

Quoted 1 line

But let's wait for Kumar's decision.

Signature · 1 line
Jean Delvare
#11 lore raw
In reply to a message not in the archive
Quoted 11 lines · Jean Delvare

Hi Anton,

Quoted 5 lines · Anton Vorontsov

This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/.

Thanks for doing this. Do you expect me to take this patch in my i2c tree, or will it go in some powerpc tree?

I'll pick this up.

- k

#12 lore raw
In reply to Jean Delvare
Quoted 11 lines · Jean Delvare

Hi Anton,

Quoted 5 lines · Anton Vorontsov

This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/.

Thanks for doing this. Do you expect me to take this patch in my i2c tree, or will it go in some powerpc tree?

I'll pick this up.

- k

#13 lore raw
In reply to Jean Delvare
Quoted 11 lines · Jean Delvare

Hi Anton,

Quoted 5 lines · Anton Vorontsov

This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/.

Thanks for doing this. Do you expect me to take this patch in my i2c tree, or will it go in some powerpc tree?

I'll pick this up.

- k