cxgb3 - Fix LRO misalignment
Subsystems (2)
PATCH 1/1 cxgb3 - Fix LRO misalignment
From: Divy Le Ray <[email protected]>
The lro manager's frag_align_pad setting was missing, leading to misaligned access to the skb passed up to the stack.
---
drivers/net/cxgb3/sge.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/cxgb3/sge.c +1 -0
@@ -2104,6 +2104,7 @@ static void init_lro_mgr(struct sge_qset *qs, struct net_lro_mgr *lro_mgr) { lro_mgr->dev = qs->netdev; lro_mgr->features =LRO_F_NAPI ; + lro_mgr->frag_align_pad =NET_IP_ALIGN ; lro_mgr->ip_summed =CHECKSUM_UNNECESSARY ; lro_mgr->ip_summed_aggr =CHECKSUM_UNNECESSARY ; lro_mgr->max_desc =T3_MAX_LRO_SES ;
Quoted 7 lines · Divy Le Ray
From: Divy Le Ray <[email protected]>
The lro manager's
frag_align_padsetting was missing, leading to misaligned access to the skb passed up to the stack.Signed-off-by Divy Le Ray <[email protected]>
I have tried this in a tree I have, and where I was once seeing unaligned access messages on an ia64 system with LRO enabled, now I see none.
rick jones
Quoted 8 lines · Rick Jones
Quoted 6 lines · Divy Le Ray
From: Divy Le Ray <[email protected]>
The lro manager's
frag_align_padsetting was missing, leading to misaligned access to the skb passed up to the stack.
Quoted 10 lines
Quoted 2 lines
Signed-off-by Divy Le Ray <[email protected]>I have tried this in a tree I have, and where I was once seeing unaligned access messages on an ia64 system with LRO enabled, now I see none.
Tested-by Rick Jones <[email protected]>rick jones
Hi Dave,
The patch is intended for 2.6.29, not 2.6.28 as the subject mistakenly states.
Cheers,
Divy
David Miller
maintainerFrom: Divy Le Ray <[email protected]>
Date: Fri, 16 Jan 2009 11:05:50 -0800
Quoted 1 line
The patch is intended for 2.6.29, not 2.6.28 as the subject mistakenly states.
Understood, applied, thanks everyone.