Skip to contentSkip to conversation

cxgb3 - Fix LRO misalignment

PATCH In review Divy Le Ray 3 participants 4 messages Jan 16, 2009 – Jan 19, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cxgb3 - Fix LRO misalignment

From: Divy Le Ray <[email protected]>

The lro manager's frag_align_pad setting was missing, leading to misaligned access to the skb passed up to the stack.

---

 drivers/net/cxgb3/sge.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/cxgb3/sge.c +1 -0
index 14f9fb3..379a132 100644
@@ -2104,6 +2104,7 @@ static void init_lro_mgr(struct sge_qset *qs, struct net_lro_mgr *lro_mgr)
 {
 	lro_mgr->dev = qs->netdev;
 	lro_mgr->features = LRO_F_NAPI;
+	lro_mgr->frag_align_pad = NET_IP_ALIGN;
 	lro_mgr->ip_summed = CHECKSUM_UNNECESSARY;
 	lro_mgr->ip_summed_aggr = CHECKSUM_UNNECESSARY;
 	lro_mgr->max_desc = T3_MAX_LRO_SES;
#2 lore raw
Quoted 8 lines · Rick Jones
Quoted 6 lines · Divy Le Ray

From: Divy Le Ray <[email protected]>

The lro manager's frag_align_pad setting was missing, leading to misaligned access to the skb passed up to the stack.

Quoted 10 lines
Quoted 2 lines

I have tried this in a tree I have, and where I was once seeing unaligned access messages on an ia64 system with LRO enabled, now I see none.

rick jones

Hi Dave,

The patch is intended for 2.6.29, not 2.6.28 as the subject mistakenly states.

Cheers,
Divy

maintainer
#3 lore raw

From: Divy Le Ray <[email protected]>
Date: Fri, 16 Jan 2009 11:05:50 -0800

Quoted 1 line

The patch is intended for 2.6.29, not 2.6.28 as the subject mistakenly states.

Understood, applied, thanks everyone.