Skip to contentSkip to conversation

Leadtek WinFast DTV-1800H and DTV-2000H

PATCH In review Miroslav Šustek 2 participants 2 messages Feb 1, 2009 8 messages not in the archive Media (V4L/DVB)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw

PATCH 1/1 Leadtek WinFast DTV-1800H and DTV-2000H

Hi, few months ago I sent the patch for Leadtek WinFast DTV-1800H card, but it wasn't merged to repository yet. Maybe it's because of the merging of mailing lists. I'm sending it again.

These are the original messages:
http://linuxtv.org/pipermail/linux-dvb/2008-October/029859.html
http://linuxtv.org/pipermail/linux-dvb/2008-November/030362.html

Briefly, patch adds support for analog tv, radio, dvb-t and remote control. About three people already confirmed the functionality.
----

The second patch I attached (leadtek_winfast_dtv2000h.patch) is from Mirek Slugeň and it adds support for some revisions of Leadtek WinFast DTV-2000H. I don't have any of DTV-2000H cards, so I cannot confirm its correctness.

Here is the original message from Mirek Slugeň:
http://linuxtv.org/pipermail/linux-dvb/2008-November/030644.html

(The patch is dependent on 1800H patch.)
----

I hope this is the last time I'm bothering you with this thing. ;)

- Miroslav Šustek

Adds support for Leadtek WinFast DTV-1800H

From: Miroslav Sustek <[email protected]>

Enables analog tv and radio, dvb-t and (gpio) remote control.

linux/Documentation/video4linux/CARDLIST.cx88 +1 -0
diff -r 1dce9d4e2179 linux/Documentation/video4linux/CARDLIST.cx88
@@ -77,3 +77,4 @@
  76 -> SATTRADE ST4200 DVB-S/S2                            [b200:4200]
  77 -> TBS 8910 DVB-S                                      [8910:8888]
  78 -> Prof 6200 DVB-S                                     [b022:3022]
+ 79 -> Leadtek WinFast DTV1800 Hybrid                      [107d:6654]
linux/drivers/media/video/cx88/cx88-cards.c +75 -0

111 lines not on this page · raw message

linux/drivers/media/video/cx88/cx88-dvb.c +1 -0
diff -r 1dce9d4e2179 linux/drivers/media/video/cx88/cx88-dvb.c
@@ -1015,6 +1015,7 @@
 		}
 		break;
 	 case CX88_BOARD_PINNACLE_HYBRID_PCTV:
+	case CX88_BOARD_WINFAST_DTV1800H:
 		fe0->dvb.frontend = dvb_attach(zl10353_attach,
 					       &cx88_pinnacle_hybrid_pctv,
 					       &core->i2c_adap);
linux/drivers/media/video/cx88/cx88-input.c +2 -0
diff -r 1dce9d4e2179 linux/drivers/media/video/cx88/cx88-input.c
@@ -93,6 +93,7 @@
 		gpio=(gpio & 0x7fd) + (auxgpio & 0xef);
 		break;
 	case CX88_BOARD_WINFAST_DTV1000:
+	case CX88_BOARD_WINFAST_DTV1800H:
 		gpio = (gpio & 0x6ff) | ((cx_read(MO_GP1_IO) << 8) & 0x900);
 		auxgpio = gpio;
 		break;
@@ -244,6 +245,7 @@
 		ir->sampling = 1;
 		break;
 	case CX88_BOARD_WINFAST_DTV2000H:
+	case CX88_BOARD_WINFAST_DTV1800H:
 		ir_codes = ir_codes_winfast;
 		ir->gpio_addr = MO_GP0_IO;
 		ir->mask_keycode = 0x8f8;
linux/drivers/media/video/cx88/cx88.h +1 -0
diff -r 1dce9d4e2179 linux/drivers/media/video/cx88/cx88.h
@@ -232,6 +232,7 @@
 #define CX88_BOARD_SATTRADE_ST4200         76
 #define CX88_BOARD_TBS_8910                77
 #define CX88_BOARD_PROF_6200               78
+#define CX88_BOARD_WINFAST_DTV1800H        79
 
 enum cx88_itype {
 	CX88_VMUX_COMPOSITE1 = 1,
linux/drivers/media/video/cx88/cx88-cards.c +108 -8

152 lines not on this page · raw message

linux/drivers/media/video/cx88/cx88-dvb.c +3 -1
diff -r 413f3d76ebe6 linux/drivers/media/video/cx88/cx88-dvb.c
@@ -695,7 +695,8 @@
 				goto frontend_detach;
 		}
 		break;
-	case CX88_BOARD_WINFAST_DTV2000H:
+	case CX88_BOARD_WINFAST_DTV2000H_I:
+	case CX88_BOARD_WINFAST_DTV2000H_J:
 	case CX88_BOARD_HAUPPAUGE_HVR1100:
 	case CX88_BOARD_HAUPPAUGE_HVR1100LP:
 	case CX88_BOARD_HAUPPAUGE_HVR1300:
@@ -1016,6 +1017,7 @@
 		break;
 	 case CX88_BOARD_PINNACLE_HYBRID_PCTV:
 	case CX88_BOARD_WINFAST_DTV1800H:
+	case CX88_BOARD_WINFAST_DTV2000H_PLUS:
 		fe0->dvb.frontend = dvb_attach(zl10353_attach,
 					       &cx88_pinnacle_hybrid_pctv,
 					       &core->i2c_adap);
linux/drivers/media/video/cx88/cx88-input.c +6 -1
diff -r 413f3d76ebe6 linux/drivers/media/video/cx88/cx88-input.c
@@ -94,6 +94,9 @@
 		break;
 	case CX88_BOARD_WINFAST_DTV1000:
 	case CX88_BOARD_WINFAST_DTV1800H:
+	case CX88_BOARD_WINFAST_DTV2000H_I:
+	case CX88_BOARD_WINFAST_DTV2000H_J:
+	case CX88_BOARD_WINFAST_DTV2000H_PLUS:
 		gpio = (gpio & 0x6ff) | ((cx_read(MO_GP1_IO) << 8) & 0x900);
 		auxgpio = gpio;
 		break;
@@ -244,8 +247,10 @@
 		ir_type = IR_TYPE_RC5;
 		ir->sampling = 1;
 		break;
-	case CX88_BOARD_WINFAST_DTV2000H:
 	case CX88_BOARD_WINFAST_DTV1800H:
+	case CX88_BOARD_WINFAST_DTV2000H_I:
+	case CX88_BOARD_WINFAST_DTV2000H_J:
+	case CX88_BOARD_WINFAST_DTV2000H_PLUS:
 		ir_codes = ir_codes_winfast;
 		ir->gpio_addr = MO_GP0_IO;
 		ir->mask_keycode = 0x8f8;
linux/drivers/media/video/cx88/cx88.h +3 -1
diff -r 413f3d76ebe6 linux/drivers/media/video/cx88/cx88.h
@@ -204,7 +204,7 @@
 #define CX88_BOARD_KWORLD_MCE200_DELUXE    48
 #define CX88_BOARD_PIXELVIEW_PLAYTV_P7000  49
 #define CX88_BOARD_NPGTECH_REALTV_TOP10FM  50
-#define CX88_BOARD_WINFAST_DTV2000H        51
+#define CX88_BOARD_WINFAST_DTV2000H_I      51
 #define CX88_BOARD_GENIATECH_DVBS          52
 #define CX88_BOARD_HAUPPAUGE_HVR3000       53
 #define CX88_BOARD_NORWOOD_MICRO           54
@@ -233,6 +233,8 @@
 #define CX88_BOARD_TBS_8910                77
 #define CX88_BOARD_PROF_6200               78
 #define CX88_BOARD_WINFAST_DTV1800H        79
+#define CX88_BOARD_WINFAST_DTV2000H_J      80
+#define CX88_BOARD_WINFAST_DTV2000H_PLUS   81
 
 enum cx88_itype {
 	CX88_VMUX_COMPOSITE1 = 1,
#9 lore raw

Hi,

Am Sonntag, den 01.02.2009, 17:37 +0100 schrieb Miroslav Šustek:

Quoted 17 lines

Hi, few months ago I sent the patch for Leadtek WinFast DTV-1800H card, but it wasn't merged to repository yet. Maybe it's because of the merging of mailing lists. I'm sending it again.

These are the original messages:
http://linuxtv.org/pipermail/linux-dvb/2008-October/029859.html
http://linuxtv.org/pipermail/linux-dvb/2008-November/030362.html

Briefly, patch adds support for analog tv, radio, dvb-t and remote control. About three people already confirmed the functionality.
----

The second patch I attached (leadtek_winfast_dtv2000h.patch) is from Mirek Slugeň and it adds support for some revisions of Leadtek WinFast DTV-2000H. I don't have any of DTV-2000H cards, so I cannot confirm its correctness.

Here is the original message from Mirek Slugeň:
http://linuxtv.org/pipermail/linux-dvb/2008-November/030644.html

Quoted 7 lines

(The patch is dependent on 1800H patch.)
----

I hope this is the last time I'm bothering you with this thing. ;)

- Miroslav Šustek

Miroslav, Mirek, looks OK so far,

but biggest problem is that all patches have no Signed-off-by line. Try README.patches in v4l-dvb and related.

The not at all working radio on the DTV2000H_J could indicate that it is a FMD1216MEX with different radio IF, which was recently added by Darron Broad. Good idea how they did expand the antenna input connectors.

Also, for the unsupported XCeive4000 on the DTV2000H_PLUS I guess TUNER_ABSENT should be used until support for it is ready and all related ?

There is another patch from Mirek for saa7134 with multiple multi frontend boards from Nov. 28 2008 where I asked for his SOB, but no response. It has at least a tested-by from me and an updated version against recent v4l-dvb can be provided.
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031217.html

Mauro seems to prefer to have v4l-dvb related e-mails at infradead.org. Changed to it.

Cheers,
Hermann