Skip to contentSkip to conversation

ASoC: add additional controls to the CS4270 codec driver

PATCH In review Timur Tabi 2 participants 2 messages Feb 3, 2009 – Feb 4, 2009

Subsystems (3)
lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH 1/1 ASoC: add additional controls to the CS4270 codec driver

Update the CS4270 codec driver to allow applications to use the mixer to control Digital Loopback, Soft Ramp, Zero Cross, Popguard, and Auto-Mute. Soft Ramp, Zero Cross, and Auto-Mute are disabled by the driver when it first initializes the hardware, but these features either don't work or interfere with normal ALSA behavior. However, they can now be re-enabled by an application if desired.

Remove CONFIG_SND_SOC_CS4270_HWMUTE and always allow ASoC to control the mute bits. The driver previously and erroneously assumed that these bits control only external muting circuitry, but they also control internal muting circuitry, so they should always be used.

---
 sound/soc/codecs/Kconfig  |    6 ---
 sound/soc/codecs/cs4270.c |   93 +++++++++++++++++++-------------------------
 2 files changed, 40 insertions(+), 59 deletions(-)
sound/soc/codecs/Kconfig +0 -6
index a195303..628a591 100644
@@ -67,12 +67,6 @@ config SND_SOC_AK4535
 config SND_SOC_CS4270
 	tristate
 
-# Cirrus Logic CS4270 Codec Hardware Mute Support
-# Select if you have external muting circuitry attached to your CS4270.
-config SND_SOC_CS4270_HWMUTE
-	bool
-	depends on SND_SOC_CS4270
-
 # Cirrus Logic CS4270 Codec VD = 3.3V Errata
 # Select if you are affected by the errata where the part will not function
 # if MCLK divide-by-1.5 is selected and VD is set to 3.3V.  The driver will
sound/soc/codecs/cs4270.c +40 -53

140 lines not on this page · raw message

Signature · 1 line
1.5.5
#1 lore raw
Quoted 4 lines · Timur Tabi

Remove CONFIG_SND_SOC_CS4270_HWMUTE and always allow ASoC to control the mute bits. The driver previously and erroneously assumed that these bits control only external muting circuitry, but they also control internal muting circuitry, so they should always be used.

As discussed I'm holding off on this until the I2C folks decide what to do about the signal handling issue you found on teardown.