Skip to contentSkip to conversation

Bug in mxl5005s driver

DISCUSSION Jose Alberto Reguero 2 participants 3 messages Mar 22, 2009 – Mar 24, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

In line 3992:

        if (fe->ops.info.type == FE_ATSC) {
                switch (params->u.vsb.modulation) {
                case VSB_8:
                        req_mode = MXL_ATSC; break;
                default:
                case QAM_64:
                case QAM_256:
                case QAM_AUTO:
                        req_mode = MXL_QAM; break;
                }
        } else
                req_mode = MXL_DVBT;

req_mode is filled with MXL_ATSC, MXL_QAM, or MXL_DVBT

and in line 4007 req_mode is used like params->u.vsb.modulation

                switch (req_mode) {
                case VSB_8:
                case QAM_64:
                case QAM_256:
                case QAM_AUTO:
                        req_bw  = MXL5005S_BANDWIDTH_6MHZ;
                        break;
                default:
                        /* Assume DVB-T */
                        switch (params->u.ofdm.bandwidth) {
                        case BANDWIDTH_6_MHZ:
                                req_bw  = MXL5005S_BANDWIDTH_6MHZ;
                                break;
                        case BANDWIDTH_7_MHZ:
                                req_bw  = MXL5005S_BANDWIDTH_7MHZ;
                                break;
                        case BANDWIDTH_AUTO:
                        case BANDWIDTH_8_MHZ:

Jose Alberto Reguero

#1 lore raw
Quoted 39 lines · Jose Alberto Reguero

In line 3992:

        if (fe->ops.info.type == FE_ATSC) {
                switch (params->u.vsb.modulation) {
                case VSB_8:
                        req_mode = MXL_ATSC; break;
                default:
                case QAM_64:
                case QAM_256:
                case QAM_AUTO:
                        req_mode = MXL_QAM; break;
                }
        } else
                req_mode = MXL_DVBT;

req_mode is filled with MXL_ATSC, MXL_QAM, or MXL_DVBT

and in line 4007 req_mode is used like params->u.vsb.modulation

                switch (req_mode) {
                case VSB_8:
                case QAM_64:
                case QAM_256:
                case QAM_AUTO:
                        req_bw  = MXL5005S_BANDWIDTH_6MHZ;
                        break;
                default:
                        /* Assume DVB-T */
                        switch (params->u.ofdm.bandwidth) {
                        case BANDWIDTH_6_MHZ:
                                req_bw  = MXL5005S_BANDWIDTH_6MHZ;
                                break;
                        case BANDWIDTH_7_MHZ:
                                req_bw  = MXL5005S_BANDWIDTH_7MHZ;
                                break;
                        case BANDWIDTH_AUTO:
                        case BANDWIDTH_8_MHZ:
Quoted 1 line

Jose Alberto Reguero

Easy enough. Please try the patch here:

http://linuxtv.org/hg/~awalls/v4l-dvb

Sorry I forgot to add a

in the commit. I can fix that if things work out.

Regards,
Andy

#2 lore raw
Quoted 50 lines · Andy Walls
Quoted 39 lines · Jose Alberto Reguero

In line 3992:

        if (fe->ops.info.type == FE_ATSC) {
                switch (params->u.vsb.modulation) {
                case VSB_8:
                        req_mode = MXL_ATSC; break;
                default:
                case QAM_64:
                case QAM_256:
                case QAM_AUTO:
                        req_mode = MXL_QAM; break;
                }
        } else
                req_mode = MXL_DVBT;

req_mode is filled with MXL_ATSC, MXL_QAM, or MXL_DVBT

and in line 4007 req_mode is used like params->u.vsb.modulation

                switch (req_mode) {
                case VSB_8:
                case QAM_64:
                case QAM_256:
                case QAM_AUTO:
                        req_bw  = MXL5005S_BANDWIDTH_6MHZ;
                        break;
                default:
                        /* Assume DVB-T */
                        switch (params->u.ofdm.bandwidth) {
                        case BANDWIDTH_6_MHZ:
                                req_bw  = MXL5005S_BANDWIDTH_6MHZ;
                                break;
                        case BANDWIDTH_7_MHZ:
                                req_bw  = MXL5005S_BANDWIDTH_7MHZ;
                                break;
                        case BANDWIDTH_AUTO:
                        case BANDWIDTH_8_MHZ:
Quoted 1 line

Jose Alberto Reguero

Easy enough. Please try the patch here:

http://linuxtv.org/hg/~awalls/v4l-dvb

Sorry I forgot to add a

Quoted 8 lines

in the commit. I can fix that if things work out.

Regards,
Andy

Work well with DVB-T.

Thanks.

Jose Alberto