Bug in mxl5005s driver
In line 3992:
if (fe->ops.info.type == FE_ATSC) {
switch (params->u.vsb.modulation) {
case VSB_8:
req_mode = MXL_ATSC; break;
default:
case QAM_64:
case QAM_256:
case QAM_AUTO:
req_mode = MXL_QAM; break;
}
} else
req_mode = MXL_DVBT;req_mode is filled with MXL_ATSC, MXL_QAM, or MXL_DVBT
and in line 4007 req_mode is used like params->u.vsb.modulation
switch (req_mode) {
case VSB_8:
case QAM_64:
case QAM_256:
case QAM_AUTO:
req_bw = MXL5005S_BANDWIDTH_6MHZ;
break;
default:
/* Assume DVB-T */
switch (params->u.ofdm.bandwidth) {
case BANDWIDTH_6_MHZ:
req_bw = MXL5005S_BANDWIDTH_6MHZ;
break;
case BANDWIDTH_7_MHZ:
req_bw = MXL5005S_BANDWIDTH_7MHZ;
break;
case BANDWIDTH_AUTO:
case BANDWIDTH_8_MHZ:Jose Alberto Reguero
Quoted 39 lines · Jose Alberto Reguero
In line 3992:
if (fe->ops.info.type == FE_ATSC) { switch (params->u.vsb.modulation) { case VSB_8: req_mode = MXL_ATSC; break; default: case QAM_64: case QAM_256: case QAM_AUTO: req_mode = MXL_QAM; break; } } else req_mode = MXL_DVBT;
req_modeis filled withMXL_ATSC,MXL_QAM, orMXL_DVBTand in line 4007
req_modeis used likeparams->u.vsb.modulationswitch (req_mode) { case VSB_8: case QAM_64: case QAM_256: case QAM_AUTO: req_bw = MXL5005S_BANDWIDTH_6MHZ; break; default: /* Assume DVB-T */ switch (params->u.ofdm.bandwidth) { case BANDWIDTH_6_MHZ: req_bw = MXL5005S_BANDWIDTH_6MHZ; break; case BANDWIDTH_7_MHZ: req_bw = MXL5005S_BANDWIDTH_7MHZ; break; case BANDWIDTH_AUTO: case BANDWIDTH_8_MHZ:
Quoted 1 line
Jose Alberto Reguero
Easy enough. Please try the patch here:
http://linuxtv.org/hg/~awalls/v4l-dvb
Sorry I forgot to add a
in the commit. I can fix that if things work out.
Regards,
Andy
Quoted 50 lines · Andy Walls
Quoted 39 lines · Jose Alberto Reguero
In line 3992:
if (fe->ops.info.type == FE_ATSC) { switch (params->u.vsb.modulation) { case VSB_8: req_mode = MXL_ATSC; break; default: case QAM_64: case QAM_256: case QAM_AUTO: req_mode = MXL_QAM; break; } } else req_mode = MXL_DVBT;
req_modeis filled withMXL_ATSC,MXL_QAM, orMXL_DVBTand in line 4007
req_modeis used likeparams->u.vsb.modulationswitch (req_mode) { case VSB_8: case QAM_64: case QAM_256: case QAM_AUTO: req_bw = MXL5005S_BANDWIDTH_6MHZ; break; default: /* Assume DVB-T */ switch (params->u.ofdm.bandwidth) { case BANDWIDTH_6_MHZ: req_bw = MXL5005S_BANDWIDTH_6MHZ; break; case BANDWIDTH_7_MHZ: req_bw = MXL5005S_BANDWIDTH_7MHZ; break; case BANDWIDTH_AUTO: case BANDWIDTH_8_MHZ:Quoted 1 line
Jose Alberto Reguero
Easy enough. Please try the patch here:
http://linuxtv.org/hg/~awalls/v4l-dvb
Sorry I forgot to add a
Quoted 8 lines
Reported-by Jose Alberto Reguero <[email protected]>in the commit. I can fix that if things work out.
Regards,
Andy
Work well with DVB-T.
Thanks.
Jose Alberto