Skip to contentSkip to conversation

sensord: Some cleanups,

PATCH In review Andre Prendel 2 participants 3 messages Apr 6, 2009

lore
Share & tools
lore
#0 lore raw

cover sensord: Some cleanups,

Hello Jean,

this patch series fixes some issues caused by the coding style conversion a while ago. Most of them are deep indentation levels and the related long lines.

Another patch removes the hidden commandline interface. You can call sensord as an console application if you have a link (sensors) pointing to the sensors deamon (sensord). IMO that's really intransparent and I don't know any reason using this.

Further there is a patch introducing a new structure (sensord_arguments). The extern struct sensord_args in args.c now is the place for all the commandline arguments.

A last one replaces the deprecated signal() function by sigaction.

Andre
---

 args.c    |  205 +++++++++++++++++++++++++++++---------------------------------
 args.h    |   30 +++++++++
 lib.c     |   93 ++++++++++++++++------------
 rrd.c     |  108 ++++++++++++++++----------------
 sense.c   |    6 -
 sensord.c |   89 ++++++++++++++++----------
 sensord.h |   18 -----
 7 files changed, 294 insertions(+), 255 deletions(-)

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw

Hi Andre,

Quoted 11 lines · Andre Prendel

Hello Jean,

this patch series fixes some issues caused by the coding style conversion a while ago. Most of them are deep indentation levels and the related long lines.

Another patch removes the hidden commandline interface. You can call sensord as an console application if you have a link (sensors) pointing to the sensors deamon (sensord). IMO that's really intransparent and I don't know any reason using this.

Quoted 5 lines

Further there is a patch introducing a new structure (sensord_arguments). The extern struct sensord_args in args.c now is the place for all the commandline arguments.

A last one replaces the deprecated signal() function by sigaction.

Thanks for doing all this. Please note that I am pretty busy with kernel work these days so it will take some time before I can find the time to review your changes. Thanks for your patience :)

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw
In reply to Andre Prendel
Quoted 18 lines · Jean Delvare

Hi Andre,

Quoted 15 lines · Andre Prendel

Hello Jean,

this patch series fixes some issues caused by the coding style conversion a while ago. Most of them are deep indentation levels and the related long lines.

Another patch removes the hidden commandline interface. You can call sensord as an console application if you have a link (sensors) pointing to the sensors deamon (sensord). IMO that's really intransparent and I don't know any reason using this.

Further there is a patch introducing a new structure (sensord_arguments). The extern struct sensord_args in args.c now is the place for all the commandline arguments.

Quoted 5 lines
Quoted 1 line

A last one replaces the deprecated signal() function by sigaction.

Thanks for doing all this. Please note that I am pretty busy with kernel work these days so it will take some time before I can find the time to review your changes. Thanks for your patience :)

Take your time :)

Andre

Quoted 3 lines
Signature · 2 lines
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors