Skip to contentSkip to conversation

IP32 power button fix for 2.6.30

PATCH In review Andrew Randrianasulu 3 participants 3 messages May 14, 2009 – May 15, 2009 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IP32 power button fix for 2.6.30

I think i run into same sort of problem, as described here:

http://lkml.org/lkml/2009/4/16/24
http://lkml.org/lkml/2009/4/14/94

(in my case it was hang after pressing O2's power button)

this patch fixes it:

----

arch/mips/sgi-ip32/ip32-reset.c +1 -1
index b6cab08..667da93 100644
@@ -145,7 +145,7 @@ static irqreturn_t ip32_rtc_int(int irq, void *dev_id)
                        "%s: RTC IRQ without RTC_IRQF\n", __func__);
        }
        /* Wait until interrupt goes away */
-       disable_irq(MACEISA_RTC_IRQ);
+       disable_irq_nosync(MACEISA_RTC_IRQ);
        init_timer(&debounce_timer);
        debounce_timer.function = debounce;
        debounce_timer.expires = jiffies + 50;

----

tested with 2.6.30-rc5 mainline (linux-mips.org tree was also affected)

#1 lore raw
Quoted 18 lines · Andrew Randrianasulu

X-Mailer: YahooMailClassic/5.2.20 YahooMailWebService/0.7.289.1

I think i run into same sort of problem, as described here:

http://lkml.org/lkml/2009/4/16/24
http://lkml.org/lkml/2009/4/14/94

(in my case it was hang after pressing O2's power button)

this patch fixes it:

----

arch/mips/sgi-ip32/ip32-reset.c +0 -0
index b6cab08..667da93 100644

arch/mips/sgi-ip32/ip32-reset.c static irqreturn_t ip32_rtc_int(int irq, void *dev_id) · line 151

Quoted 8 lines
arch/mips/sgi-ip32/ip32-reset.c +1 -1
@@ -145,7 +145,7 @@ static irqreturn_t ip32_rtc_int(int irq, void *dev_id)
                        "%s: RTC IRQ without RTC_IRQF\n", __func__);
        }
        /* Wait until interrupt goes away */
-       disable_irq(MACEISA_RTC_IRQ);
+       disable_irq_nosync(MACEISA_RTC_IRQ);
        init_timer(&debounce_timer);
        debounce_timer.function = debounce;
        debounce_timer.expires = jiffies + 50;

- no Signed-off-by: line
- whitespace garbled. Use a proper mail client such as /bin/mail ;-)

Grumblingly applied,

Ralf

#2 lore raw
Quoted 1 line · Ralf Baechle

Use a proper mail client such as /bin/mail ;-)

Err... Maybe it's still too hard to not wrap /usr/bin/git-send-email around /bin/mail ;-)

Dmitri