Skip to contentSkip to conversation

checkpatch: false positives for __.*const

DISCUSSION Wolfram Sang 1 participant 1 message Jun 12, 2009

lore
Share & tools
lore
#0 lore raw

Hi,

init.h defines some attributes starting with '__' and ending with const, like '__devinitconst'. They produce false positives with checkpatch:

ERROR: "fooconst bar" should be "foo const bar"
#154: FILE: drivers/uio/uio_of_genirq.c:70:
+static const struct of_device_id __devinitconst uio_of_genirq_match[] = {

like caused by this patch:

http://patchwork.kernel.org/patch/29664/

I investigated a bit but I am not sure if this should be fixed in the regexp responsible for this error or, more general, in $Attributes.

Regards

Wolfram

Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |