Skip to contentSkip to conversation

PCAP regulator driver (for 2.6.32)

PATCH In review Daniel Ribeiro 4 participants 8 messages Jun 27, 2009 – Jul 3, 2009 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 PCAP regulator driver (for 2.6.32)

Add (partial) support for the voltage regulators on the PCAP2 PMIC.

---
Changes since V2: Fix a race condition.

Mark, can you please assert that this only gets merged after Samuel has a chance to merge the set_bits patch? Thanks!

 drivers/regulator/Kconfig          |    7 +
 drivers/regulator/Makefile         |    1 +
 drivers/regulator/pcap-regulator.c |  318 ++++++++++++++++++++++++++++++++++++
 3 files changed, 326 insertions(+), 0 deletions(-)
drivers/regulator/Kconfig +7 -0
index f431779..da7483e 100644
@@ -117,4 +117,11 @@ config REGULATOR_LP3971
 	 Say Y here to support the voltage regulators and convertors
 	 on National Semiconductors LP3971 PMIC
 
+config REGULATOR_PCAP
+	tristate "PCAP2 regulator driver"
+	depends on EZX_PCAP
+	help
+	 This driver provides support for the voltage regulators of the
+	 PCAP2 PMIC.
+
 endif
drivers/regulator/Makefile +1 -0
index 4d762c4..3a9748f 100644
@@ -16,5 +16,6 @@ obj-$(CONFIG_REGULATOR_WM8350) += wm8350-regulator.o
 obj-$(CONFIG_REGULATOR_WM8400) += wm8400-regulator.o
 obj-$(CONFIG_REGULATOR_DA903X)	+= da903x.o
 obj-$(CONFIG_REGULATOR_PCF50633) += pcf50633-regulator.o
+obj-$(CONFIG_REGULATOR_PCAP) += pcap-regulator.o
 
 ccflags-$(CONFIG_REGULATOR_DEBUG) += -DDEBUG
drivers/regulator/pcap-regulator.c new file +318 -0

318 lines not on this page · raw message

Signature · 4 lines
tg: (be2ea62..) ezx/pcap_regulator (depends on: ezx/local/pcap)

-- 
Daniel Ribeiro
Acked-by on v3 1/1
#1 lore raw
Quoted 3 lines · Daniel Ribeiro

Add (partial) support for the voltage regulators on the PCAP2 PMIC.

Looks good.

Quoted 2 lines

Mark, can you please assert that this only gets merged after Samuel has a chance to merge the set_bits patch? Thanks!

It's Liam who manages the regulator tree, though given the set_bits() patch perhaps this one might end up getting merged via the MFD tree (or both via the regulator tree).

#2 lore raw

Em Sáb, 2009-06-27 às 11:51 +0100, Mark Brown escreveu:

Quoted 8 lines · Daniel Ribeiro
Quoted 3 lines

Add (partial) support for the voltage regulators on the PCAP2 PMIC.

Looks good.

Thanks.

Quoted 6 lines
Quoted 2 lines

Mark, can you please assert that this only gets merged after Samuel has a chance to merge the set_bits patch? Thanks!

It's Liam who manages the regulator tree, though given the set_bits() patch perhaps this one might end up getting merged via the MFD tree (or both via the regulator tree).

I prefer the set_bits() patch going through the MFD tree. I sent some other fixes, and a patch to solve a similar race issue for the ADC/TS driver.

Ideally, Samuel would push the PCAP patches on -rc phase, so the sub-drivers can all be merged through the respective subsystem trees on the .32 merge window.

Signature · 1 line
Daniel Ribeiro
#3 lore raw
Quoted 15 lines · Daniel Ribeiro

Em Sáb, 2009-06-27 às 11:51 +0100, Mark Brown escreveu:

Quoted 8 lines · Daniel Ribeiro
Quoted 3 lines

Add (partial) support for the voltage regulators on the PCAP2 PMIC.

Looks good.

Thanks.

Quoted 3 lines
Quoted 2 lines

Mark, can you please assert that this only gets merged after Samuel has a chance to merge the set_bits patch? Thanks!

Quoted 8 lines
Quoted 3 lines

It's Liam who manages the regulator tree, though given the set_bits() patch perhaps this one might end up getting merged via the MFD tree (or both via the regulator tree).

I prefer the set_bits() patch going through the MFD tree. I sent some other fixes, and a patch to solve a similar race issue for the ADC/TS driver.

Is this a runtime or build time dependency for this patch ? I'm thinking about not breaking -next builds.

Quoted 4 lines

Ideally, Samuel would push the PCAP patches on -rc phase, so the sub-drivers can all be merged through the respective subsystem trees on the .32 merge window.

I'm sure Samuel will give me a kick when he pushes mfd for .32.

Liam

#4 lore raw
Quoted 20 lines · Liam Girdwood
Quoted 19 lines · Daniel Ribeiro

Em Sáb, 2009-06-27 às 11:51 +0100, Mark Brown escreveu:

Quoted 8 lines · Daniel Ribeiro
Quoted 3 lines

Add (partial) support for the voltage regulators on the PCAP2 PMIC.

Looks good.

Thanks.

Quoted 6 lines
Quoted 2 lines

Mark, can you please assert that this only gets merged after Samuel has a chance to merge the set_bits patch? Thanks!

It's Liam who manages the regulator tree, though given the set_bits() patch perhaps this one might end up getting merged via the MFD tree (or both via the regulator tree).

Quoted 7 lines
Quoted 4 lines

I prefer the set_bits() patch going through the MFD tree. I sent some other fixes, and a patch to solve a similar race issue for the ADC/TS driver.

Is this a runtime or build time dependency for this patch ? I'm thinking about not breaking -next builds.

Ah, just seen your earlier patch. Looks like we need this to build.

Liam

#5 lore raw
In reply to Daniel Ribeiro

Hi Daniel,

Quoted 19 lines · Daniel Ribeiro

Em Sáb, 2009-06-27 às 11:51 +0100, Mark Brown escreveu:

Quoted 8 lines · Daniel Ribeiro
Quoted 3 lines

Add (partial) support for the voltage regulators on the PCAP2 PMIC.

Looks good.

Thanks.

Quoted 6 lines
Quoted 2 lines

Mark, can you please assert that this only gets merged after Samuel has a chance to merge the set_bits patch? Thanks!

It's Liam who manages the regulator tree, though given the set_bits() patch perhaps this one might end up getting merged via the MFD tree (or both via the regulator tree).

Quoted 7 lines

I prefer the set_bits() patch going through the MFD tree. I sent some other fixes, and a patch to solve a similar race issue for the ADC/TS driver.

Ideally, Samuel would push the PCAP patches on -rc phase, so the sub-drivers can all be merged through the respective subsystem trees on the .32 merge window.

If that's ok with Liam, I'll take the regulator patch. Most of the pcap patches are not rc material, so they will be merged along with the regulator driver with the next merge window.

Liam, if you're fine with this patch, could you please SOB it ? Thanks.

Cheers,
Samuel.

Quoted 2 lines
Signature · 1 line
Daniel Ribeiro
Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#6 lore raw
Quoted 5 lines · Samuel Ortiz

Hi Daniel,

Quoted 1 line · Daniel Ribeiro
Quoted 8 lines
Quoted 3 lines

Ideally, Samuel would push the PCAP patches on -rc phase, so the sub-drivers can all be merged through the respective subsystem trees on the .32 merge window.

If that's ok with Liam, I'll take the regulator patch. Most of the pcap patches are not rc material, so they will be merged along with the regulator driver with the next merge window.

Liam, if you're fine with this patch, could you please SOB it ? Thanks.

Thanks!

Liam

#7 lore raw
Quoted 9 lines · Liam Girdwood
Quoted 8 lines · Samuel Ortiz

Hi Daniel,

Quoted 4 lines · Daniel Ribeiro

Ideally, Samuel would push the PCAP patches on -rc phase, so the sub-drivers can all be merged through the respective subsystem trees on the .32 merge window.

Quoted 7 lines
Quoted 5 lines

If that's ok with Liam, I'll take the regulator patch. Most of the pcap patches are not rc material, so they will be merged along with the regulator driver with the next merge window.

Liam, if you're fine with this patch, could you please SOB it ? Thanks.

Thanks, patch applied to my for-next branch.

Cheers,
Samuel.

Quoted 5 lines

Thanks!

Liam

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/