acpi processor: simplify needlessly complex printk

Why use three printk statements if one will do?

Signed-off-by Frans Pop<[email protected]>

drivers/acpi/processor_core.c +5 -7

index 84e0f3c..b8fb74a 100644
@@ -772,12 +772,11 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device)
  	if (result)
  		printk(KERN_ERR PREFIX "Create sysfs link\n");
 
-	if (pr->flags.throttling) {
-		printk(KERN_INFO PREFIX "%s [%s] (supports",
-		       acpi_device_name(device), acpi_device_bid(device));
-		printk(" %d throttling states", pr->throttling.state_count);
-		printk(")\n");
-	}
+	if (pr->flags.throttling)
+		printk(KERN_INFO PREFIX
+			"%s [%s] (supports %d throttling states)\n",
+			acpi_device_name(device), acpi_device_bid(device),
+			pr->throttling.state_count);
 
        end:
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Would it be better to capitalize the S and add a period at the end, or does it not matter?

Quoted 3 lines · Justin P. Mattock

Would it be better to capitalize the S and add a period at the end, or does it not matter?

Kernel messages are in general not sentences.

I thought of removing the parenteses, but if you look at the context of the message then that only makes sense if other messages are modified at the same time. The messages below appear together for my system and their consistency could definitely be improved, but IMO that's better done in a separate patch.

ACPI: CPU0 (power states: C1[C1] C2[C2] C3[C3]) processor LNXCPU:00: registered as cooling_device7
ACPI: Processor [CPU0] (supports 8 throttling states)