Skip to contentSkip to conversation

acpi processor: simplify needlessly complex printk

PATCH RESEND New Frans Pop 1 participant 1 message Aug 17, 2009 ACPI

lore
Share & tools
lore

Frans Pop

author
#0 lore raw

PATCH RESEND 1/1 acpi processor: simplify needlessly complex printk

Why use three printk statements if one will do?
Also makes it easier to grep for the string.

drivers/acpi/processor_core.c +5 -6
index 84e0f3c..b8fb74a 100644
@@ -772,12 +772,11 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device)
 	if (result)
 		printk(KERN_ERR PREFIX "Create sysfs link\n");
 
-	if (pr->flags.throttling) {
-		printk(KERN_INFO PREFIX "%s [%s] (supports",
-		       acpi_device_name(device), acpi_device_bid(device));
-		printk(" %d throttling states", pr->throttling.state_count);
-		printk(")\n");
-	}
+	if (pr->flags.throttling)
+		printk(KERN_INFO PREFIX
+			"%s [%s] (supports %d throttling states)\n",
+			acpi_device_name(device), acpi_device_bid(device),
+			pr->throttling.state_count);
 
       end: