Skip to contentSkip to conversation

powerpc/85xx: Don't scan for TBI PHY addresses on MPC8569E-MDS boards

PATCH Applied Anton Vorontsov 3 participants 3 messages Jul 1, 2009 – Jul 30, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/85xx: Don't scan for TBI PHY addresses on MPC8569E-MDS boards

Sometimes (e.g. when there are no UEMs attached to a board) fsl_pq_mdio_find_free() fails to find a spare address for a TBI PHY, this is because get_phy_id() returns bogus 0x0000ffff values (0xffffffff is expected), and therefore mdio bus probing fails with the following message:

fsl-pq_mdio: probe of e0082120.mdio failed with error -16

And obviously ethernet doesn't work after this.

This patch solves the problem by adding tbi-phy node into mdio node, so that we won't scan for spare addresses, we'll just use a fixed one.

---
 arch/powerpc/boot/dts/mpc8569mds.dts |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/powerpc/boot/dts/mpc8569mds.dts +4 -0
index 2577f37..baa4ac7 100644
@@ -502,6 +502,10 @@
 				reg = <0x6>;
 				device_type = "ethernet-phy";
 			};
+			tbi-phy@11 {
+				reg = <0x11>;
+				device_type = "tbi-phy";
+			};
 		};
 		mdio@3520 {
 			#address-cells = <1>;
Signature · 1 line
1.6.3.3
#1 lore raw
Quoted 6 lines · Anton Vorontsov

Sometimes (e.g. when there are no UEMs attached to a board) fsl_pq_mdio_find_free() fails to find a spare address for a TBI PHY, this is because get_phy_id() returns bogus 0x0000ffff values (0xffffffff is expected), and therefore mdio bus probing fails with the following message:

Quoted 8 lines

fsl-pq_mdio: probe of e0082120.mdio failed with error -16

And obviously ethernet doesn't work after this.

This patch solves the problem by adding tbi-phy node into mdio node, so that we won't scan for spare addresses, we'll just use a fixed one.

Kumar,

I believe this patch is suitable for 2.6.31, no?

Thanks,

Quoted 25 lines
---
 arch/powerpc/boot/dts/mpc8569mds.dts |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/powerpc/boot/dts/mpc8569mds.dts +4 -0
index 2577f37..baa4ac7 100644
@@ -502,6 +502,10 @@
 				reg = <0x6>;
 				device_type = "ethernet-phy";
 			};
+			tbi-phy@11 {
+				reg = <0x11>;
+				device_type = "tbi-phy";
+			};
 		};
 		mdio@3520 {
 			#address-cells = <1>;
Signature · 5 lines
1.6.3.3
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev
Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2
Applied
#2 lore raw
In reply to Anton Vorontsov
Quoted 10 lines · Anton Vorontsov

Sometimes (e.g. when there are no UEMs attached to a board) fsl_pq_mdio_find_free() fails to find a spare address for a TBI PHY, this is because get_phy_id() returns bogus 0x0000ffff values (0xffffffff is expected), and therefore mdio bus probing fails with the following message:

fsl-pq_mdio: probe of e0082120.mdio failed with error -16

And obviously ethernet doesn't work after this.

Quoted 7 lines

This patch solves the problem by adding tbi-phy node into mdio node, so that we won't scan for spare addresses, we'll just use a fixed one.

---
arch/powerpc/boot/dts/mpc8569mds.dts | 4 ++++

1 files changed, 4 insertions(+), 0 deletions(-)

applied to merge

- k