pxa: add clock for system bus 2 arbiter
PATCH 1/2 pxa: add clock for system bus 2 arbiter
This clock is needed for systems using the USB2 device unit or the 2d graphics accelerator.
--- include/asm-arm/arch-pxa/pxa-regs.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
include/asm-arm/arch-pxa/pxa-regs.h +1 -0
@@ -1952,6 +1952,7 @@ typedef void (*ExcpHndlr) (void) ;#define CKENA_2_USBHOST (1 << 2)/* USB Host Unit Clock Enable */ #define CKENA_1_LCD (1 << 1)/* LCD Unit Clock Enable */ +#define CKENB_9_SYSBUS2 (1 << 9)/* System bus 2 */ #define CKENB_8_1WIRE ((1 << 8) + 32)/* One Wire Interface Unit Clock Enable */ #define CKENB_7_GPIO ((1 << 7) + 32)/* GPIO Clock Enable */ #define CKENB_6_IRQ ((1 << 6) + 32)/* Interrupt Controller Clock Enable */
Signature · 1 line
1.6.3.1
PATCH 1/2 pxa: add clock for system bus 2 arbiter
ping?
Quoted 31 lines · Daniel Mack
From: Daniel Mack <[email protected]>
To: u-boot at lists.denx.de
Cc: Daniel Mack <[email protected]>
Subject: [PATCH 1/2] pxa: add clock for system bus 2 arbiter
Date: Tue, 23 Jun 2009 17:30:04 +0200
Message-Id: <[email protected]>
X-Mailer: git-send-email 1.6.3.1This clock is needed for systems using the USB2 device unit or the 2d graphics accelerator.
Signed-off-by Daniel Mack <[email protected]>--- include/asm-arm/arch-pxa/pxa-regs.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)include/asm-arm/arch-pxa/pxa-regs.h +1
-0@@ -1952,6 +1952,7 @@ typedef void (*ExcpHndlr) (void) ;#define CKENA_2_USBHOST (1 << 2)/* USB Host Unit Clock Enable */ #define CKENA_1_LCD (1 << 1)/* LCD Unit Clock Enable */ +#define CKENB_9_SYSBUS2 (1 << 9)/* System bus 2 */ #define CKENB_8_1WIRE ((1 << 8) + 32)/* One Wire Interface Unit Clock Enable */ #define CKENB_7_GPIO ((1 << 7) + 32)/* GPIO Clock Enable */ #define CKENB_6_IRQ ((1 << 6) + 32)/* Interrupt Controller Clock Enable */ Signature · 1 line
1.6.3.1
PATCH 1/2 pxa: add clock for system bus 2 arbiter
Hello Jean-Christophe,
2009/7/9 Daniel Mack <[email protected]>:
Quoted 15 lines
ping?
Quoted 12 lines · Daniel Mack
From: Daniel Mack <[email protected]>
To: u-boot at lists.denx.de
Cc: Daniel Mack <[email protected]>
Subject: [PATCH 1/2] pxa: add clock for system bus 2 arbiter
Date: Tue, 23 Jun 2009 17:30:04 +0200
Message-Id: <[email protected]>
X-Mailer: git-send-email 1.6.3.1This clock is needed for systems using the USB2 device unit or the 2d graphics accelerator.
Signed-off-by Daniel Mack <[email protected]>
I guess this patch should go in your tree.
Can you please take a look at it?
Remy
PATCH 2/2 pxa: fix CKEN_B register bits
In reply to Daniel MackThe current defition for CKEN_B register bits is nonsense. Adding 32 to the shifted value is equal to '| (1 << 5)', and this bit is marked 'reserved' in the PXA docs.
--- include/asm-arm/arch-pxa/pxa-regs.h | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
include/asm-arm/arch-pxa/pxa-regs.h +6 -6
@@ -1953,12 +1953,12 @@ typedef void (*ExcpHndlr) (void) ;#define CKENA_1_LCD (1 << 1)/* LCD Unit Clock Enable */ #define CKENB_9_SYSBUS2 (1 << 9)/* System bus 2 */ -#define CKENB_8_1WIRE ((1 << 8) + 32)/* One Wire Interface Unit Clock Enable */ -#define CKENB_7_GPIO ((1 << 7) + 32)/* GPIO Clock Enable */ -#define CKENB_6_IRQ ((1 << 6) + 32)/* Interrupt Controller Clock Enable */ -#define CKENB_4_I2C ((1 << 4) + 32)/* I2C Unit Clock Enable */ -#define CKENB_1_PWM1 ((1 << 1) + 32)/* PWM2 & PWM3 Clock Enable */ -#define CKENB_0_PWM0 ((1 << 0) + 32)/* PWM0 & PWM1 Clock Enable */ +#define CKENB_8_1WIRE (1 << 8)/* One Wire Interface Unit Clock Enable */ +#define CKENB_7_GPIO (1 << 7)/* GPIO Clock Enable */ +#define CKENB_6_IRQ (1 << 6)/* Interrupt Controller Clock Enable */ +#define CKENB_4_I2C (1 << 4)/* I2C Unit Clock Enable */ +#define CKENB_1_PWM1 (1 << 1)/* PWM2 & PWM3 Clock Enable */ +#define CKENB_0_PWM0 (1 << 0)/* PWM0 & PWM1 Clock Enable */ #else /* if defined CONFIG_CPU_MONAHANS */
Signature · 1 line
1.6.3.1
PATCH 2/2 pxa: fix CKEN_B register bits
ping?
Quoted 43 lines · Daniel Mack
From: Daniel Mack <[email protected]>
To: u-boot at lists.denx.de
Cc: Daniel Mack <[email protected]>
Subject: [PATCH 2/2] pxa: fixCKEN_Bregister bits
Date: Tue, 23 Jun 2009 17:30:05 +0200
Message-Id: <[email protected]>
X-Mailer: git-send-email 1.6.3.1The current defition for
CKEN_Bregister bits is nonsense. Adding 32 to the shifted value is equal to '| (1 << 5)', and this bit is marked 'reserved' in the PXA docs.Signed-off-by Daniel Mack <[email protected]>--- include/asm-arm/arch-pxa/pxa-regs.h | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)include/asm-arm/arch-pxa/pxa-regs.h +6
-6@@ -1953,12 +1953,12 @@ typedef void (*ExcpHndlr) (void) ;#define CKENA_1_LCD (1 << 1)/* LCD Unit Clock Enable */ #define CKENB_9_SYSBUS2 (1 << 9)/* System bus 2 */ -#define CKENB_8_1WIRE ((1 << 8) + 32)/* One Wire Interface Unit Clock Enable */ -#define CKENB_7_GPIO ((1 << 7) + 32)/* GPIO Clock Enable */ -#define CKENB_6_IRQ ((1 << 6) + 32)/* Interrupt Controller Clock Enable */ -#define CKENB_4_I2C ((1 << 4) + 32)/* I2C Unit Clock Enable */ -#define CKENB_1_PWM1 ((1 << 1) + 32)/* PWM2 & PWM3 Clock Enable */ -#define CKENB_0_PWM0 ((1 << 0) + 32)/* PWM0 & PWM1 Clock Enable */ +#define CKENB_8_1WIRE (1 << 8)/* One Wire Interface Unit Clock Enable */ +#define CKENB_7_GPIO (1 << 7)/* GPIO Clock Enable */ +#define CKENB_6_IRQ (1 << 6)/* Interrupt Controller Clock Enable */ +#define CKENB_4_I2C (1 << 4)/* I2C Unit Clock Enable */ +#define CKENB_1_PWM1 (1 << 1)/* PWM2 & PWM3 Clock Enable */ +#define CKENB_0_PWM0 (1 << 0)/* PWM0 & PWM1 Clock Enable */ #else /* if defined CONFIG_CPU_MONAHANS */ Signature · 1 line
1.6.3.1