Skip to contentSkip to conversation

ppc4xx: Add 405EP based PMC405DE board

PATCH Superseded Matthias Fuchs 3 participants 18 messages Jul 21, 2009 – Jul 22, 2009 Kbuild

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

patch v2:
- coding style cleanup
- added CONFIG_PHY1_ADDR
patch v3:
- refactor PLL reconfiguration code
- beautify some one-line-functions
patch v4:
- remove 'sbe' command
- add CONFIG_CMD_CHIP_CONFIG support
- use ppc4xx_gpio struct for GPIO access
- use set/clrbits_be32 to modify GPIO registers
- add CPLD register struct
patch v5:
- add patch history to commit message

---
 MAINTAINERS                      |    1 +
 MAKEALL                          |    1 +
 Makefile                         |    3 +
 board/esd/pmc405de/Makefile      |   53 ++++
 board/esd/pmc405de/chip_config.c |   47 ++++
 board/esd/pmc405de/config.mk     |   23 ++
 board/esd/pmc405de/pmc405de.c    |  521 ++++++++++++++++++++++++++++++++++++++
 board/esd/pmc405de/u-boot.lds    |  133 ++++++++++
 include/configs/PMC405DE.h       |  378 +++++++++++++++++++++++++++
 9 files changed, 1160 insertions(+), 0 deletions(-)
 create mode 100644 board/esd/pmc405de/Makefile
 create mode 100644 board/esd/pmc405de/chip_config.c
 create mode 100644 board/esd/pmc405de/config.mk
 create mode 100644 board/esd/pmc405de/pmc405de.c
 create mode 100644 board/esd/pmc405de/u-boot.lds
 create mode 100644 include/configs/PMC405DE.h
MAINTAINERS +1 -0
index 575a7ec..484040c 100644
@@ -171,6 +171,7 @@ Matthias Fuchs <[email protected]>
 	PCI405		PPC405GP
 	PLU405		PPC405EP
 	PMC405		PPC405GP
+	PMC405DE	PPC405EP
 	PMC440		PPC440EPx
 	VOH405		PPC405EP
 	VOM405		PPC405EP
MAKEALL +1 -0
index 020ff73..f36a5fd 100755
@@ -237,6 +237,7 @@ LIST_4xx="		\
 	PIP405		\
 	PLU405		\
 	PMC405		\
+	PMC405DE	\
 	PMC440		\
 	PPChameleonEVB	\
 	quad100hd	\
Makefile +3 -0
index 090e645..a5d397b 100644
@@ -1492,6 +1492,9 @@ PLU405_config:	unconfig
 PMC405_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc405 esd
 
+PMC405DE_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc405de esd
+
 PMC440_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc440 esd
 
board/esd/pmc405de/Makefile new file +53 -0

53 lines not on this page · raw message

board/esd/pmc405de/chip_config.c new file +47 -0

47 lines not on this page · raw message

board/esd/pmc405de/config.mk new file +23 -0
new file mode 100644
index 0000000..ae855dc
@@ -0,0 +1,23 @@
+#
+# (C) Copyright 2000
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+TEXT_BASE = 0xFFFC0000
board/esd/pmc405de/pmc405de.c new file +521 -0

521 lines not on this page · raw message

board/esd/pmc405de/u-boot.lds new file +133 -0

133 lines not on this page · raw message

include/configs/PMC405DE.h new file +378 -0

378 lines not on this page · raw message

Signature · 1 line
1.6.1
#1 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Dear Matthias Fuchs,

Quoted 6 lines · In message <[email protected]> you wrote:

patch v2:
- coding style cleanup
- added CONFIG_PHY1_ADDR
patch v3:
- refactor PLL reconfiguration code
- beautify some one-line-functions

Quoted 8 lines

patch v4:
- remove 'sbe' command
- add CONFIG_CMD_CHIP_CONFIG support
- use ppc4xx_gpio struct for GPIO access
- use set/clrbits_be32 to modify GPIO registers
- add CPLD register struct
patch v5:
- add patch history to commit message

Please get rid of this. This has NO place in the commit message. Such comments go _below_ the "---" line.

Quoted 157 lines
---
 MAINTAINERS                      |    1 +
 MAKEALL                          |    1 +
 Makefile                         |    3 +
 board/esd/pmc405de/Makefile      |   53 ++++
 board/esd/pmc405de/chip_config.c |   47 ++++
 board/esd/pmc405de/config.mk     |   23 ++
 board/esd/pmc405de/pmc405de.c    |  521 ++++++++++++++++++++++++++++++++++++++
 board/esd/pmc405de/u-boot.lds    |  133 ++++++++++
 include/configs/PMC405DE.h       |  378 +++++++++++++++++++++++++++
 9 files changed, 1160 insertions(+), 0 deletions(-)
 create mode 100644 board/esd/pmc405de/Makefile
 create mode 100644 board/esd/pmc405de/chip_config.c
 create mode 100644 board/esd/pmc405de/config.mk
 create mode 100644 board/esd/pmc405de/pmc405de.c
 create mode 100644 board/esd/pmc405de/u-boot.lds
 create mode 100644 include/configs/PMC405DE.h
MAINTAINERS +1 -0
index 575a7ec..484040c 100644
@@ -171,6 +171,7 @@ Matthias Fuchs <[email protected]>
 	PCI405		PPC405GP
 	PLU405		PPC405EP
 	PMC405		PPC405GP
+	PMC405DE	PPC405EP
 	PMC440		PPC440EPx
 	VOH405		PPC405EP
 	VOM405		PPC405EP
MAKEALL +1 -0
index 020ff73..f36a5fd 100755
@@ -237,6 +237,7 @@ LIST_4xx="		\
 	PIP405		\
 	PLU405		\
 	PMC405		\
+	PMC405DE	\
 	PMC440		\
 	PPChameleonEVB	\
 	quad100hd	\
Makefile +3 -0
index 090e645..a5d397b 100644
@@ -1492,6 +1492,9 @@ PLU405_config:	unconfig
 PMC405_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc405 esd
 
+PMC405DE_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc405de esd
+
 PMC440_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx pmc440 esd
 
board/esd/pmc405de/Makefile new file +53 -0
new file mode 100644
index 0000000..a080649
@@ -0,0 +1,53 @@
+#
+# (C) Copyright 2000-2006
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).a
+
+COBJS-y	= $(BOARD).o
+COBJS-y	+= ../common/cmd_loadpci.o
+COBJS-$(CONFIG_CMD_CHIP_CONFIG) += chip_config.o
+
+COBJS	:= $(COBJS-y)
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(OBJS) $(SOBJS)
+	$(AR) $(ARFLAGS) $@ $(OBJS)
+
+clean:
+	rm -f $(SOBJS) $(OBJS)
+
+distclean:	clean
+	rm -f $(LIB) core *.bak $(obj).depend
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/esd/pmc405de/chip_config.c new file +35 -0
new file mode 100644
index 0000000..f1cafc1
@@ -0,0 +1,47 @@
+/*
+ * (C) Copyright 2008-2009
+ * Stefan Roese, DENX Software Engineering, sr at denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+
+#include <common.h>
+#include <asm/ppc4xx_config.h>
+
+struct ppc4xx_config ppc4xx_config_val[] = {
+
+	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
+	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",

board/esd/pmc405de/chip_config.c line 45

Quoted 10 lines
board/esd/pmc405de/chip_config.c new file +10 -0
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
+	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
+};

Indentation by TAB , please.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Whoever undertakes to set himself up as a judge of Truth  and  Know-
ledge is shipwrecked by the laughter of the gods."  - Albert Einstein
#2 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Hi Wolfgang,

Quoted 12 lines · On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
Quoted 12 lines
board/esd/pmc405de/chip_config.c new file +12 -0
+struct ppc4xx_config ppc4xx_config_val[] = {
+
+	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
+	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
Quoted 8 lines

board/esd/pmc405de/chip_config.c line 45

Quoted 6 lines
board/esd/pmc405de/chip_config.c new file +6 -0
+	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
+};

Indentation by TAB , please.

I don't see a problem here. The code is aligned to the lines above via spaces (< 8 spaces). Example:

	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
            ^^^^

The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with it.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================

#3 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Quoted 27 lines · Stefan Roese

Hi Wolfgang,

Quoted 12 lines · On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
Quoted 12 lines
board/esd/pmc405de/chip_config.c new file +12 -0
+struct ppc4xx_config ppc4xx_config_val[] = {
+
+	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
+	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
Quoted 8 lines

board/esd/pmc405de/chip_config.c line 45

Quoted 6 lines
board/esd/pmc405de/chip_config.c new file +6 -0
+	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
+};

Indentation by TAB , please.

I don't see a problem here. The code is aligned to the lines above via spaces (< 8 spaces). Example:

Quoted 6 lines
	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
            ^^^^

The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with it.

Yes, I think the identation is correct also. The only think that might be improved is one empty line that might be too much. And the spaces before and after the curly braces.

These all should not be a reason for stopping this patch. Please let it make it's way into Stefan's repo.

Matthias

Quoted 15 lines

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 13 lines
-------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
Head of System Design

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Phone: +49-511-37298-0 - Fax: +49-511-37298-68
Please visit our homepage http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Gesch?ftsf?hrer: Klaus Detering, Dr. Werner Schulze
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------
#4 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Quoted 9 lines · On Wednesday 22 July 2009 10:23:11 Matthias Fuchs wrote:
Quoted 9 lines
Quoted 1 line

Indentation by TAB , please.

I don't see a problem here. The code is aligned to the lines above via spaces (< 8 spaces). Example:

	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
            ^^^^
Quoted 6 lines
Quoted 2 lines

The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with it.

Yes, I think the identation is correct also. The only think that might be improved is one empty line that might be too much. And the spaces before and after the curly braces.

checkpatch will generate a warning if you don't have these spaces around the curly braces.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#5 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

In reply to Stefan Roese

Dear Stefan Roese,

Quoted 24 lines · In message <[email protected]> you wrote:

Hi Wolfgang,

Quoted 12 lines · On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
Quoted 12 lines
board/esd/pmc405de/chip_config.c new file +12 -0
+struct ppc4xx_config ppc4xx_config_val[] = {
+
+	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
+	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
Quoted 8 lines

board/esd/pmc405de/chip_config.c line 45

Quoted 6 lines
board/esd/pmc405de/chip_config.c new file +6 -0
+	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
+};

Indentation by TAB , please.

Quoted 2 lines

I don't see a problem here. The code is aligned to the lines above via spaces (< 8 spaces). Example:

The braces should be indented by TABs.

Quoted 6 lines
	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
            ^^^^

The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with it.

Indentation is not done by TABs, but by TABs + spaces, and this is wrong.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Fascinating, a totally parochial attitude.
	-- Spock, "Metamorphosis", stardate 3219.8
#6 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Quoted 11 lines · On Wednesday 22 July 2009 11:41:45 Wolfgang Denk wrote:
Quoted 4 lines
Quoted 1 line

Indentation by TAB , please.

I don't see a problem here. The code is aligned to the lines above via spaces (< 8 spaces). Example:

The braces should be indented by TABs.

Quoted 4 lines
	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
            ^^^^
Quoted 5 lines
Quoted 2 lines

The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with it.

Indentation is not done by TABs, but by TABs + spaces, and this is wrong.

Why should this be wrong? This alignment looks better IMHO. Please allow the developers a little bit of freedom.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#7 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Dear Stefan Roese,

Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 3 lines

Indentation is not done by TABs, but by TABs + spaces, and this is wrong.

Why should this be wrong? This alignment looks better IMHO. Please allow the developers a little bit of freedom.

"Documentation/CodingStyle":

Tabs are 8 characters, and thus indentations are also 8 characters. There are heretic movements that try to make indentations 4 (or even 2!) characters deep, and that is akin to trying to define the value of PI to be 3.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I wish Captain Vimes were here. He wouldn't have  known  what  to  do
either, but he's got a much better vocabulary to be baffled in.
                                 - Terry Pratchett, _Guards! Guards!_
#8 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Quoted 6 lines · On Wednesday 22 July 2009 12:34:44 Wolfgang Denk wrote:
Quoted 5 lines
Quoted 2 lines

Indentation is not done by TABs, but by TABs + spaces, and this is wrong.

Why should this be wrong? This alignment looks better IMHO. Please allow the developers a little bit of freedom.

Quoted 6 lines

"Documentation/CodingStyle":

Tabs are 8 characters, and thus indentations are also 8 characters. There are heretic movements that try to make indentations 4 (or even 2!) characters deep, and that is akin to trying to define the value of PI to be 3.

Fuck Ack. But: This has nothing to do with the problem we are discussing here. I was talking about alignment and not indentation. Do you want to forbid people use alignment at all?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#9 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Dear Stefan Roese,

Quoted 4 lines · In message <[email protected]> you wrote:

Fuck Ack. But: This has nothing to do with the problem we are discussing here. I was talking about alignment and not indentation. Do you want to forbid people use alignment at all?

Please do me (and yourself, and us all) a favour and just read the rules, and then follow them, instead of wasting our all time.

See http://www.denx.de/wiki/U-Boot/CodingStyle:

Use TAB characters for indentation and vertical alignment, not spaces.

Anything else?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As of 1992, they're called European Economic Community fries.
#10 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Quoted 2 lines · On Wednesday 22 July 2009 13:08:30 Wolfgang Denk wrote:

Please do me (and yourself, and us all) a favour and just read the rules, and then follow them, instead of wasting our all time.

I'm pretty sure that I'm doing at least some developers a favour, in discussing this issue. It's annoying not being able to use a coding style that's accepted for example in the Linux kernel all the time.

But ok, I'm stopping here as well.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#11 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

In reply to Wolfgang Denk

Dear Wolfgang,

Quoted 27 lines · Wolfgang Denk

Dear Stefan Roese,

Quoted 24 lines · In message <[email protected]> you wrote:

Hi Wolfgang,

Quoted 20 lines · On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote:
Quoted 8 lines
board/esd/pmc405de/chip_config.c new file +8 -0
+struct ppc4xx_config ppc4xx_config_val[] = {
+
+	{ "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },
+	{ "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",

board/esd/pmc405de/chip_config.c line 45

Quoted 10 lines
board/esd/pmc405de/chip_config.c new file +10 -0
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } },
+	{ "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
+	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+	    0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } },
+};

Indentation by TAB , please.

Quoted 4 lines
Quoted 2 lines

I don't see a problem here. The code is aligned to the lines above via spaces (< 8 spaces). Example:

The braces should be indented by TABs.

Can you please post a suggestion you you would like to this these lines indented. When I try to replace the spaces by TABs, the code looks very ugly and unreadable and I don't like that.

So perhaps I missed what you mean and I have to reconfigure my emacs autoindent mode to wd'mode.

Matthias

Quoted 15 lines
Quoted 7 lines
	  { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
	    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
            ^^^^

The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with it.

Indentation is not done by TABs, but by TABs + spaces, and this is wrong.

Best regards,

Wolfgang Denk

#12 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Dear Matthias Fuchs,

Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 2 lines

The braces should be indented by TABs.

Can you please post a suggestion you you would like to this these lines indented. When I try to replace the spaces by TABs, the code looks very ugly and unreadable and I don't like that.

So you want me to do the editing for you? May I send my invoice to esd's address?

Quoted 2 lines

So perhaps I missed what you mean and I have to reconfigure my emacs autoindent mode to wd'mode.

I don't understand what's so difficult about it; just indent by TABs:

struct ppc4xx_config ppc4xx_config_val[] = {
	{
		"133",
		"CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
		{
			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00,
		}
	},
	{
		"266",
		"CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
		{
			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00,
		}
	},
	{
		"333",
		"CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
		{
			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00,
		}
	},
};

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Half of the people in the world are below average.
#13 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Quoted 13 lines · On Wednesday 22 July 2009 13:05:56 Wolfgang Denk wrote:

I don't understand what's so difficult about it; just indent by TABs:

struct ppc4xx_config ppc4xx_config_val[] = {
	{
		"133",
		"CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
		{
			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00,
		}
	},

OK, now let's compare your version with ours:

board/esd/pmc405de/chip_config.c line 34

Quoted 5 lines
board/esd/pmc405de/chip_config.c new file +5 -0
+     { "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
+       { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+         0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+         0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+         0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } },

Your version is 10 lines long, ours is 5. That twice as long. I still prefer our version and think this kind of personal freedom should be allowed.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#14 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Dear Stefan Roese,

Quoted 3 lines · In message <[email protected]> you wrote:

Your version is 10 lines long, ours is 5. That twice as long. I still prefer our version and think this kind of personal freedom should be allowed.

Nobody attempts to restrict yoru thoughts or preferences.

But you want to have the patch accepted, and I want you to stick with the CodingStyle. That's all. Full stop.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the beginning, there was nothing, which exploded.
                                - Terry Pratchett, _Lords and Ladies_
#15 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

In reply to Wolfgang Denk
Quoted 18 lines · Wolfgang Denk

Dear Matthias Fuchs,

Quoted 6 lines · In message <[email protected]> you wrote:

patch v2:
- coding style cleanup
- added CONFIG_PHY1_ADDR
patch v3:
- refactor PLL reconfiguration code
- beautify some one-line-functions

Quoted 8 lines

patch v4:
- remove 'sbe' command
- add CONFIG_CMD_CHIP_CONFIG support
- use ppc4xx_gpio struct for GPIO access
- use set/clrbits_be32 to modify GPIO registers
- add CPLD register struct
patch v5:
- add patch history to commit message

Quoted 2 lines

Please get rid of this. This has NO place in the commit message. Such comments go _below_ the "---" line.

Do you want me to resend the posting?

Matthias

#16 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

Quoted 4 lines · On Wednesday 22 July 2009 10:24:33 Matthias Fuchs wrote:
Quoted 3 lines · Wolfgang Denk

Dear Matthias Fuchs,

In message <[email protected]> you

Quoted 15 lines · wrote:
Quoted 15 lines
Quoted 14 lines

patch v2:
- coding style cleanup
- added CONFIG_PHY1_ADDR
patch v3:
- refactor PLL reconfiguration code
- beautify some one-line-functions
patch v4:
- remove 'sbe' command
- add CONFIG_CMD_CHIP_CONFIG support
- use ppc4xx_gpio struct for GPIO access
- use set/clrbits_be32 to modify GPIO registers
- add CPLD register struct
patch v5:
- add patch history to commit message

Quoted 4 lines
Quoted 2 lines

Please get rid of this. This has NO place in the commit message. Such comments go _below_ the "---" line.

Do you want me to resend the posting?

Yes, please.

Thanks.

Viele Gr??e,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#17 lore raw

PATCH v5 1/1 ppc4xx: Add 405EP based PMC405DE board

In reply to Matthias Fuchs

Dear Matthias Fuchs,

Quoted 19 lines · In message <[email protected]> you wrote:
Quoted 18 lines · Wolfgang Denk

Dear Matthias Fuchs,

Quoted 14 lines · In message <[email protected]> you wrote:

patch v2:
- coding style cleanup
- added CONFIG_PHY1_ADDR
patch v3:
- refactor PLL reconfiguration code
- beautify some one-line-functions
patch v4:
- remove 'sbe' command
- add CONFIG_CMD_CHIP_CONFIG support
- use ppc4xx_gpio struct for GPIO access
- use set/clrbits_be32 to modify GPIO registers
- add CPLD register struct
patch v5:
- add patch history to commit message

Quoted 3 lines
Quoted 2 lines

Please get rid of this. This has NO place in the commit message. Such comments go _below_ the "---" line.

Do you want me to resend the posting?

Well, such a cmmit message is definitely not acceptable, so please consider this version rejected.

Please also note that there is still this indentation problem.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nearly everyone is in favor of going  to  heaven  but  too  many  are
hoping  they'll  live  long  enough  to see an easing of the entrance
requirements. Never appeal to a man's "better nature." he  might  not
have one.