Skip to contentSkip to conversation

xen: xen-debug is too noisy

PATCH New Christoph Egger 1 participant 1 message Aug 14, 2009

lore
Share & tools
lore

Christoph Egger

author
#0 lore raw

PATCH 1/1 xen: xen-debug is too noisy

Hi!

On guest MCE read only print debug code when a non-zero value has been read. Xen is too noisy, otherwise.

Signed-off-by Christoph Egger <[email protected]>
Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
xen/arch/x86/cpu/mcheck/mce.c +5 -5
diff -r f4601471c59b xen/arch/x86/cpu/mcheck/mce.c
@@ -685,7 +685,9 @@ int mce_rdmsr(u32 msr, u32 *lo, u32 *hi)
     case MSR_IA32_MCG_STATUS:
         *lo = (u32)d->arch.vmca_msrs.mcg_status;
         *hi = (u32)(d->arch.vmca_msrs.mcg_status >> 32);
-        gdprintk(XENLOG_DEBUG, "MCE: rd MCG_STATUS lo %x hi %x\n", *lo, *hi);
+        if (*lo || *hi)
+            gdprintk(XENLOG_DEBUG,
+                "MCE: rdmsr MCG_STATUS lo %x hi %x\n", *lo, *hi);
         break;
     case MSR_IA32_MCG_CAP:
         *lo = (u32)d->arch.vmca_msrs.mcg_cap;

@@ -710,7 +712,7 @@ int mce_rdmsr(u32 msr, u32 *lo, u32 *hi)
         case MSR_IA32_MC0_CTL:
             *lo = (u32)d->arch.vmca_msrs.mci_ctl[bank];
             *hi = (u32)(d->arch.vmca_msrs.mci_ctl[bank] >> 32);
-            gdprintk(XENLOG_DEBUG, "MCE: rd MC%u_CTL lo %x hi %x\n",
+            gdprintk(XENLOG_DEBUG, "MCE: rdmsr MC%u_CTL lo %x hi %x\n",
                      bank, *lo, *hi);
             break;
         case MSR_IA32_MC0_STATUS:

@@ -729,8 +731,6 @@ int mce_rdmsr(u32 msr, u32 *lo, u32 *hi)
                 else
                     entry = NULL;
             }
-            if ( !entry )
-                gdprintk(XENLOG_DEBUG, "MCE: rd MC%u_STATUS\n", bank);
             break;
         case MSR_IA32_MC0_ADDR:
             if ( !list_empty(&d->arch.vmca_msrs.impact_header) )

@@ -826,7 +826,7 @@ int mce_wrmsr(u32 msr, u64 value)
                 list_del(&entry->list);
             }
             else
-                gdprintk(XENLOG_DEBUG, "MCE: Not found HVM guest"
+                gdprintk(XENLOG_WARNING, "MCE: Not found HVM guest"
                     " last injection Node, something Wrong!\n");
         }
         break;

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel