Skip to contentSkip to conversation

TI: DaVinci DM365: Enabling net support on DM365

PATCH Superseded s-paulraj at ti.com 4 participants 6 messages Sep 14, 2009 – Sep 22, 2009

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 TI: DaVinci DM365: Enabling net support on DM365

From: Sandeep Paulraj <[email protected]>

This patch enables EMAC on the DM365 EVM.

---
 board/davinci/dm365evm/dm365evm.c |   38 +++++++++++++++++++++++++++++++++++++
 1 files changed, 38 insertions(+), 0 deletions(-)
board/davinci/dm365evm/dm365evm.c +38 -0
index 99392b3..2092324 100644
@@ -17,9 +17,11 @@
 
 #include <common.h>
 #include <nand.h>
+#include <asm/io.h>
 #include <asm/arch/hardware.h>
 #include <asm/arch/emif_defs.h>
 #include <asm/arch/nand_defs.h>
+#include <netdev.h>
 #include "../common/misc.h"
 
 DECLARE_GLOBAL_DATA_PTR;
@@ -32,6 +34,42 @@ int board_init(void)
 	return 0;
 }
 
+#ifdef CONFIG_DRIVER_TI_EMAC
+int board_eth_init(bd_t *bis)
+{
+	uint8_t eeprom_enetaddr[6];
+	int i;
+
+	/* Configure PINMUX 3 to enable EMAC pins */
+	writel((readl(PINMUX3) | 0x1affff), PINMUX3);
+
+	/* Configure GPIO20 as output */
+	writel((readl(GIO_DIR01) & 0xffefffff), GIO_DIR01);
+
+	/* Toggle GPIO 20 */
+	for (i = 0; i < 20; i++) {
+		/* GPIO 20 low */
+		writel((readl(GIO_OUT_DATA01) & 0xffefffff), GIO_OUT_DATA01);
+
+		udelay(1000);
+
+		/* GPIO 20 high */
+		writel((readl(GIO_OUT_DATA01) | 0x00100000), GIO_OUT_DATA01);
+	}
+
+	/* Configure I2C pins so that EEPROM can be read */
+	writel((readl(PINMUX3) | 0x01400000), PINMUX3);
+
+	/* Read Ethernet MAC address from EEPROM */
+	if (dvevm_read_mac_address(eeprom_enetaddr))
+		dv_configure_mac_address(eeprom_enetaddr);
+
+	davinci_emac_initialize();
+
+	return 0;
+}
+#endif
+
 #ifdef CONFIG_NAND_DAVINCI
 static void nand_dm365evm_select_chip(struct mtd_info *mtd, int chip)
 {
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 TI: DaVinci DM365: Enabling net support on DM365

Hi Sandeep,

Is there another part to this patch still coming or did I miss a patch along the way? This patch as-is doesn't compile:
...
dm365evm.c: In function ?board_eth_init?:
dm365evm.c:47: error: ?GIO_DIR01? undeclared (first use in this function) dm365evm.c:47: error: (Each undeclared identifier is reported only once dm365evm.c:47: error: for each function it appears in.) dm365evm.c:52: error: ?GIO_OUT_DATA01? undeclared (first use in this function)

Best regards,
Matt

Quoted 76 lines · s-paulraj at ti.com

From: Sandeep Paulraj <[email protected]>

This patch enables EMAC on the DM365 EVM.

---
 board/davinci/dm365evm/dm365evm.c |   38 +++++++++++++++++++++++++++++++++++++
 1 files changed, 38 insertions(+), 0 deletions(-)
board/davinci/dm365evm/dm365evm.c +38 -0
index 99392b3..2092324 100644
@@ -17,9 +17,11 @@
 
 #include <common.h>
 #include <nand.h>
+#include <asm/io.h>
 #include <asm/arch/hardware.h>
 #include <asm/arch/emif_defs.h>
 #include <asm/arch/nand_defs.h>
+#include <netdev.h>
 #include "../common/misc.h"
 
 DECLARE_GLOBAL_DATA_PTR;
@@ -32,6 +34,42 @@ int board_init(void)
 	return 0;
 }
 
+#ifdef CONFIG_DRIVER_TI_EMAC
+int board_eth_init(bd_t *bis)
+{
+	uint8_t eeprom_enetaddr[6];
+	int i;
+
+	/* Configure PINMUX 3 to enable EMAC pins */
+	writel((readl(PINMUX3) | 0x1affff), PINMUX3);
+
+	/* Configure GPIO20 as output */
+	writel((readl(GIO_DIR01) & 0xffefffff), GIO_DIR01);
+
+	/* Toggle GPIO 20 */
+	for (i = 0; i < 20; i++) {
+		/* GPIO 20 low */
+		writel((readl(GIO_OUT_DATA01) & 0xffefffff), GIO_OUT_DATA01);
+
+		udelay(1000);
+
+		/* GPIO 20 high */
+		writel((readl(GIO_OUT_DATA01) | 0x00100000), GIO_OUT_DATA01);
+	}
+
+	/* Configure I2C pins so that EEPROM can be read */
+	writel((readl(PINMUX3) | 0x01400000), PINMUX3);
+
+	/* Read Ethernet MAC address from EEPROM */
+	if (dvevm_read_mac_address(eeprom_enetaddr))
+		dv_configure_mac_address(eeprom_enetaddr);
+
+	davinci_emac_initialize();
+
+	return 0;
+}
+#endif
+
 #ifdef CONFIG_NAND_DAVINCI
 static void nand_dm365evm_select_chip(struct mtd_info *mtd, int chip)
 {
Signature · 6 lines
1.6.0.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
#2 lore raw

PATCH 1/1 TI: DaVinci DM365: Enabling net support on DM365

Quoted 12 lines

-----Original Message-----
From: Matt Waddel [mailto:mwaddel at control4.com]
Sent: Monday, September 14, 2009 5:43 PM
To: u-boot at lists.denx.de
Cc: Paulraj, Sandeep
Subject: Re: [U-Boot] [PATCH] TI: DaVinci DM365: Enabling net support on DM365

Hi Sandeep,

Quoted 9 lines

Is there another part to this patch still coming or did I miss a patch along the way? This patch as-is doesn't compile:
...
dm365evm.c: In function 'board_eth_init':
dm365evm.c:47: error: 'GIO_DIR01' undeclared (first use in this function) dm365evm.c:47: error: (Each undeclared identifier is reported only once dm365evm.c:47: error: for each function it appears in.) dm365evm.c:52: error: 'GIO_OUT_DATA01' undeclared (first use in this function)

You will need the patch with this header sent Saturday

TI: DaVinci: Adding GIO addresses to header file

After that you will need a patch I have not submitted because the same EMAC driver will be used by DM365, DM6467 and DA8xx series of chips.

So we(developers involved with DM6467 and DA8xx and me) have to come up with a clean and clever way to achieve this.

In the meanwhile if you are interested look at this tree. Its part of TI's ARAGO project and I added the EMAC support there

http://arago-project.org/git/people/?p=sandeep/u-boot-davinci.git;a=summary

The patch in question happens to be last commit in the above repo.
I have not submitted this patch and probably will not in this form because of the reason mentioned above.

If you clone the tree from the above mentioned link you will get a working version of U-Boot for DM365. I am using it as we speak.

Let me know if you have any concerns/issues.

Sandeep

#4 lore raw

PATCH 1/1 TI: DaVinci DM365: Enabling net support on DM365

Dear "Paulraj, Sandeep",

Quoted 6 lines · In message <[email protected]> you…
Quoted 6 lines

From: Sandeep Paulraj <[email protected]>

This patch enables EMAC on the DM365 EVM.

Quoted 8 lines
Quoted 6 lines
---
 board/davinci/dm365evm/dm365evm.c |   38
+++++++++++++++++++++++++++++++++++++
 1 files changed, 38 insertions(+), 0 deletions(-)

Pushed to u-boot-ti

Please undo. We want to enable the compiler for strict type checkings for all accesses to hardware registers, which is impossible with the use of plain address constants in this code.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Whom the gods would destroy, they first teach BASIC.
#5 lore raw

PATCH 1/1 TI: DaVinci DM365: Enabling net support on DM365

In reply to s-paulraj at ti.com

Dear s-paulraj at ti.com,

Quoted 8 lines · In message <[email protected]> you wrote:

From: Sandeep Paulraj <[email protected]>

This patch enables EMAC on the DM365 EVM.

---
 board/davinci/dm365evm/dm365evm.c |   38 +++++++++++++++++++++++++++++++++++++
 1 files changed, 38 insertions(+), 0 deletions(-)

...

board/davinci/dm365evm/dm365evm.c int board_init(void) · line 47

Quoted 5 lines
board/davinci/dm365evm/dm365evm.c +5 -0
+	/* Configure PINMUX 3 to enable EMAC pins */
+	writel((readl(PINMUX3) | 0x1affff), PINMUX3);
+
+	/* Configure GPIO20 as output */
+	writel((readl(GIO_DIR01) & 0xffefffff), GIO_DIR01);

Please use C structs to dsescribe the register layout. Do not use typeless addresses.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To know how another being, another creature feels -  that  is  impos-
sible.                  - Terry Pratchett, _The Dark Side of the Sun_