Skip to contentSkip to conversation

new default shortcut to config & build a board

PATCH New Mike Frysinger 4 participants 6 messages Aug 24, 2009 – Oct 18, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 new default shortcut to config & build a board

The majority of the time that I build things in U-Boot, I want to just build for the board. I don't make board config tweaks after selecting the board. So add a new pattern rule that allows people to combine two steps in one go:

	`make foo_config && make` => `make foo`

This shouldn't conflict with any existing make rules as the pattern rule is used only the rule doesn't already exist.

---
 Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Makefile +4 -4
index 02393b6..bf45a0b 100644
@@ -495,6 +495,10 @@ unconfig:
 		$(obj)board/*/config.tmp $(obj)board/*/*/config.tmp \
 		$(obj)include/autoconf.mk $(obj)include/autoconf.mk.dep
 
+%: %_config
+	$(MAKE) $@_config
+	$(MAKE)
+
 #========================================================================
 # PowerPC
 #========================================================================
@@ -3505,10 +3509,6 @@ BFIN_BOARDS += ibf-dsp561
 $(BFIN_BOARDS:%=%_config)	: unconfig
 	@$(MKCONFIG) $(@:_config=) blackfin blackfin $(@:_config=)
 
-$(BFIN_BOARDS):
-	$(MAKE) $@_config
-	$(MAKE)
-
 #========================================================================
 # AVR32
 #========================================================================
Signature · 1 line
1.6.4
#1 lore raw

PATCH 1/1 new default shortcut to config & build a board

Quoted 8 lines · On Monday 24 August 2009 17:28:26 Mike Frysinger wrote:

The majority of the time that I build things in U-Boot, I want to just build for the board. I don't make board config tweaks after selecting the board. So add a new pattern rule that allows people to combine two steps in one go:

	`make foo_config && make` => `make foo`

This shouldn't conflict with any existing make rules as the pattern rule is used only the rule doesn't already exist.

ping
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091001/d7b45b83/attachment.pgp

#2 lore raw

PATCH 1/1 new default shortcut to config & build a board

Hi Mike,

Quoted 9 lines · On Monday 24 August 2009 17:28:26 Mike Frysinger wrote:
Quoted 8 lines

The majority of the time that I build things in U-Boot, I want to just build for the board. I don't make board config tweaks after selecting the board. So add a new pattern rule that allows people to combine two steps in one go:

	`make foo_config && make` => `make foo`

This shouldn't conflict with any existing make rules as the pattern rule is used only the rule doesn't already exist.

Hm, I just tried this patch and I see a strange behaviour:

[dzu at pollux u-boot-testing (mao-rd-hor)]$ make -s sequoia Configuring for sequoia board...
Configuring for sequoia board...

It is not obvious for me why I get this message twice - all I verified is that both messages are definitely from stdout only.

Apart from that, I don't see a reason why this should not go in. Currently I use "./MAKEALL <board>" for the same purpose btw.

Cheers
Detlev

Signature · 6 lines
If we knew what it was we were doing, we wouldn't call it research.
                                            -- Einstein
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
#3 lore raw

PATCH 1/1 new default shortcut to config & build a board

In reply to Mike Frysinger
Quoted 6 lines · Mike Frysinger

+%: %_config
+ ? ? ? $(MAKE) $@_config <--- Delete this, because the %_config already calls the target config block

+ ? ? ? $(MAKE)
+

best regards,

luigi

Signature · 10 lines
Luigi 'Comio' Mantellini
R&D - Software
Industrie Dial Face S.p.A.
Via Canzo, 4
20068 Peschiera Borromeo (MI), Italy

Tel.: +39 02 5167 2813
Fax: +39 02 5167 2459
web: www.idf-hit.com
mail: luigi.mantellini at idf-hit.com
#4 lore raw

PATCH v2 1/1 new default shortcut to config & build a board

In reply to Mike Frysinger

The majority of the time that I build things in U-Boot, I want to just build for the board. I don't make board config tweaks after selecting the board. So add a new pattern rule that allows people to combine two steps in one go:

	`make foo_config && make` => `make foo`

This shouldn't conflict with any existing make rules as the pattern rule is used only the rule doesn't already exist.

---
v2
- fix duplicate config left over from original code pointed out by Luigi

 Makefile |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
Makefile +3 -4
index 9c5b2a5..15363b8 100644
@@ -501,6 +501,9 @@ unconfig:
 		$(obj)board/*/config.tmp $(obj)board/*/*/config.tmp \
 		$(obj)include/autoconf.mk $(obj)include/autoconf.mk.dep
 
+%: %_config
+	$(MAKE)
+
 #========================================================================
 # PowerPC
 #========================================================================
@@ -3525,10 +3528,6 @@ BFIN_BOARDS += ibf-dsp561
 $(BFIN_BOARDS:%=%_config)	: unconfig
 	@$(MKCONFIG) $(@:_config=) blackfin blackfin $(@:_config=)
 
-$(BFIN_BOARDS):
-	$(MAKE) $@_config
-	$(MAKE)
-
 #========================================================================
 # AVR32
 #========================================================================
Signature · 1 line
1.6.5.rc2
#5 lore raw

PATCH v2 1/1 new default shortcut to config & build a board

Dear Mike Frysinger,

Quoted 9 lines · In message <[email protected]> you wrote:

The majority of the time that I build things in U-Boot, I want to just build for the board. I don't make board config tweaks after selecting the board. So add a new pattern rule that allows people to combine two steps in one go:

	`make foo_config && make` => `make foo`

This shouldn't conflict with any existing make rules as the pattern rule is used only the rule doesn't already exist.

Quoted 7 lines

---
v2
- fix duplicate config left over from original code pointed out by Luigi

 Makefile |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Die meisten Menschen pflegen im Kindesalter vom Zeigen auf Gegenst?n-
de (Mausbewegung) und "ga" sagen  (Mausklick)  abzukommen,  zugunsten
eines  m?chtigeren  und langwierig zu erlernenden Tools (Sprache).
                             -- Achim Linder in de.comp.os.linux.misc