sensord: Cleanup of the sensors deamon
cover sensord: Cleanup of the sensors deamon
Hi Jean,
here is another patch series cleaning up the sensors deamon.
Some patches fixing some coding style issues, breaking long lines and making code more readable by the refactoring of big functions.
Another one removes some needless casts and there is a patch converting the HTML code (CGI script) generated by sensord to lower case. So we're closer to XHTML. Unfortunately the output of rrdcgi isn't very strict.
With this series I've finished the cleanup caused by the coding style conversion. During the work I saw some things to fix, so I will go on hacking the deamon. Now I hope the code is more readable and the maintenance and development should be easier. BTW I don't like some details of the implementation (see notes in patch 4/5). Some stuff looks needless. Further I would like it if the deamon would be closer to the sensors console tool. This would ease maintenance too. So you see what I'm going to do in the future.
This here is post 3.1.1 material. Maybe we could make a stable branch 3.1.1? Otherwise we wait with the commits until 3.1.1 is released.
Thanks,
Andre
---
rrd.c | 140 +++++++++++++++++++++++++++---------------- sense.c | 204 ++++++++++++++++++++++++++++++++++++++-------------------------- 2 files changed, 210 insertions(+), 134 deletions(-)
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 12 lines · Andre Prendel
Hi Jean,
here is another patch series cleaning up the sensors deamon.
Some patches fixing some coding style issues, breaking long lines and making code more readable by the refactoring of big functions.
Another one removes some needless casts and there is a patch converting the HTML code (CGI script) generated by sensord to lower case. So we're closer to XHTML. Unfortunately the output of rrdcgi isn't very strict.
Quoted 8 lines
With this series I've finished the cleanup caused by the coding style conversion. During the work I saw some things to fix, so I will go on hacking the deamon. Now I hope the code is more readable and the maintenance and development should be easier. BTW I don't like some details of the implementation (see notes in patch 4/5). Some stuff looks needless. Further I would like it if the deamon would be closer to the sensors console tool. This would ease maintenance too. So you see what I'm going to do in the future.
Very nice. Thanks a lot for working on this, this was very needed.
Quoted 2 lines
This here is post 3.1.1 material. Maybe we could make a stable branch 3.1.1? Otherwise we wait with the commits until 3.1.1 is released.
Let's just wait until 3.1.1 is released, it is less than 1 week away now and nobody reviewed your patches yet anyway. I don't think it makes much sense to create branches for 1-week SVN freeze periods. And anyway, during these periods, we should all be testing the code rather that developing new stuff ;)
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 24 lines · Jean Delvare
Quoted 12 lines · Andre Prendel
Hi Jean,
here is another patch series cleaning up the sensors deamon.
Some patches fixing some coding style issues, breaking long lines and making code more readable by the refactoring of big functions.
Another one removes some needless casts and there is a patch converting the HTML code (CGI script) generated by sensord to lower case. So we're closer to XHTML. Unfortunately the output of rrdcgi isn't very strict.
Quoted 8 lines
With this series I've finished the cleanup caused by the coding style conversion. During the work I saw some things to fix, so I will go on hacking the deamon. Now I hope the code is more readable and the maintenance and development should be easier. BTW I don't like some details of the implementation (see notes in patch 4/5). Some stuff looks needless. Further I would like it if the deamon would be closer to the sensors console tool. This would ease maintenance too. So you see what I'm going to do in the future.
Very nice. Thanks a lot for working on this, this was very needed.
Quoted 8 lines
Quoted 2 lines
This here is post 3.1.1 material. Maybe we could make a stable branch 3.1.1? Otherwise we wait with the commits until 3.1.1 is released.
Let's just wait until 3.1.1 is released, it is less than 1 week away now and nobody reviewed your patches yet anyway. I don't think it makes much sense to create branches for 1-week SVN freeze periods. And anyway, during these periods, we should all be testing the code rather that developing new stuff ;)
Andre, any news from these sensord patches? We spent quite some time on them, and they looked promising, it would be a pity if they are finally lost.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 34 lines · Jean Delvare
Quoted 24 lines · Jean Delvare
Quoted 12 lines · Andre Prendel
Hi Jean,
here is another patch series cleaning up the sensors deamon.
Some patches fixing some coding style issues, breaking long lines and making code more readable by the refactoring of big functions.
Another one removes some needless casts and there is a patch converting the HTML code (CGI script) generated by sensord to lower case. So we're closer to XHTML. Unfortunately the output of rrdcgi isn't very strict.
Quoted 8 lines
With this series I've finished the cleanup caused by the coding style conversion. During the work I saw some things to fix, so I will go on hacking the deamon. Now I hope the code is more readable and the maintenance and development should be easier. BTW I don't like some details of the implementation (see notes in patch 4/5). Some stuff looks needless. Further I would like it if the deamon would be closer to the sensors console tool. This would ease maintenance too. So you see what I'm going to do in the future.
Very nice. Thanks a lot for working on this, this was very needed.
Quoted 8 lines
Quoted 2 lines
This here is post 3.1.1 material. Maybe we could make a stable branch 3.1.1? Otherwise we wait with the commits until 3.1.1 is released.
Let's just wait until 3.1.1 is released, it is less than 1 week away now and nobody reviewed your patches yet anyway. I don't think it makes much sense to create branches for 1-week SVN freeze periods. And anyway, during these periods, we should all be testing the code rather that developing new stuff ;)
Quoted 3 lines
Andre, any news from these sensord patches? We spent quite some time on them, and they looked promising, it would be a pity if they are finally lost.
Hi Jean,
no news so far :( To much other work since I changed the employer and maybe I've been a bit lazy lately :)
Ok, I will reserve some time next week to revise the patches.
BTW I did some work on the DMI configuration topic a few month ago. I don't forgot this one. But it's far from being ready. So far there's just a bash script for fetching the configs from lm-sensors.org and another one looking for DMI data and suitable config and copy this one. Is it worth to post this prototype to have something to discuss or should I better finish the work? I think I will post it :)
Thanks,
Andre
Quoted 2 lines
Signature · 1 line
Jean Delvare
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 9 lines · Andre Prendel
Quoted 3 lines · Jean Delvare
Andre, any news from these sensord patches? We spent quite some time on them, and they looked promising, it would be a pity if they are finally lost.
no news so far :( To much other work since I changed the employer and maybe I've been a bit lazy lately :)
Ok, I will reserve some time next week to revise the patches.
Great, thanks.
Quoted 6 lines
BTW I did some work on the DMI configuration topic a few month ago. I don't forgot this one. But it's far from being ready. So far there's just a bash script for fetching the configs from lm-sensors.org and another one looking for DMI data and suitable config and copy this one. Is it worth to post this prototype to have something to discuss or should I better finish the work? I think I will post it :)
Feel free to post them. I can't promise anything will happen to them, as I also didn't have much time to work on this. But at least posted work is archived and may be useful in the future.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors