cxgb3: No need to wake queue in xmit handler
Subsystems (2)
PATCH 1/1 cxgb3: No need to wake queue in xmit handler
The xmit handler doesn't need to wake the queue after stopping it temporarily (some other drivers are doing the same).
Patch on net-next-2.6, multiple netperf sessions tested.
Signed-off-by Krishna Kumar <[email protected]>
---
drivers/net/cxgb3/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/cxgb3/sge.c +1 -1
@@ -1260,7 +1260,7 @@ netdev_tx_t t3_eth_xmit(struct sk_buff *if (should_restart_tx (q) &&test_and_clear_bit (TXQ_ETH , &qs->txq_stopped)) { q->restarts++; -netif_tx_wake_queue (txq); +netif_tx_start_queue (txq); } }
Quoted 6 lines · Krishna Kumar
The xmit handler doesn't need to wake the queue after stopping it temporarily (some other drivers are doing the same).
Patch on net-next-2.6, multiple netperf sessions tested.
Signed-off-by Krishna Kumar <[email protected]>
Acked-by Divy Le Ray <[email protected]>
Quoted 17 lines
---
drivers/net/cxgb3/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff -ruNp
org/drivers/net/cxgb3/sge.cnew/drivers/net/cxgb3/sge.cdrivers/net/cxgb3/sge.c +1
-1@@ -1260,7 +1260,7 @@ netdev_tx_t t3_eth_xmit(struct sk_buff *if (should_restart_tx (q) &&test_and_clear_bit (TXQ_ETH , &qs->txq_stopped)) { q->restarts++; -netif_tx_wake_queue (txq); +netif_tx_start_queue (txq); } }
From: Krishna Kumar <[email protected]>
Date: Thu, 15 Oct 2009 11:24:19 +0530
Quoted 6 lines
The xmit handler doesn't need to wake the queue after stopping it temporarily (some other drivers are doing the same).
Patch on net-next-2.6, multiple netperf sessions tested.
Signed-off-by Krishna Kumar <[email protected]>
Applied.