Skip to contentSkip to conversation

cxgb3: No need to wake queue in xmit handler

PATCH Applied Krishna Kumar 3 participants 3 messages Oct 15, 2009 – Oct 18, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cxgb3: No need to wake queue in xmit handler

The xmit handler doesn't need to wake the queue after stopping it temporarily (some other drivers are doing the same).

Patch on net-next-2.6, multiple netperf sessions tested.

---

 drivers/net/cxgb3/sge.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/cxgb3/sge.c +1 -1
diff -ruNp org/drivers/net/cxgb3/sge.c new/drivers/net/cxgb3/sge.c
@@ -1260,7 +1260,7 @@ netdev_tx_t t3_eth_xmit(struct sk_buff *
 		if (should_restart_tx(q) &&
 		    test_and_clear_bit(TXQ_ETH, &qs->txq_stopped)) {
 			q->restarts++;
-			netif_tx_wake_queue(txq);
+			netif_tx_start_queue(txq);
 		}
 	}
 
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Krishna Kumar

The xmit handler doesn't need to wake the queue after stopping it temporarily (some other drivers are doing the same).

Patch on net-next-2.6, multiple netperf sessions tested.

Quoted 17 lines

---

 drivers/net/cxgb3/sge.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -ruNp org/drivers/net/cxgb3/sge.c new/drivers/net/cxgb3/sge.c

drivers/net/cxgb3/sge.c +1 -1
@@ -1260,7 +1260,7 @@ netdev_tx_t t3_eth_xmit(struct sk_buff *
 		if (should_restart_tx(q) &&
 		    test_and_clear_bit(TXQ_ETH, &qs->txq_stopped)) {
 			q->restarts++;
-			netif_tx_wake_queue(txq);
+			netif_tx_start_queue(txq);
 		}
 	}