dst: Fix parentheses
PATCH 1/1 dst: Fix parentheses
|' has a higher precedence than ?' so since MSG_WAITALL is defined 0x100, MSG_MORE was always written to the msg_flag.
Signed-off-by Roel Kluin <[email protected]>
--- drivers/staging/dst/state.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/dst/state.c +1 -1
@@ -121,7 +121,7 @@ int dst_data_send_header(struct socket *sock, msg.msg_namelen =0 ; msg.msg_control =NULL ; msg.msg_controllen =0 ; - msg.msg_flags =MSG_WAITALL | (more)?MSG_MORE :0 ; + msg.msg_flags =MSG_WAITALL | (more ?MSG_MORE :0 ); err =kernel_sendmsg (sock, &msg, &iov,1 , iov.iov_len);if (err != size) {
Quoted 4 lines · Roel Kluin
|' has a higher precedence than?' so sinceMSG_WAITALLis defined0x100,MSG_MOREwas always written to themsg_flag.Signed-off-by Roel Kluin <[email protected]>
Looks good, thank you!
Andrew, please queue it into the appropriate tree.
Signature · 1 line
Evgeniy Polyakov
Quoted 8 lines · Evgeniy Polyakov
Quoted 4 lines · Roel Kluin
|' has a higher precedence than?' so sinceMSG_WAITALLis defined0x100,MSG_MOREwas always written to themsg_flag.Signed-off-by Roel Kluin <[email protected]>Looks good, thank you!
Andrew, please queue it into the appropriate tree.
That would be my tree, I'll do it.
thanks,
greg k-h
Quoted 6 lines · Greg KH
Quoted 4 lines
Quoted 1 line
Signed-off-by Roel Kluin <[email protected]>Looks good, thank you!
Andrew, please queue it into the appropriate tree.That would be my tree, I'll do it.
Ok, no problem. Thank you Greg.
Signature · 1 line
Evgeniy Polyakov