Skip to contentSkip to conversation

dst: Fix parentheses

PATCH In review Roel Kluin 3 participants 4 messages Nov 3, 2009 – Nov 4, 2009 Staging

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 dst: Fix parentheses

|' has a higher precedence than ?' so since MSG_WAITALL is defined 0x100, MSG_MORE was always written to the msg_flag.

---
 drivers/staging/dst/state.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/dst/state.c +1 -1
index d057e52..bccbd6d 100644
@@ -121,7 +121,7 @@ int dst_data_send_header(struct socket *sock,
 	msg.msg_namelen = 0;
 	msg.msg_control = NULL;
 	msg.msg_controllen = 0;
-	msg.msg_flags = MSG_WAITALL | (more)?MSG_MORE:0;
+	msg.msg_flags = MSG_WAITALL | (more ? MSG_MORE : 0);
 
 	err = kernel_sendmsg(sock, &msg, &iov, 1, iov.iov_len);
 	if (err != size) {
#1 lore raw
Quoted 4 lines · Roel Kluin

|' has a higher precedence than ?' so since MSG_WAITALL is defined 0x100, MSG_MORE was always written to the msg_flag.

Looks good, thank you!
Andrew, please queue it into the appropriate tree.

Signature · 1 line
	Evgeniy Polyakov
#2 lore raw
Quoted 8 lines · Evgeniy Polyakov
Quoted 4 lines · Roel Kluin

|' has a higher precedence than ?' so since MSG_WAITALL is defined 0x100, MSG_MORE was always written to the msg_flag.

Looks good, thank you!
Andrew, please queue it into the appropriate tree.

That would be my tree, I'll do it.

thanks,

greg k-h

#3 lore raw
Quoted 6 lines · Greg KH
Quoted 4 lines
Quoted 1 line

Looks good, thank you!
Andrew, please queue it into the appropriate tree.

That would be my tree, I'll do it.

Ok, no problem. Thank you Greg.

Signature · 1 line
	Evgeniy Polyakov