ARM Add New Board GEC2410
PATCH 2/4 ARM Add New Board GEC2410
Add ARM920T NAND flash booting.
checkpatch.pl shows that all things are fine.
total: 0 errors, 0 warnings, 70 lines checked
0002-ARM920T-NAND-flash-booting.patch has no obvious style problems and is ready for submission.
=========================================================
--- cpu/arm920t/start.S | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-)
cpu/arm920t/start.S +20 -0
@@ -38,6 +38,7 @@ .globl _start _start: b start_code +#ifndef CONFIG_NAND_SPL ldr pc, _undefined_instruction ldr pc, _software_interrupt ldr pc, _prefetch_abort
@@ -53,7 +54,13 @@ _data_abort: .word data_abort _not_used: .word not_used _irq: .word irq _fiq: .word fiq +_pad: .word 0x12345678 /* now 16*4=64 */ +#else + . = _start + 64 +#endif +.global _end_vect +_end_vect: .balignl 16,0xdeadbeef
@@ -197,7 +204,11 @@ copy_loop: /* Set up the stack */ stack_setup: +#ifndef CONFIG_NAND_SPL ldr r0, _TEXT_BASE /* upper 128 KiB: relocated uboot */ +#else + ldr r0, =(CONFIG_SYS_UBOOT_BASE + CONFIG_SYS_UBOOT_SIZE) +#endif sub r0, r0, #CONFIG_SYS_MALLOC_LEN /* malloc area */ sub r0, r0, #CONFIG_SYS_GBL_DATA_SIZE /* bdinfo */ #ifdef CONFIG_USE_IRQ
@@ -215,9 +226,14 @@ clbss_l:str r2, [r0] /* clear loop... */ cmp r0, r1 ble clbss_l +#ifndef CONFIG_NAND_SPL ldr pc, _start_armboot _start_armboot: .word start_armboot +#else + b nand_boot +/* .word nand_boot */ +#endif /*
@@ -234,6 +250,7 @@ _start_armboot: .word start_armboot #ifndef CONFIG_SKIP_LOWLEVEL_INIT cpu_init_crit: +#ifndef CONFIG_NAND_SPL /* * flush v4 I/D caches */
@@ -250,6 +267,7 @@ cpu_init_crit: orr r0, r0, #0x00000002 @ set bit 2 (A) Align orr r0, r0, #0x00001000 @ set bit 12 (I) I-Cache mcr p15, 0, r0, c1, c0, 0 +#endif /* CONFIG_NAND_SPL */ /* * before relocating, we have to setup RAM timing
@@ -264,6 +282,7 @@ cpu_init_crit: mov pc, lr #endif /* CONFIG_SKIP_LOWLEVEL_INIT */ +#ifndef CONFIG_NAND_SPL /* ************************************************************************* *
@@ -434,3 +453,4 @@ fiq: bl do_fiq #endif +#endif /* CONFIG_NAND_SPL */
Signature · 1 line
1.6.0.4
PATCH 2/4 ARM Add New Board GEC2410
Dear "Hui.Tang",
Quoted 27 lines · In message <[email protected]> you wrote:
Add ARM920T NAND flash booting.
checkpatch.pl shows that all things are fine.
total: 0 errors, 0 warnings, 70 lines checked
0002-ARM920T-NAND-flash-booting.patch has no obvious style problems and is ready for submission.
=========================================================
Signed-off-by Hui.Tang <[email protected]>--- cpu/arm920t/start.S | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-)cpu/arm920t/start.S +1
-0@@ -38,6 +38,7 @@ .globl _start _start: b start_code +#ifndef CONFIG_NAND_SPL ldr pc, _undefined_instruction ldr pc, _software_interrupt ldr pc, _prefetch_abort
cpu/arm920t/start.S _data_abort: .word data_abort · line 60
Quoted 7 lines
cpu/arm920t/start.S +4
-0@@ -53,7 +54,13 @@ _data_abort: .word data_abort _not_used: .word not_used _irq: .word irq _fiq: .word fiq +_pad: .word 0x12345678 /* now 16*4=64 */ +#else + . = _start + 64 +#endif
As there is no code added to ever set CONFIG_NAND_SPL, all this is just dead code - or an incomplete patch.
Please make sure to split your patches such that they are really orthogonal to each other. Don't add some parts of CONFIG_NAND_SPL stuff in one patch and some other parts in another one.
cpu/arm920t/start.S clbss_l:str r2, [r0] /* clear loop... */ · line 235
Quoted 4 lines
cpu/arm920t/start.S +3
-0_start_armboot: .word start_armboot +#else + b nand_boot +/* .word nand_boot */
Don't add dead code.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The use of COBOL cripples the mind; its teaching should, therefore,
be regarded as a criminal offence.
-- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5