copy_signal cleanup: clean tty_audit_fork()
PATCH 4/4 copy_signal cleanup: clean tty_audit_fork()
Remove unneeded initialization in tty_audit_fork().
Signed-off-by Veaceslav Falico <[email protected]>
---
drivers/char/tty_audit.c +0 -1
@@ -148,7 +148,6 @@ void tty_audit_fork(struct signal_struct *sig)spin_lock_irq (¤t->sighand->siglock); sig->audit_tty = current->signal->audit_tty;spin_unlock_irq (¤t->sighand->siglock); - sig->tty_audit_buf =NULL ; }/**
Quoted 11 lines · Veaceslav Falico
Remove unneeded initialization in
tty_audit_fork().Signed-off-by Veaceslav Falico <[email protected]>---
drivers/char/tty_audit.c +0
-0
drivers/char/tty_audit.c void tty_audit_fork(struct signal_struct *sig) · line 151
Quoted 5 lines
drivers/char/tty_audit.c +0
-1@@ -148,7 +148,6 @@ void tty_audit_fork(struct signal_struct *sig)spin_lock_irq (¤t->sighand->siglock); sig->audit_tty = current->signal->audit_tty;spin_unlock_irq (¤t->sighand->siglock); - sig->tty_audit_buf =NULL ; }
OK, but given that this function is "far" from copy_signal() path and it is not inline, perhaps it makes sense to add the comment which explains *sig must be zeroed, and the only caller is copy_signal().
Hmm. Off-topic, but why do we take ->siglock? ->audit_tty is boolean, afaics ->siglock buys nothing.
Oleg.