Skip to contentSkip to conversation

copy_signal cleanup: clean tty_audit_fork()

PATCH In review Veaceslav Falico 2 participants 2 messages Dec 1, 2009 – Dec 2, 2009 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 4/4 copy_signal cleanup: clean tty_audit_fork()

Remove unneeded initialization in tty_audit_fork().

---

drivers/char/tty_audit.c +0 -1
index ac16fbe..283a15b 100644
@@ -148,7 +148,6 @@ void tty_audit_fork(struct signal_struct *sig)
 	spin_lock_irq(&current->sighand->siglock);
 	sig->audit_tty = current->signal->audit_tty;
 	spin_unlock_irq(&current->sighand->siglock);
-	sig->tty_audit_buf = NULL;
 }
 
 /**
#1 lore raw
Quoted 11 lines · Veaceslav Falico

Remove unneeded initialization in tty_audit_fork().

---

drivers/char/tty_audit.c +0 -0
index ac16fbe..283a15b 100644

drivers/char/tty_audit.c void tty_audit_fork(struct signal_struct *sig) · line 151

Quoted 5 lines
drivers/char/tty_audit.c +0 -1
@@ -148,7 +148,6 @@ void tty_audit_fork(struct signal_struct *sig)
 	spin_lock_irq(&current->sighand->siglock);
 	sig->audit_tty = current->signal->audit_tty;
 	spin_unlock_irq(&current->sighand->siglock);
-	sig->tty_audit_buf = NULL;
 }

OK, but given that this function is "far" from copy_signal() path and it is not inline, perhaps it makes sense to add the comment which explains *sig must be zeroed, and the only caller is copy_signal().

Hmm. Off-topic, but why do we take ->siglock? ->audit_tty is boolean, afaics ->siglock buys nothing.

Oleg.