Input: add msi-wmi driver to support hotkeys in MSI Windtop AE1900-WT
Subsystems (4)
RFC PATCH 1/2 Input: add msi-wmi driver to support hotkeys in MSI Windtop AE1900-WT
---
Hi,
This driver (intiated by
http://sysmic.org/dotclear2/index.php?post/2009/06/02/83-msi-wmi-support) is aimed at supporting WMI based hotkeys on MSI Windtop all-in-one AE1900-WT.
This patch contains both WMI and DMI auto loading. Once Mathew Garrett's patch for wmi autoloading is upstream (now in acpi-test), DMI auto loading could (should?) be removed.
Also, Dmitry is in the process of factoring code for sparse keymaps. The second patch adds support its sparse keymap lib, removing a lot of code.
These patches are based on linux-input tree, and have been tested on the hardware with and without the sparse keymap patch.
drivers/platform/x86/Kconfig | 11 ++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/msi-wmi.c | 212 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 224 insertions(+), 0 deletions(-) create mode 100644 drivers/platform/x86/msi-wmi.c
drivers/platform/x86/Kconfig +11 -0
@@ -441,4 +441,15 @@ config ACPI_TOSHIBA If you have a legacy free Toshiba laptop (such as the Libretto L1 series), say Y. + +config MSI_WMI + tristate "MSI WMI extras" + depends on ACPI_WMI + depends on INPUT + ---help--- + Say Y here if you want to support WMI-based hotkeys on MSI all-in-one + WindTop AE1900-WT. + + To compile this driver as a module, choose M here: the module will + be called msi-wmi. endif # X86_PLATFORM_DEVICES
drivers/platform/x86/Makefile +1 -0
@@ -21,3 +21,4 @@ obj-$(CONFIG_ACPI_WMI) += wmi.o obj-$(CONFIG_ACPI_ASUS) += asus_acpi.o obj-$(CONFIG_TOPSTAR_LAPTOP) += topstar-laptop.o obj-$(CONFIG_ACPI_TOSHIBA) += toshiba_acpi.o +obj-$(CONFIG_MSI_WMI) += msi-wmi.o
drivers/platform/x86/msi-wmi.c new file +212 -0
212 lines not on this page · raw message
Signature · 6 lines
1.6.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
RFC PATCH 2/2 Input: msi-wmi - switch to using sparse keymap library
--- drivers/platform/x86/Kconfig | 1 + drivers/platform/x86/msi-wmi.c | 123 +++++++++++----------------------------- 2 files changed, 35 insertions(+), 89 deletions(-)
drivers/platform/x86/Kconfig +1 -0
@@ -446,6 +446,7 @@ config MSI_WMI tristate "MSI WMI extras" depends on ACPI_WMI depends on INPUT + select INPUT_SPARSEKMAP ---help--- Say Y here if you want to support WMI-based hotkeys on MSI all-in-one WindTop AE1900-WT.
drivers/platform/x86/msi-wmi.c +34 -89
185 lines not on this page · raw message
Signature · 6 lines
1.6.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 2/2] Input: msi-wmi - switch to using sparse keymap library
Quoted 2 lines · Anisse Astier
static void
__exitmsi_wmi_exit(void)
Anisse,
It does not look like you are freeing sparse keymap when you unnregistering input device, otherwise looks good.
Signature · 1 line
Dmitry
Hi Anisse,
drivers/platform/x86/msi-wmi.c line 92
Quoted 3 lines · Anisse Astier
drivers/platform/x86/msi-wmi.c new file +3
-0+ +if (jiffies_to_msecs (get_jiffies_64 () - msi_wmi_time_last_press) + > pression_timeout) {
Why don't you use time_after() instead of manual computation?
Also, what is the point of this? If you are trying to debounce the buttons this will not quite work. To do debouncing properly you need to store the value you just read and fire up a timer. When timer fires - that's the stable value.
drivers/platform/x86/msi-wmi.c line 95
Quoted 3 lines
drivers/platform/x86/msi-wmi.c new file +3
-0+printk (KERN_DEBUG +"MSI WMI: event correctly received: %llu\n" , + obj->integer.value);
This is way too noisy for the mainline kernel, pr_debug() perhaps?
Quoted 77 lines
drivers/platform/x86/msi-wmi.c new file +77
-0+ msi_wmi_time_last_press =get_jiffies_64 (); + key =msi_wmi_get_entry_by_scancode (obj->integer.value); +input_report_key (msi_wmi_input_dev, key->keycode,1 ); +input_sync (msi_wmi_input_dev); +input_report_key (msi_wmi_input_dev, key->keycode,0 ); +input_sync (msi_wmi_input_dev); + } +} + +static int msi_wmi_getkeycode (struct input_dev *dev,int scancode,int *keycode) +{ +struct key_entry *key =msi_wmi_get_entry_by_scancode (scancode); + +if (key && key->code) { + *keycode = key->keycode; +return 0 ; + } + +return -EINVAL ; +} + +static int msi_wmi_setkeycode (struct input_dev *dev,int scancode,int keycode) +{ +struct key_entry *key; +int old_keycode; + +if (keycode <0 || keycode >KEY_MAX ) +return -EINVAL ; + + key =msi_wmi_get_entry_by_scancode (scancode); +if (key && key->code) { + old_keycode = key->keycode; + key->keycode = keycode; +set_bit (keycode, dev->keybit); +if (!msi_wmi_get_entry_by_keycode (old_keycode)) +clear_bit (old_keycode, dev->keybit); +return 0 ; + } + +return -EINVAL ; +} + +static int __init msi_wmi_input_setup (void ) +{ +struct key_entry *key; +int err; + + msi_wmi_input_dev =input_allocate_device (); + + msi_wmi_input_dev->name ="MSI WMI hotkeys" ; + msi_wmi_input_dev->phys ="wmi/input0" ; + msi_wmi_input_dev->id.bustype =BUS_HOST ; + msi_wmi_input_dev->getkeycode = msi_wmi_getkeycode; + msi_wmi_input_dev->setkeycode = msi_wmi_setkeycode; + +for (key = msi_wmi_keymap; key->code; key++) { +set_bit (EV_KEY , msi_wmi_input_dev->evbit); +set_bit (key->keycode, msi_wmi_input_dev->keybit); + } + + err =input_register_device (msi_wmi_input_dev); + +if (err) +input_free_device (msi_wmi_input_dev); + +return err; +} + +static int __init msi_wmi_init (void ) +{ +int err; + + msi_wmi_time_last_press =get_jiffies_64 (); +if (!wmi_has_guid (MSIWMI_EVENT_GUID )) { +printk (KERN_ERR +"This machine doesn't have MSI-hotkeys through WMI\n" ); + goto load_error;
drivers/platform/x86/msi-wmi.c line 182
Quoted 10 lines
drivers/platform/x86/msi-wmi.c new file +10
-0+ } + err =wmi_install_notify_handler (MSIWMI_EVENT_GUID , + msi_wmi_notify,NULL ); +if (err) { +printk (KERN_ERR +"MSI WMI: Error while installing notify handler\n" ); + goto load_error; + } + +msi_wmi_input_setup ();
You need to handle errors returned by msi_wmi_input_setup() as well.
Quoted 20 lines
drivers/platform/x86/msi-wmi.c new file +20
-0+ +return 0 ; +load_error: +return -ENODEV ; +} + +static void __exit msi_wmi_exit(void) +{ +if (wmi_has_guid (MSIWMI_EVENT_GUID )) { +wmi_remove_notify_handler (MSIWMI_EVENT_GUID ); +input_unregister_device (msi_wmi_input_dev); + } +} + +module_init (msi_wmi_init); +module_exit (msi_wmi_exit); +module_param (pression_timeout, uint,0 ); + +MODULE_AUTHOR ("Jérôme Pouiller <[email protected]>" ); +MODULE_AUTHOR ("Michael Bouchaud <[email protected]" );
drivers/platform/x86/msi-wmi.c line 212
Quoted 10 lines
drivers/platform/x86/msi-wmi.c new file +10
-0+MODULE_AUTHOR ("Anisse Astier <[email protected]" ); +MODULE_DESCRIPTION ("MSI all-in-one WMI hotkeys driver" ); +MODULE_LICENSE ("GPL" ); +MODULE_ALIAS ("wmi:" MSIWMI_EVENT_GUID ); +/*This one is useless if there is wmi-autoloading*/ +MODULE_ALIAS ("dmi:bvnMICRO-STARINTERNATIONALCO.,LTD:*:svnMICRO-STARINTERNATIO" +"NALCO.,LTD:pnMS-6638:*:rnMS-7438:*:cvnMICRO-STARINTERNATIONALCO." +",LTD:*" ); +MODULE_PARM_DESC (pression_timeout, +"How much time interrupts are ignored between each pression" );
This is not the best option name:
MODULE_PARM_DESC(debounce_interval,
"Controls how long driver will wait for button to debounce");
Signature · 5 lines
Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 10 lines · Dmitry Torokhov
Hi Anisse,
drivers/platform/x86/msi-wmi.c line 92
Quoted 4 lines · Anisse Astier
(quoted diff) +2
-0+ + if (jiffies_to_msecs(get_jiffies_64() -
msi_wmi_time_last_press)drivers/platform/x86/msi-wmi.c new file +1
-0+ > pression_timeout) {Why don't you use
time_after()instead of manual computation?
Quoted 4 lines
Also, what is the point of this? If you are trying to debounce the buttons this will not quite work. To do debouncing properly you need to store the value you just read and fire up a timer. When timer fires - that's the stable value.
Indeed, the point is to debounce the keys. I guess I’ll just use the debounce mecanism in use in the gpio_keys driver.
But why use a timer instead of a delayed workqueue? Do we need the precison of a timer for a simple debounce?
Quoted 6 lines
drivers/platform/x86/msi-wmi.c line 95
Quoted 4 lines
(quoted diff) +2
-0+ printk(KERN_DEBUG + "MSI WMI: event correctlyreceived: %llu\n",
drivers/platform/x86/msi-wmi.c new file +1
-0+ obj->integer.value);This is way too noisy for the mainline kernel,
pr_debug()perhaps?
Sure.
Quoted 4 lines
drivers/platform/x86/msi-wmi.c line 182
Quoted 1 line
drivers/platform/x86/msi-wmi.c new file +1
-0+msi_wmi_input_setup ();You need to handle errors returned by
msi_wmi_input_setup()as well.
Yes, I reworked the init in the second patch, I'll put the clean init in the first one for v2.
Quoted 10 lines
Quoted 3 lines
(quoted diff) +2
-0+MODULE_PARM_DESC(pression_timeout, + "How much time interrupts are ignored betweeneach pression");
This is not the best option name:
MODULE_PARM_DESC(debounce_interval,
"Controls how long driver will wait for button to
debounce");
Thanks a lot for your comments.
Regards,
Anisse
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 18 lines · Anisse Astier
Quoted 10 lines · Dmitry Torokhov
Hi Anisse,
drivers/platform/x86/msi-wmi.c line 92
Quoted 4 lines · Anisse Astier
(quoted diff) +2
-0+ + if (jiffies_to_msecs(get_jiffies_64() -
msi_wmi_time_last_press)drivers/platform/x86/msi-wmi.c new file +1
-0+ > pression_timeout) {Why don't you use
time_after()instead of manual computation?Quoted 4 lines
Also, what is the point of this? If you are trying to debounce the buttons this will not quite work. To do debouncing properly you need to store the value you just read and fire up a timer. When timer fires - that's the stable value.
Quoted 4 lines
Indeed, the point is to debounce the keys. I guess I’ll just use the debounce mecanism in use in the
gpio_keysdriver.
But why use a timer instead of a delayed workqueue? Do we need the precison of a timer for a simple debounce?
Unlike timer workqueue will not be rescheduled if it is already pending. mod_timer() will chnage the firing time.
Signature · 5 lines
Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · On Wednesday 02 December 2009 19:26:03 Anisse Astier wrote:
Signed-off-by Anisse Astier <[email protected]>---
Hi,This driver (intiated by
http://sysmic.org/dotclear2/index.php?post/2009/06/02/83-msi-wmi-support) is aimed at supporting WMI based hotkeys on MSI Windtop all-in-one AE1900-WT.
I've already submitted a driver together with some other fixes a month ago.
My driver not only registers an input device for backlight/volume up, down, but also registers a backlight driver for software based backlight switching.
Not sure whether Len already submitted it to he's test branch, I hope so:
http://patchwork.kernel.org/patch/55944/
Would be great if you can give it a try.
Thanks,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Thomas,
Quoted 11 lines · Thomas Renninger
Quoted 8 lines · On Wednesday 02 December 2009 19:26:03 Anisse Astier wrote:
Signed-off-by Anisse Astier <[email protected]>---
Hi,This driver (intiated by
http://sysmic.org/dotclear2/index.php?post/2009/06/02/83-msi-wmi-support) is aimed at supporting WMI based hotkeys on MSI Windtop all-in-one AE1900-WT.I've already submitted a driver together with some other fixes a month ago.
Indeed, I am sorry I didn't see it earlier. Did you write it from scratch or base it on Jerome's patch?
Quoted 2 lines
My driver not only registers an input device for backlight/volume up, down, but also registers a backlight driver for software based backlight switching.
Indeed, and that's very nice!
Quoted 5 lines
Not sure whether Len already submitted it to he's test branch, I hope so:
http://patchwork.kernel.org/patch/55944/Would be great if you can give it a try.
I gave it a try, it works great. Buttons works as expected, and the backlight interface works as well. Now I have a few questions/comments:
Quoted 1 line
+static int backlight_map[] = {
0x00,0x33,0x66,0x99,0xCC,0xFF};
Why just 6 levels for backlight? Wasn't it possible to map the whole range? Does it work the same way in windows?
Review
Quoted 10 lines
(quoted diff) +10
-0+#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/init.h> +#include <linux/types.h> +#include <linux/input.h> +#include <acpi/acpi_drivers.h> +#include <linux/acpi.h> +#include <linux/string.h> +#include <linux/hrtimer.h> +#include <linux/backlight.h>
Do you need all these #includes? (e.g string.h)
Quoted 1 line
+#define dprintk(msg...) do { \
Isn't reimplementing some kind of dprintk a little outdated with DYNAMIC_PRINTK now in kernel?
Review
Quoted 1 line
(quoted diff) +1
-0+ kfree(obj);
Good thing you're freeing the allocated acpi objects.
Review
Quoted 5 lines
(quoted diff) +5
-0+ cur = ktime_get_real(); + /* Ignore event if the same event happened in a 50 ms + timeframe -> Key press may result in 10-20 GPEs */ + if (ktime_to_us(ktime_sub(cur, key->last_pressed)) + < 1000 * 50) {
You're debouncing by computing the time difference instead of using a kernel timer.
Quoted 1 line
+static int
__initmsi_wmi_init(void)
You're init method could use some gotos to remove code duplication. (and merge some init with input_setup.)
I would be happy to transform these comments into patches once I have the time, and if you don't mind.
I could also adapt it for sparse keymaps as I did with the other driver (would reduce code size).
Best Regards,
Anisse
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 11 lines · On Friday 04 December 2009 11:15:06 Anisse Astier wrote:
Hi Thomas,
Quoted 6 lines · Thomas Renninger
Quoted 5 lines · On Wednesday 02 December 2009 19:26:03 Anisse Astier wrote:
Signed-off-by Anisse Astier <[email protected]>---
Hi,
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
This driver (intiated by
http://sysmic.org/dotclear2/index.php?post/2009/06/02/83-msi-wmi-support) is aimed at supporting WMI based hotkeys on MSI Windtop all-in-one AE1900-WT.I've already submitted a driver together with some other fixes a month ago.
Indeed, I am sorry I didn't see it earlier. Did you write it from scratch or base it on Jerome's patch?
I wrote it from scratch.
I started by taking over from hp-wmi, but later, beside of the key array setup, most things changed...
Quoted 7 lines
Quoted 2 lines
My driver not only registers an input device for backlight/volume up, down, but also registers a backlight driver for software based backlight switching.
Indeed, and that's very nice!
Quoted 4 lines
Not sure whether Len already submitted it to he's test branch, I hope so:
http://patchwork.kernel.org/patch/55944/
Quoted 8 lines
Quoted 1 line
Would be great if you can give it a try.
I gave it a try, it works great. Buttons works as expected, and the backlight interface works as well. Now I have a few questions/comments:
Quoted 1 line
+static int backlight_map[] = {
0x00,0x33,0x66,0x99,0xCC,0xFF};Why just 6 levels for backlight? Wasn't it possible to map the whole range? Does it work the same way in windows?
I got that from MSI people (one of the rare infos I got and that the irq storm is a "HW" bug/feature also showing up on Windows), they told me that's the values that should be used
(and yes, probably it's the way Windows works then as well).
Quoted 12 lines
Review
Quoted 10 lines
(quoted diff) +10
-0+#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/init.h> +#include <linux/types.h> +#include <linux/input.h> +#include <acpi/acpi_drivers.h> +#include <linux/acpi.h> +#include <linux/string.h> +#include <linux/hrtimer.h> +#include <linux/backlight.h>Do you need all these #includes? (e.g
string.h)
Quoted 3 lines
Quoted 1 line
+#define dprintk(msg...) do { \
Isn't reimplementing some kind of dprintk a little outdated with
DYNAMIC_PRINTKnow in kernel?
Eh, DYNAMIC_PRINTK?
grep DYNAMIC_PRINTK include/linux/ -r
is empty...
Quoted 2 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ kfree(obj);Good thing you're freeing the allocated acpi objects.
:)
Yep, I found that in hp-wmi when looking closer at it.
Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +5
-0+ cur = ktime_get_real(); + /* Ignore event if the same event happened in a 50 ms + timeframe -> Key press may result in 10-20 GPEs */ + if (ktime_to_us(ktime_sub(cur, key->last_pressed)) + < 1000 * 50) {You're debouncing by computing the time difference instead of using a kernel timer.
Do you see a problem with above?
You mean ktime_get_real() reads our the time via get getnstimeofday and accessing IO, while your get_jiffies_64() solution reads out a kernel variable incremented via timer irq which is a better solution?
While gettimeofday should be a fast TSC read on modern HW, I still have to agree.
Testing this I saw ~5-25 IRQs per key hit, showing up in about a ~30ms time frame, therefore I took 50ms ignoring the same IRQ and it worked out fine. Your last_time_pressed timeout of 10ms might be a bit too short...
Beside that (backlight) switching takes some time, but this should not be due to above "debouncing".
Quoted 6 lines
Quoted 1 line
+static int
__initmsi_wmi_init(void)You're init method could use some gotos to remove code duplication. (and merge some init with
input_setup.)I would be happy to transform these comments into patches once I have the time, and if you don't mind.
That would be great!
Quoted 2 lines
I could also adapt it for sparse keymaps as I did with the other driver (would reduce code size).
Cool.
Thanks for the review,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 7 lines · Thomas Renninger
Quoted 4 lines
Quoted 2 lines
+#define dprintk(msg...) do { \
Isn't reimplementing some kind of dprintk a little outdated with
DYNAMIC_PRINTKnow in kernel?Eh,
DYNAMIC_PRINTK?
grepDYNAMIC_PRINTKinclude/linux/-r
is empty...
My mistake, the option name is actually DYNAMIC_DEBUG, and is named "Enable dynamic printk() support" in Kernel Hacking config.
cf Documentation/dynamic-debug-howto.txt
Quoted 15 lines
Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +5
-0+ cur = ktime_get_real(); + /* Ignore event if the same event happened in a 50 ms + timeframe -> Key press may result in 10-20 GPEs */ + if (ktime_to_us(ktime_sub(cur, key->last_pressed)) + < 1000 * 50) {You're debouncing by computing the time difference instead of using a kernel timer.
Do you see a problem with above?
You meanktime_get_real()reads our the time via get getnstimeofday and accessing IO, while yourget_jiffies_64()solution reads out a kernel variable incremented via timer irq which is a better solution?
While gettimeofday should be a fast TSC read on modern HW, I still have to agree.
Quoted 3 lines
Testing this I saw ~5-25 IRQs per key hit, showing up in about a ~30ms time frame, therefore I took 50ms ignoring the same IRQ and it worked out fine. Your
last_time_pressedtimeout of 10ms might be a bit too short...
I see no problem with the above. It just works fine, whether you use get_jiffies or a ktime.
The thing Dmitry was proposing to do in his review to my patch, is to use a kernel timer (struct timer_list, mod_timer, etc.), and change the algorithm. Instead of having as a reference the first interrupt of (or bounce), you use the last one:
Every time an interrupt is fired, you call mod_timer() to the kick the timer further in time(say 20ms). Once you didn't have any interrupt for this given period of time, it means your button is stabilized, and the timer will fire your report_input function.
You can see how it's done in drivers/input/keybourd/gpio_keys.c
Quoted 3 lines
Beside that (backlight) switching takes some time, but this should not be due to above "debouncing".
Yep, I noticed that as well.
I verified, backlight behave the same in Windows. Slow switch, and just 6 levels.
Anisse
Quoted 6 lines · On Friday 04 December 2009 14:51:02 Anisse Astier wrote:
Quoted 4 lines · Thomas Renninger
Quoted 4 lines
Quoted 2 lines
+#define dprintk(msg...) do { \
Isn't reimplementing some kind of dprintk a little outdated with
DYNAMIC_PRINTKnow in kernel?
Quoted 7 lines
Quoted 3 lines
Eh,
DYNAMIC_PRINTK?
grepDYNAMIC_PRINTKinclude/linux/-r
is empty...My mistake, the option name is actually
DYNAMIC_DEBUG, and is named "Enable dynamicprintk()support" in Kernel Hacking config.
cfDocumentation/dynamic-debug-howto.txt
Good catch.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
(quoted diff) +5
-0+ cur = ktime_get_real(); + /* Ignore event if the same event happened in a 50 ms + timeframe -> Key press may result in 10-20 GPEs */ + if (ktime_to_us(ktime_sub(cur, key->last_pressed)) + < 1000 * 50) {
...
Quoted 11 lines
I see no problem with the above. It just works fine, whether you use
get_jiffiesor a ktime.The thing Dmitry was proposing to do in his review to my patch, is to use a kernel timer (struct
timer_list,mod_timer, etc.), and change the algorithm. Instead of having as a reference the first interrupt of (or bounce), you use the last one:
Every time an interrupt is fired, you callmod_timer()to the kick the timer further in time(say 20ms). Once you didn't have any interrupt for this given period of time, it means your button is stabilized, and the timer will fire yourreport_inputfunction.
I see these disadvantages:
- It would be more complicated code
- You have one extra irq (the one fired by your aimed timer which finally does the work)
- You react after the timeout (+50ms delay).
The latter two are not sever.
The advantage is:
- If you get constant irqs over the 30ms/50ms timeout, you would still only switch once.
But in this HW case, it really should be save with a 50ms timeout and I'd vote to take the ktime or get_jiffies approach.
Quoted 8 lines
You can see how it's done in
drivers/input/keybourd/gpio_keys.cQuoted 3 lines
Beside that (backlight) switching takes some time, but this should not be due to above "debouncing".
Yep, I noticed that as well.
I verified, backlight behave the same in Windows. Slow switch, and just 6 levels.
Thanks!
I'd prefer if Len could take on top patches, I don't want to touch this again any time soon if not necessary.
Thomas
Quoted 5 lines · Thomas Renninger
I'd prefer if Len could take on top patches, I don't want to touch this again any time soon if not necessary.
Thomas
FWIW, I agree.
Anisse