Fix debug output.
PATCH 1/1 Fix debug output.
--- drivers/net/dm9000x.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/dm9000x.c +2 -2
@@ -74,8 +74,8 @@ TODO: external MII is not functional, only internal at the moment. #define DM9000_DBG(fmt,args...) printf(fmt, ##args)#define DM9000_DMP_PACKET (func,packet,length) \ do { \ - int i; \ - printf(func ": length: %d\n", length); \ + int i; \ + printf("%s: length: %d\n",func, length); \ for (i = 0; i < length; i++) { \ if (i % 8 == 0) \ printf("\n%s: %02x: ", func, i); \
Signature · 1 line
1.6.4.4
PATCH 1/1 Fix debug output.
your subject line really needs a prefix to narrow down where exactly your fix is going. it also should not have a period.
net: dm9000x: fix debug output
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091207/f82635d6/attachment.pgp
PATCH 1/1 Fix debug output.
Quoted 6 lines · Mike Frysinger
your subject line really needs a prefix to narrow down where exactly your fix is going. it also should not have a period.
net: dm9000x: fix debug output
-mike
Hello,
should i resend the patch with the corrected subject line?
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091207/d90264bf/attachment.pgp
PATCH 1/1 Fix debug output.
Dear Thomas Weber,
Quoted 2 lines · In message <[email protected]> you wrote:
should i resend the patch with the corrected subject line?
No, because it needs other fixes (and explanations) anyway.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There are no data that cannot be plotted on a straight line if the axis are chosen correctly.
Wolfgang Denk
NAKPATCH 1/1 Fix debug output.
In reply to Thomas WeberDear Thomas Weber,
Quoted 10 lines · In message <[email protected]> you wrote:
Signed-off-by Thomas Weber <[email protected]>--- drivers/net/dm9000x.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/net/dm9000x.c +0
-0
drivers/net/dm9000x.c TODO: external MII is not functional, only internal at the moment. · line 81
Quoted 10 lines
drivers/net/dm9000x.c +2
-2@@ -74,8 +74,8 @@ TODO: external MII is not functional, only internal at the moment. #define DM9000_DBG(fmt,args...) printf(fmt, ##args)#define DM9000_DMP_PACKET (func,packet,length) \ do { \ - int i; \ - printf(func ": length: %d\n", length); \ + int i; \ + printf("%s: length: %d\n",func, length); \ for (i = 0; i < length; i++) { \ if (i % 8 == 0) \ printf("\n%s: %02x: ", func, i); \
Which problem is this supposed to fix?
Actually this patch introduces two new issues (the "int i;" line uses spaces for indentation, and the '\' are not vertically aligned any more).
NAK.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A girl with a future avoids the man with a past.
-- Evan Esar, "The Humor of Humor"PATCH 1/1 Fix debug output.
Quoted 32 lines · Wolfgang Denk
Dear Thomas Weber,
Quoted 11 lines · In message <[email protected]> you wrote:
Signed-off-by Thomas Weber <[email protected]>--- drivers/net/dm9000x.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/net/dm9000x.c +0
-0drivers/net/dm9000x.c TODO: external MII is not functional, only internal at the moment. · line 81
Quoted 10 lines
drivers/net/dm9000x.c +2
-2@@ -74,8 +74,8 @@ TODO: external MII is not functional, only internal at the moment. #define DM9000_DBG(fmt,args...) printf(fmt, ##args)#define DM9000_DMP_PACKET (func,packet,length) \ do { \ - int i; \ - printf(func ": length: %d\n", length); \ + int i; \ + printf("%s: length: %d\n",func, length); \ for (i = 0; i < length; i++) { \ if (i % 8 == 0) \ printf("\n%s: %02x: ", func, i); \Which problem is this supposed to fix?
Actually this patch introduces two new issues (the "int i;" line uses spaces for indentation, and the '\' are not vertically aligned any more).
Quoted 7 lines
NAK.
Best regards,
Wolfgang Denk
Hello,
In commit 60f61e6d7655400bb785a2ef637581679941f6d1 the following calls where changed.
- DM9000_DMP_PACKET("eth_send", packet, length);
+ DM9000_DMP_PACKET(__func__ , packet, length);
- DM9000_DMP_PACKET("eth_rx", rdptr, RxLen);
+ DM9000_DMP_PACKET(__func__ , rdptr, RxLen);
The identifier __func__ is used to call this macro. Formerly it was a string "eth_send" for the function name.
printf("eth_send" ":length ...") worked, but printf(__func__ ":length ...") doesn't compile. (tested with gcc-4.4.1)
Sorry, for space and it was the wrong tab space :(
Best Regards.
Thomas Weber
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091207/98f919f0/attachment.pgp
PATCH 1/1 Fix debug output.
Dear Thomas Weber,
Quoted 2 lines · In message <[email protected]> you wrote:
Quoted 2 lines
Which problem is this supposed to fix?
...
Quoted 9 lines
In commit
60f61e6d7655400bb785a2ef637581679941f6d1the following calls where changed.(quoted diff) +2
-2- DM9000_DMP_PACKET("eth_send", packet, length); + DM9000_DMP_PACKET(__func__ , packet, length); - DM9000_DMP_PACKET("eth_rx", rdptr, RxLen); + DM9000_DMP_PACKET(__func__ , rdptr, RxLen);
Quoted 5 lines
The identifier
__func__is used to call this macro. Formerly it was a string "eth_send" for the function name.
printf("eth_send" ":length ...")worked, butprintf(__func__ ":length ...")doesn't compile. (tested with gcc-4.4.1)
Well, and exactly this is valuable information which should be included into the commit message.
Indeed, neither __func__ nor __FUNCTION__ can be concatenated; for some reason gcc seems to consider these as strings, but not as string constants. Dunno why; probably there is a good reason for this, but it looks stupid to me.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Not one hundred percent efficient, of course ... but nothing ever is. -- Kirk, "Metamorphosis", stardate 3219.8
PATCH 1/1 Fix debug output.
Quoted 27 lines · Wolfgang Denk
Dear Thomas Weber,
Quoted 2 lines · In message <[email protected]> you wrote:
Quoted 2 lines
Which problem is this supposed to fix?
...
Quoted 9 lines
In commit
60f61e6d7655400bb785a2ef637581679941f6d1the following calls where changed.(quoted diff) +2
-2- DM9000_DMP_PACKET("eth_send", packet, length); + DM9000_DMP_PACKET(__func__ , packet, length); - DM9000_DMP_PACKET("eth_rx", rdptr, RxLen); + DM9000_DMP_PACKET(__func__ , rdptr, RxLen);Quoted 6 lines
The identifier
__func__is used to call this macro. Formerly it was a string "eth_send" for the function name.
printf("eth_send" ":length ...")worked, butprintf(__func__ ":length ...")doesn't compile. (tested with gcc-4.4.1)Well, and exactly this is valuable information which should be included into the commit message.
Quoted 10 lines
Indeed, neither
__func__nor__FUNCTION__can be concatenated; for some reason gcc seems to consider these as strings, but not as string constants. Dunno why; probably there is a good reason for this, but it looks stupid to me.Best regards,
Wolfgang Denk
Hello,
should I resend the better formatted patch with a proper subject line and a more detailed comment? How to name the patch? [Patch V2] ?
Thomas Weber
PATCH 1/1 Fix debug output.
Dear Thomas Weber,
Quoted 3 lines · In message <[email protected]> you wrote:
should I resend the better formatted patch with a proper subject line and a more detailed comment? How to name the patch? [Patch V2] ?
2 x yes, please.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de How come everyone's going so slow if it's called rush hour?