Skip to contentSkip to conversation

Fix computation in nand_util.c:get_len_incl_bad

PATCH New Daniel Hobi 3 participants 4 messages Dec 1, 2009 – Dec 7, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix computation in nand_util.c:get_len_incl_bad

Depending on offset, flash size and the number of bad blocks, get_len_incl_bad may return a too small value which may lead to:

1) If there are no bad blocks, nand_{read,write}_skip_bad chooses the bad block aware read/write code. This may hurt performance, but does not have any adverse effects.

2) If there are bad blocks, the nand_{read,write}_skip_bad may choose the bad block unaware read/write code (if len_incl_bad == *length) which leads to corrupted data.

---
@Scott: please review
@Wolfgang: please consider for 2009.11

drivers/mtd/nand/nand_util.c +1 -1
index bec9277..7085d42 100644
@@ -452,7 +452,7 @@ static size_t get_len_incl_bad (nand_info_t *nand, loff_t offset,
 		len_incl_bad += block_len;
 		offset       += block_len;
 
-		if ((offset + len_incl_bad) >= nand->size)
+		if (offset >= nand->size)
 			break;
 	}
 
Signature · 1 line
1.5.6.5
Applied
#1 lore raw

PATCH 1/1 Fix computation in nand_util.c:get_len_incl_bad

Quoted 10 lines · Daniel Hobi

Depending on offset, flash size and the number of bad blocks, get_len_incl_bad may return a too small value which may lead to:

1) If there are no bad blocks, nand_{read,write}_skip_bad chooses the bad block aware read/write code. This may hurt performance, but does not have any adverse effects.

2) If there are bad blocks, the nand_{read,write}_skip_bad may choose the bad block unaware read/write code (if len_incl_bad == *length) which leads to corrupted data.

It could also lead to the rejection of accesses near the end of flash.

Quoted 4 lines

---
@Scott: please review
@Wolfgang: please consider for 2009.11

Applied to next. I think it's too late for 2009.12, since it's supposed to be released tomorrow according to http://www.denx.de/wiki/U-Boot/ReleaseCycle,
and it's not a regression from the previous version.

-Scott

#2 lore raw

PATCH 1/1 Fix computation in nand_util.c:get_len_incl_bad

Dear Scott Wood,

Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 3 lines

@Scott: please review
@Wolfgang: please consider for 2009.11

Applied to next. I think it's too late for 2009.12, since it's supposed to be released tomorrow according to http://www.denx.de/wiki/U-Boot/ReleaseCycle,
and it's not a regression from the previous version.

Heh. We don't even have -rc2 yet.

Please feel free to send me a pull request if you consider it a fix.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I had the rare misfortune of being one of the first people to try and
implement a PL/1 compiler.                             -- T. Cheatham
#3 lore raw

PATCH 1/1 Fix computation in nand_util.c:get_len_incl_bad

In reply to Daniel Hobi

Dear Daniel Hobi,

drivers/mtd/nand/nand_util.c

Quoted 17 lines · In message <[email protected]> you…

Depending on offset, flash size and the number of bad blocks, get_len_incl_bad may return a too small value which may lead to:

1) If there are no bad blocks, nand_{read,write}_skip_bad chooses the bad block aware read/write code. This may hurt performance, but does not have any adverse effects.

2) If there are bad blocks, the nand_{read,write}_skip_bad may choose the bad block unaware read/write code (if len_incl_bad == *length) which leads to corrupted data.

---
@Scott: please review
@Wolfgang: please consider for 2009.11

drivers/mtd/nand/nand_util.c +0 -0

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Intelligence without character is a dangerous thing."   - G. Steinem