Skip to contentSkip to conversation

support for Embedian MXM-8x10

PATCH Superseded Edwin Peer 2 participants 4 messages Jan 22, 2010 – Feb 2, 2010 2 messages not in the archive

Subsystems (3)

v5 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Edwin Peer

author
#0 lore raw

PATCH v5 1/1 support for Embedian MXM-8x10

This version of the patch has added support for our iControl platform, which is based on the same MXM-8x10 module as the CAPC-7117 development board.

For the most part, it just reuses all the stuff in mxm8x10.c and adds support for some CAN bus chips.

Patch is still against vanilla 2.6.33-rc4.

Would appreciate comments.

Thank you.

Regards,
Edwin Peer

---

arch/arm/mach-pxa/Kconfig +10 -0
diff -Nurp linux-2.6.33-rc4/arch/arm/mach-pxa/Kconfig linux-embedian-2.6.33-rc4/arch/arm/mach-pxa/Kconfig
@@ -115,6 +115,11 @@ config MACH_CM_X300
 	select CPU_PXA310
 	select HAVE_PWM
 
+config MACH_CAPC7117
+	bool "Embedian CAPC-7117 evaluation kit based on the MXM-8x10 CoM"
+	select CPU_PXA320
+	select PXA3xx
+
 config ARCH_GUMSTIX
 	bool "Gumstix XScale 255 boards"
 	select PXA25x
@@ -492,6 +497,11 @@ config MACH_TOSA
 	select PXA25x
 	select PXA_HAVE_BOARD_IRQS
 
+config MACH_ICONTROL
+	bool "TMT iControl/SafeTCam based on the MXM-8x10 CoM"
+	select CPU_PXA320
+	select PXA3xx
+
 config ARCH_PXA_ESERIES
 	bool "PXA based Toshiba e-series PDAs"
 	select PXA25x
arch/arm/mach-pxa/Makefile +2 -0
diff -Nurp linux-2.6.33-rc4/arch/arm/mach-pxa/Makefile linux-embedian-2.6.33-rc4/arch/arm/mach-pxa/Makefile
@@ -48,6 +48,7 @@ obj-$(CONFIG_MACH_ARMCORE)	+= cm-x2xx-pc
 endif
 obj-$(CONFIG_MACH_EM_X270)	+= em-x270.o
 obj-$(CONFIG_MACH_CM_X300)      += cm-x300.o
+obj-$(CONFIG_MACH_CAPC7117)     += capc7117.o mxm8x10.o
 obj-$(CONFIG_ARCH_GUMSTIX)	+= gumstix.o
 obj-$(CONFIG_GUMSTIX_AM200EPD)	+= am200epd.o
 obj-$(CONFIG_GUMSTIX_AM300EPD)	+= am300epd.o
@@ -82,6 +83,7 @@ obj-$(CONFIG_PXA_SHARP_Cxx00)	+= spitz.o
 obj-$(CONFIG_CORGI_SSP_DEPRECATED)	+= corgi_ssp.o corgi_lcd.o
 obj-$(CONFIG_MACH_POODLE)	+= poodle.o
 obj-$(CONFIG_MACH_TOSA)		+= tosa.o
+obj-$(CONFIG_MACH_ICONTROL)     += icontrol.o mxm8x10.o
 obj-$(CONFIG_ARCH_PXA_ESERIES)	+= eseries.o
 obj-$(CONFIG_MACH_E330)		+= e330.o
 obj-$(CONFIG_MACH_E350)		+= e350.o
arch/arm/mach-pxa/capc7117.c +158 -0

158 lines not on this page · raw message

arch/arm/mach-pxa/icontrol.c +202 -0

202 lines not on this page · raw message

arch/arm/mach-pxa/include/mach/mxm8x10.h +22 -0
diff -Nurp linux-2.6.33-rc4/arch/arm/mach-pxa/include/mach/mxm8x10.h linux-embedian-2.6.33-rc4/arch/arm/mach-pxa/include/mach/mxm8x10.h
@@ -0,0 +1,22 @@
+#ifndef __MACH_MXM_8X10_H
+#define __MACH_MXM_8X10_H
+
+#define MXM_8X10_ETH_PHYS	0x13000000
+
+#define NAND_MMIO_START         0x43100000
+#define NAND_MMIO_END           0x43100080
+
+#define EXT_GPIO(x)     (128 + (x))
+
+#if defined(CONFIG_MMC)
+extern void mxm_8x10_mmc_init(void);
+#else
+static inline void mxm_8x10_mmc_init(void) {}
+#endif
+
+extern void mxm_8x10_usb_host_init(void);
+extern void mxm_8x10_ac97_init(void);
+
+extern void mxm_8x10_barebones_init(void);
+
+#endif /* __MACH_MXM_8X10_H */
arch/arm/mach-pxa/mxm8x10.c +474 -0

474 lines not on this page · raw message

#1 lore raw

PATCH v5 1/1 support for Embedian MXM-8x10

Quoted 4 lines

+static struct spi_board_info mcp251x_board_info[] = {
+ ? ? ? {
+ ? ? ? ? ? ? ? .modalias ? ? ? ?= "mcp251x",
+ ? ? ? ? ? ? ? .max_speed_hz ? ?= 65E5,

This looks weird to me, should be an integer here right?

Quoted 6 lines

+ ? ? ? ? ? ? ? .bus_num ? ? ? ? = 3,
+ ? ? ? ? ? ? ? .chip_select ? ? = 0,
+ ? ? ? ? ? ? ? .platform_data ? = &mcp251x_info,
+ ? ? ? ? ? ? ? .controller_data = &mcp251x_chip_info1,
+ ? ? ? ? ? ? ? .irq ? ? ? ? ? ? = gpio_to_irq(ICONTROL_MCP251x_nIRQ1)
+ ? ? ? },

author
#2 lore raw

PATCH v5 1/1 support for Embedian MXM-8x10

Quoted 6 lines · On Monday 01 February 2010 22:42:00 Eric Miao wrote:

arch/arm/mach-pxa/icontrol.c line 85

Quoted 4 lines
arch/arm/mach-pxa/icontrol.c +4 -0
+static struct spi_board_info mcp251x_board_info[] = {
+       {
+               .modalias        = "mcp251x",
+               .max_speed_hz    = 65E5,

This looks weird to me, should be an integer here right?

Correct. That's 65 x 10^5, or equivalently 6.5 x 10^6. Would you prefer the patch to have it in decimal?

Regards,
Edwin Peer

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#5 lore raw

PATCH v5 1/1 support for Embedian MXM-8x10

Quoted 10 lines · On Tuesday 02 February 2010 08:10:32 you wrote:
Quoted 7 lines · Edwin Peer

On Tuesday 02 February 2010 08:02:07 you wrote:

Ah, okay, 6.5 x 10^5. That does make more sense. I had forgotten that C had a syntax for that. Would have probably written it as 6500000(d) myself.

Will respond accordingly to Eric.

Eric is quite correct, though. The (free-standing) type *is* float.

It's too early in the morning for me - brain is not working yet. Okay, will fix and send new patch.

Regards,
Edwin Peer