greth: fall through to common return statement on error
Subsystems (2)
PATCH 1/1 greth: fall through to common return statement on error
There doesn't seem to be any reason to explicitly return NETDEV_TX_OK as err is set to NETDEV_TX_OK in all cases that reach this point.
Signed-off-by Simon Horman <[email protected]>
---
Cosmetic change brought about by curiosity as to weather returning NETDEV_TX_OK on these error conditions is correct. I have similar curiosity relating to greth_start_xmit().
drivers/net/greth.c +0 -2
@@ -556,8 +556,6 @@ map_error:if (net_ratelimit ())dev_warn (greth->dev,"Could not create TX DMA mapping\n" );dev_kfree_skb (skb); -return NETDEV_TX_OK ; - out:return err; }
David Miller
maintainerFrom: Simon Horman <[email protected]>
Date: Fri, 26 Feb 2010 10:50:19 +1100
Quoted 5 lines
There doesn't seem to be any reason to explicitly return
NETDEV_TX_OKas err is set toNETDEV_TX_OKin all cases that reach this point.Signed-off-by Simon Horman <[email protected]>
Looks fine, applied.