Skip to contentSkip to conversation

greth: fall through to common return statement on error

PATCH In review Simon Horman 2 participants 2 messages Feb 25, 2010 – Feb 26, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 greth: fall through to common return statement on error

There doesn't seem to be any reason to explicitly return NETDEV_TX_OK as err is set to NETDEV_TX_OK in all cases that reach this point.

---

Cosmetic change brought about by curiosity as to weather returning NETDEV_TX_OK on these error conditions is correct. I have similar curiosity relating to greth_start_xmit().

drivers/net/greth.c +0 -2
Index: net-next-2.6/drivers/net/greth.c
===================================================================
@@ -556,8 +556,6 @@ map_error:
 	if (net_ratelimit())
 		dev_warn(greth->dev, "Could not create TX DMA mapping\n");
 	dev_kfree_skb(skb);
-	return NETDEV_TX_OK;
-
 out:
 	return err;
 }