korina: use resource_size()
Subsystems (3)
PATCH 1/1 korina: use resource_size()
This size calculation is wrong. It should be end - start + 1. Use resource_size() to calculate it correctly.
Signed-off-by Dan Carpenter <[email protected]>
---
I don't have a way to test this, or even to compile it. :/
drivers/net/korina.c +3 -3
@@ -1135,7 +1135,7 @@ static int korina_probe(struct platform_device *pdev) r =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"korina_regs" ); dev->base_addr = r->start; - lp->eth_regs =ioremap_nocache (r->start, r->end - r->start); + lp->eth_regs =ioremap_nocache (r->start,resource_size (r));if (!lp->eth_regs) { printk(KERN_ERR DRV_NAME ": cannot remap registers\n"); rc = -ENXIO ;
@@ -1143,7 +1143,7 @@ static int korina_probe(struct platform_device *pdev) } r =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"korina_dma_rx" ); - lp->rx_dma_regs =ioremap_nocache (r->start, r->end - r->start); + lp->rx_dma_regs =ioremap_nocache (r->start,resource_size (r));if (!lp->rx_dma_regs) { printk(KERN_ERR DRV_NAME ": cannot remap Rx DMA registers\n"); rc = -ENXIO ;
@@ -1151,7 +1151,7 @@ static int korina_probe(struct platform_device *pdev) } r =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"korina_dma_tx" ); - lp->tx_dma_regs =ioremap_nocache (r->start, r->end - r->start); + lp->tx_dma_regs =ioremap_nocache (r->start,resource_size (r));if (!lp->tx_dma_regs) { printk(KERN_ERR DRV_NAME ": cannot remap Tx DMA registers\n"); rc = -ENXIO ;
From: Dan Carpenter <[email protected]>
Date: Mon, 22 Mar 2010 15:11:45 +0300
Quoted 4 lines
This size calculation is wrong. It should be end - start + 1. Use
resource_size()to calculate it correctly.Signed-off-by Dan Carpenter <[email protected]>
Applied.