Skip to contentSkip to conversation

raw-posix: don't assign bs->read_only

PATCH Applied Christoph Hellwig 3 participants 3 messages Apr 7, 2010 – Apr 10, 2010 Block layer

lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 raw-posix: don't assign bs->read_only

bdrv_open already takes care of this for us.

Signed-off-by Christoph Hellwig <[email protected]>
block/raw-posix.c +0 -1
Index: qemu/block/raw-posix.c
===================================================================
@@ -142,7 +142,6 @@ static int raw_open_common(BlockDriverSt
         s->open_flags |= O_RDWR;
     } else {
         s->open_flags |= O_RDONLY;
-        bs->read_only = 1;
     }
 
     /* Use O_DSYNC for write-through caching, no flags for write-back caching,
Acked-by on v1 1/1
#1 lore raw

Am 07.04.2010 13:58, schrieb Christoph Hellwig:

Quoted 9 lines

bdrv_open already takes care of this for us.

Signed-off-by Christoph Hellwig <[email protected]>

Index: qemu/block/raw-posix.c
===================================================================

block/raw-posix.c static int raw_open_common(BlockDriverSt · line 147

Quoted 7 lines
block/raw-posix.c +0 -1
@@ -142,7 +142,6 @@ static int raw_open_common(BlockDriverSt
         s->open_flags |= O_RDWR;
     } else {
         s->open_flags |= O_RDONLY;
-        bs->read_only = 1;
     }
 
     /* Use O_DSYNC for write-through caching, no flags for write-back caching,
Acked-by Kevin Wolf <[email protected]>
Applied
#2 lore raw
In reply to Christoph Hellwig
Quoted 1 line · Christoph Hellwig

bdrv_open already takes care of this for us.

Thanks, applied.

Quoted 17 lines
Signed-off-by Christoph Hellwig <[email protected]>

Index: qemu/block/raw-posix.c
===================================================================

block/raw-posix.c +0 -1
@@ -142,7 +142,6 @@ static int raw_open_common(BlockDriverSt
         s->open_flags |= O_RDWR;
     } else {
         s->open_flags |= O_RDONLY;
-        bs->read_only = 1;
     }
 
     /* Use O_DSYNC for write-through caching, no flags for write-back caching,
Signature · 2 lines
Aurelien Jarno                          GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net