Skip to contentSkip to conversation

TI: DaVinci: Create configuration file for da850 EVM

PATCH New Sudhakar Rajashekhara 2 participants 3 messages Apr 28, 2010 – May 7, 2010 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 TI: DaVinci: Create configuration file for da850 EVM

Provides initial support for TI OMAP-L138/DA850 SoC devices on a Logic PD EVM board.

---
 MAINTAINERS                |    4 +
 MAKEALL                    |    1 +
 Makefile                   |    3 +
 include/configs/da850evm.h |  135 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 143 insertions(+), 0 deletions(-)
 create mode 100644 include/configs/da850evm.h
MAINTAINERS +4 -0
index a5d5835..c52803d 100644
@@ -758,6 +758,10 @@ Nick Thompson <[email protected]>
 
 	da830evm	ARM926EJS (DA830/OMAP-L137)
 
+Sudhakar Rajashekhara <[email protected]>
+
+	da850evm	ARM926EJS (DA850/OMAP-L138)
+
 Albin Tonnerre <[email protected]>
 
 	sbc35_a9g20	ARM926EJS (AT91SAM9G20 SoC)
MAKEALL +1 -0
index 34bc4a1..cdb6676 100755
@@ -559,6 +559,7 @@ LIST_ARM9="			\
 	cp946es			\
 	cp966			\
 	da830evm		\
+	da850evm		\
 	edb9301			\
 	edb9302			\
 	edb9302a		\
Makefile +3 -0
index 393b180..0f21db6 100644
@@ -2913,6 +2913,9 @@ cp922_XA10_config	\
 cp1026_config: unconfig
 	@board/armltd/integrator/split_by_variant.sh cp $@
 
+da850evm_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci
+
 da830evm_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci
 
include/configs/da850evm.h new file +135 -0

135 lines not on this page · raw message

Signature · 1 line
1.5.6
#1 lore raw

PATCH 3/3 TI: DaVinci: Create configuration file for da850 EVM

Dear Sudhakar Rajashekhara,

Quoted 11 lines · In message <[email protected]> you wrote:

Provides initial support for TI OMAP-L138/DA850 SoC devices on a Logic PD EVM board.

---
 MAINTAINERS                |    4 +
 MAKEALL                    |    1 +
 Makefile                   |    3 +
 include/configs/da850evm.h |  135 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 143 insertions(+), 0 deletions(-)
 create mode 100644 include/configs/da850evm.h

Patches 2 and 3 should be merged into one, please.

MAINTAINERS Nick Thompson <[email protected]> · line 765

Quoted 13 lines
MAINTAINERS +4 -0
index a5d5835..c52803d 100644
@@ -758,6 +758,10 @@ Nick Thompson <[email protected]>
 
 	da830evm	ARM926EJS (DA830/OMAP-L137)
 
+Sudhakar Rajashekhara <[email protected]>
+
+	da850evm	ARM926EJS (DA850/OMAP-L138)
+
 Albin Tonnerre <[email protected]>

Please keep list sorted.

Makefile cp922_XA10_config \ · line 2920

Quoted 13 lines
Makefile +3 -0
index 393b180..0f21db6 100644
@@ -2913,6 +2913,9 @@ cp922_XA10_config	\
 cp1026_config: unconfig
 	@board/armltd/integrator/split_by_variant.sh cp $@
 
+da850evm_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci
+
 da830evm_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci

Please keep list sorted, and use just a single entry, i. e.:

	da830evm_config	\
	da850evm_config:	unconfig
		@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci
Quoted 5 lines
include/configs/da850evm.h new file +0 -0
new file mode 100644
index 0000000..2fcc76d

...

include/configs/da850evm.h line 52

Quoted 9 lines
include/configs/da850evm.h new file +9 -0
+/*
+ * Memory Info
+ */
+#define CONFIG_SYS_MALLOC_LEN	(0x10000 + 1*1024*1024) /* malloc() len */
+#define CONFIG_SYS_GBL_DATA_SIZE	128 /* reserved for initial data */
+#define PHYS_SDRAM_1		DAVINCI_DDR_EMIF_DATA_BASE /* DDR Start */
+#define PHYS_SDRAM_1_SIZE	(64 << 20) /* SDRAM size 64MB */
+#define CONFIG_SYS_MEMTEST_START	PHYS_SDRAM_1 + 0x2000000 /* memtest start addr */
+#define CONFIG_SYS_MEMTEST_END 	(PHYS_SDRAM_1 + 0x2000000 + 16*1024*1024) /* 16MB test */

Line too long.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The reasonable man adapts himself to the world; the unreasonable  one
persists  in  trying  to  adapt  the  world to himself. Therefore all
progress depends on the unreasonable man."      - George Bernard Shaw
#2 lore raw

PATCH 3/3 TI: DaVinci: Create configuration file for da850 EVM

Hi,

Quoted 15 lines · Wolfgang Denk

Dear Sudhakar Rajashekhara,

Quoted 11 lines · In message <[email protected]> you wrote:

Provides initial support for TI OMAP-L138/DA850 SoC devices on a Logic PD EVM board.

---
 MAINTAINERS                |    4 +
 MAKEALL                    |    1 +
 Makefile                   |    3 +
 include/configs/da850evm.h |  135 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 143 insertions(+), 0 deletions(-)
 create mode 100644 include/configs/da850evm.h
Quoted 2 lines

Patches 2 and 3 should be merged into one, please.

Ok, I'll merge them.

Quoted 8 lines
Quoted 8 lines
MAINTAINERS +0 -0
index a5d5835..c52803d 100644
@@ -758,6 +758,10 @@ Nick Thompson <[email protected]>
 
 	da830evm	ARM926EJS (DA830/OMAP-L137)
 
Quoted 8 lines

MAINTAINERS Nick Thompson <[email protected]> · line 765

Quoted 5 lines
MAINTAINERS +4 -0
+Sudhakar Rajashekhara <[email protected]>
+
+	da850evm	ARM926EJS (DA850/OMAP-L138)
+
 Albin Tonnerre <[email protected]>

Please keep list sorted.

Ok.

Quoted 8 lines
Quoted 8 lines
Makefile +0 -0
index 393b180..0f21db6 100644
@@ -2913,6 +2913,9 @@ cp922_XA10_config	\
 cp1026_config: unconfig
 	@board/armltd/integrator/split_by_variant.sh cp $@
 
Quoted 8 lines

Makefile cp922_XA10_config \ · line 2920

Quoted 5 lines
Makefile +3 -0
+da850evm_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci
+
 da830evm_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci

Please keep list sorted, and use just a single entry, i. e.:

Ok.

Quoted 10 lines
	da830evm_config	\
	da850evm_config:	unconfig
		@$(MKCONFIG) $(@:_config=) arm arm926ejs da8xxevm davinci davinci
Quoted 5 lines
include/configs/da850evm.h new file +0 -0
new file mode 100644
index 0000000..2fcc76d

...

Quoted 12 lines

include/configs/da850evm.h line 52

Quoted 9 lines
include/configs/da850evm.h new file +9 -0
+/*
+ * Memory Info
+ */
+#define CONFIG_SYS_MALLOC_LEN	(0x10000 + 1*1024*1024) /* malloc() len */
+#define CONFIG_SYS_GBL_DATA_SIZE	128 /* reserved for initial data */
+#define PHYS_SDRAM_1		DAVINCI_DDR_EMIF_DATA_BASE /* DDR Start */
+#define PHYS_SDRAM_1_SIZE	(64 << 20) /* SDRAM size 64MB */
+#define CONFIG_SYS_MEMTEST_START	PHYS_SDRAM_1 + 0x2000000 /* memtest start addr */
+#define CONFIG_SYS_MEMTEST_END 	(PHYS_SDRAM_1 + 0x2000000 + 16*1024*1024) /* 16MB test */

Line too long.

I'll address the review comments and will submit the updated version.

Thanks,
Sudhakar