Skip to contentSkip to conversation

fs: thaw_bdev() should return EINVAL if bd_fsfreeze_count is 0

PATCH Superseded Masayoshi MIZUMA 1 participant 1 message Jun 2, 2010 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: thaw_bdev() should return EINVAL if bd_fsfreeze_count is 0

Hi,

thaw_bdev() should return EINVAL if bd_fsfreeze_count is 0 at entering thaw_bdev() because it is expected that bd_fsfreeze_count is incremented by freeze_bdev().

This bug was added by commit:4504230a71566785a05d3e6b53fa1ee071b864eb

---
 fs/block_dev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/block_dev.c +1 -1
index 6dcee88..90992b3 100644
@@ -331,7 +331,7 @@ out_unfrozen:
                deactivate_locked_super(sb);
 out_unlock:
        mutex_unlock(&bdev->bd_fsfreeze_mutex);
-       return 0;
+       return error;
 }
 EXPORT_SYMBOL(thaw_bdev);
 

--
1.6.6

Thanks,
Masayoshi