(pxe:server_ip:gateway_ip) parsing wrong?

While writing documentation for booting GRUB over the network, I noticed that the code to handle (pxe:server_ip:gateway_ip) device names looks wrong. Shouldn't it be like this?

2010-06-07 Colin Watson <[email protected]>

* fs/i386/pc/pxe.c (grub_pxe_open): Fix parsing of gateway_ip.

=== modified file 'fs/i386/pc/pxe.c'

@@ -114,7 +114,7 @@ grub_pxe_open (const char *name, grub_di
 	return err;
       if (*ptr == ':')
 	{
-	  err = parse_ip (ptr + 1, &(data->server_ip), 0);
+	  err = parse_ip (ptr + 1, &(data->gateway_ip), 0);
 	  if (err)
 	    return err;
 	}

Thanks,

Colin Watson                                       [[email protected]]

Oh, and speaking of PXE support, what's the point of the pxe_unload command? As near as I can tell, it seems to be the equivalent of 'rmmod pxe'. Is there some reason one might want to run this if pxe were built into the core image, or is it cruft that we should remove?

Colin Watson                                       [[email protected]]

Quoting Colin Watson, who wrote the following on Mon, 7 Jun 2010:

Yea that is a bit weird -- I could understand if pxe_unload called the
PXE terminate API to free all resources and end the PXE firmware session, but the way it is now it seems a bit useless.

--S

Go ahead.

Regards
Vladimir 'φ-coder/phcoder' Serbinenko